From patchwork Wed Jan 23 11:36:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roland Stigge X-Patchwork-Id: 2024291 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 85F0BDFE76 for ; Wed, 23 Jan 2013 11:39:46 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TxydK-0008G6-11; Wed, 23 Jan 2013 11:36:46 +0000 Received: from [2a01:4f8:101:2a4:0:bc28:b2d8:8] (helo=chuck.antcom.de) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TxydG-0008Fo-F0 for linux-arm-kernel@lists.infradead.org; Wed, 23 Jan 2013 11:36:43 +0000 Received: from [IPv6:2001:a60:f08d:1:224:81ff:fe9f:119e] (unknown [IPv6:2001:a60:f08d:1:224:81ff:fe9f:119e]) by chuck.antcom.de (Postfix) with ESMTPSA id 268241ECE00A; Wed, 23 Jan 2013 11:36:38 +0000 (UTC) Message-ID: <50FFCB44.4000403@antcom.de> Date: Wed, 23 Jan 2013 12:36:36 +0100 From: Roland Stigge Organization: ANTCOM IT Research & Development User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.11) Gecko/20121123 Icedove/10.0.11 MIME-Version: 1.0 To: Gabriele Mondada Subject: Re: [PATCH] Implements DMA on mmci driver for LPC3250 plateform References: In-Reply-To: X-Enigmail-Version: 1.4 OpenPGP: url=subkeys.pgp.net X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130123_063642_735035_DA66CBAC X-CRM114-Status: GOOD ( 19.12 ) X-Spam-Score: -1.1 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS Cc: Cedric Berger , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 01/23/2013 11:11 AM, Gabriele Mondada wrote: > Signed-off-by: Gabriele Mondada > > UPDATE: Here is the patch cleaned up and validated with scripts/checkpatch.pl. I also add a check to prevent crashing when DMA is disabled. > > ORIGINAL POST: > Hi, > Currently, LPC32xx plateform do not enable DMA on the mmci driver. This makes the driver useless because getting out data from a 64 bytes FIFO by interrupt is not fast enough (at standard SD-card data rate). > > DMA is not enabled because LPC32xx has a bug that prevent DMA to work properly with the MMC controller (silicon bug, I guess). NXP did a patch to workaround this, but it has not been commited on the main branch. The patch is for linux 2.6.39.2 and does not use dmaengine. > > So, I reworked this patch to make it compatible with the last kernel (3.7). Here it is. Have I any chance to see this patch be commited on the main branch? > > Thanks a lot, > Gabriele > Please consider that when I got this mail, the source/patch formatting was broken, like this: drivers/dma/amba-pl08x.c | 20 ++++++ drivers/mmc/host/mmci.c | 159 = +++++++++++++++++++++++++++++++++++++++++----- drivers/mmc/host/mmci.h | 12 +++- 3 files changed, 174 insertions(+), 17 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index d1cc579..728f65f 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -1758,6 +1758,26 @@ static void pl08x_free_virtual_channels(struct = dma_device *dmadev) } } Please use "git send-email" or sth. where code is included unchanged. Thanks, Roland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel