| Message ID | 5108A913.6080304@asianux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Chen Gang <gang.chen@asianux.com> writes: > temp need NUL terminated, or next ptr may cause issue. > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > arch/arm/mach-msm/clock-debug.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-msm/clock-debug.c > b/arch/arm/mach-msm/clock-debug.c > index 4886404..bdca900 100644 > --- a/arch/arm/mach-msm/clock-debug.c > +++ b/arch/arm/mach-msm/clock-debug.c > @@ -105,6 +105,8 @@ int __init clock_debug_add(struct clk *clock) > return -ENOMEM; > > strncpy(temp, clock->dbg_name, ARRAY_SIZE(temp)-1); > + temp[ARRAY_SIZE(temp)-1] = '\0'; > + > for (ptr = temp; *ptr; ptr++) > *ptr = tolower(*ptr); Maybe use strlcpy() instead? Bjørn
? 2013?01?30? 17:19, Bjørn Mork ??:
> Maybe use strlcpy() instead?
ok, I will send patch v2.
it will be "strlcpy(temp, clock->dbg_name, ARRAY_SIZE(temp));"
thanks.
Chen Gang <gang.chen@asianux.com> writes: > temp need NUL terminated, or next ptr may cause issue. > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > arch/arm/mach-msm/clock-debug.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-msm/clock-debug.c > b/arch/arm/mach-msm/clock-debug.c > index 4886404..bdca900 100644 > --- a/arch/arm/mach-msm/clock-debug.c > +++ b/arch/arm/mach-msm/clock-debug.c > @@ -105,6 +105,8 @@ int __init clock_debug_add(struct clk *clock) > return -ENOMEM; > > strncpy(temp, clock->dbg_name, ARRAY_SIZE(temp)-1); > + temp[ARRAY_SIZE(temp)-1] = '\0'; > + > for (ptr = temp; *ptr; ptr++) I believe that Stephen Boyd is putting some significant work into this code. Stephen, can you see if this bug is still in your current version of the code, and make sure that it is fixed there? Thanks, David
On 01/30/13 13:33, David Brown wrote: > Chen Gang <gang.chen@asianux.com> writes: > >> temp need NUL terminated, or next ptr may cause issue. >> >> Signed-off-by: Chen Gang <gang.chen@asianux.com> >> --- >> arch/arm/mach-msm/clock-debug.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/mach-msm/clock-debug.c >> b/arch/arm/mach-msm/clock-debug.c >> index 4886404..bdca900 100644 >> --- a/arch/arm/mach-msm/clock-debug.c >> +++ b/arch/arm/mach-msm/clock-debug.c >> @@ -105,6 +105,8 @@ int __init clock_debug_add(struct clk *clock) >> return -ENOMEM; >> >> strncpy(temp, clock->dbg_name, ARRAY_SIZE(temp)-1); >> + temp[ARRAY_SIZE(temp)-1] = '\0'; >> + >> for (ptr = temp; *ptr; ptr++) > I believe that Stephen Boyd is putting some significant work into this > code. Stephen, can you see if this bug is still in your current > version of the code, and make sure that it is fixed there? > This entire file is deleted in my set of patches that moves the current MSM clock code to the common clock framework.
? 2013?01?31? 05:59, Stephen Boyd ??: > On 01/30/13 13:33, David Brown wrote: >> I believe that Stephen Boyd is putting some significant work into this >> code. Stephen, can you see if this bug is still in your current >> version of the code, and make sure that it is fixed there? >> > > This entire file is deleted in my set of patches that moves the current > MSM clock code to the common clock framework. > ok, thank you. :-)
diff --git a/arch/arm/mach-msm/clock-debug.c b/arch/arm/mach-msm/clock-debug.c index 4886404..bdca900 100644 --- a/arch/arm/mach-msm/clock-debug.c +++ b/arch/arm/mach-msm/clock-debug.c @@ -105,6 +105,8 @@ int __init clock_debug_add(struct clk *clock) return -ENOMEM; strncpy(temp, clock->dbg_name, ARRAY_SIZE(temp)-1); + temp[ARRAY_SIZE(temp)-1] = '\0'; + for (ptr = temp; *ptr; ptr++) *ptr = tolower(*ptr);
temp need NUL terminated, or next ptr may cause issue. Signed-off-by: Chen Gang <gang.chen@asianux.com> --- arch/arm/mach-msm/clock-debug.c | 2 ++ 1 file changed, 2 insertions(+)