From patchwork Thu May 16 16:05:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 2579251 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id 8D35D4020A for ; Thu, 16 May 2013 16:40:47 +0000 (UTC) Received: from merlin.infradead.org ([205.233.59.134]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ud0o8-0007ff-Jt; Thu, 16 May 2013 16:13:35 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ud0nO-0008BZ-Gb; Thu, 16 May 2013 16:12:46 +0000 Received: from mail-lb0-f174.google.com ([209.85.217.174]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ud0nL-0008AA-C7 for linux-arm-kernel@lists.infradead.org; Thu, 16 May 2013 16:12:44 +0000 Received: by mail-lb0-f174.google.com with SMTP id u10so1272524lbi.5 for ; Thu, 16 May 2013 09:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=aNplWXGZzfUX+XTNVSYjVWKiPzv0eSKccwm5f9wUIFA=; b=vLTBgjURmribLSgZ/kGmUrNx7kvhGXFK+hdPW1tY9tI+70xJA2knD/QRnl9GxQ1rhr 8IZRnJ9SiIlHxWCswsM9iX6GLzZo4b9T3F3qfD1kmCtCF9Raai7O30ir3YoHqFi4iv5c r+twme4r43tXsJkX0QrPJ+mdFerHC12QFpxO97zni8LB/VXWljBc+lDMdwJILAivzhbG yirm2nfCZdc650VVQ/BWXRU/a+yFpbKZWadxeCIBsquIrSGNEKYZGSca/zKG8X2p4ub+ T7hd5IQ2aQXq3HYKQwlwW2ugymrkGNWbi5dqpps0x5Xk+dueNg5J2pn+sV3F6JRbpJmb wusw== X-Received: by 10.112.126.9 with SMTP id mu9mr20040774lbb.99.1368720349643; Thu, 16 May 2013 09:05:49 -0700 (PDT) Received: from [192.168.1.3] (a91-156-160-115.elisa-laajakaista.fi. [91.156.160.115]) by mx.google.com with ESMTPSA id ky7sm3359804lbc.16.2013.05.16.09.05.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 16 May 2013 09:05:48 -0700 (PDT) Message-ID: <519503DA.5070303@iki.fi> Date: Thu, 16 May 2013 19:05:46 +0300 From: Tomi Valkeinen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy References: <1366697656-14315-1-git-send-email-kishon@ti.com> <51936946.3030507@iki.fi> <20130516155857.GV5600@atomide.com> In-Reply-To: <20130516155857.GV5600@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130516_121243_584092_C4328F4B X-CRM114-Status: GOOD ( 20.07 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tomi.valkeinen[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.217.174 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, balbi@ti.com, Kishon Vijay Abraham I , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 16/05/13 18:58, Tony Lindgren wrote: > * Tomi Valkeinen [130515 03:59]: >> On 23/04/13 09:14, Kishon Vijay Abraham I wrote: >>> After the device names are created using PLATFORM_DEVID_AUTO, the old >>> device names given in usb_bind_phy are no longer valid causing the musb >>> controller not to get the phy reference. Updated the usb_bind_phy with >>> the new device names to get MUSB functional in omap4 panda. >>> >>> Signed-off-by: Kishon Vijay Abraham I >>> --- >>> Tested in OMAP4 PANDA. >>> arch/arm/mach-omap2/board-4430sdp.c | 2 +- >>> arch/arm/mach-omap2/board-omap4panda.c | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c >>> index 00d7290..56a9a4f 100644 >>> --- a/arch/arm/mach-omap2/board-4430sdp.c >>> +++ b/arch/arm/mach-omap2/board-4430sdp.c >>> @@ -730,7 +730,7 @@ static void __init omap_4430sdp_init(void) >>> omap4_sdp4430_wifi_init(); >>> omap4_twl6030_hsmmc_init(mmc); >>> >>> - usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); >>> + usb_bind_phy("musb-hdrc.2.auto", 0, "omap-usb2.3.auto"); >>> usb_musb_init(&musb_board_data); >>> >>> status = omap_ethernet_init(); >> >> I'm seeing >> >> [ 2.190155] unable to find transceiver >> [ 2.190155] HS USB OTG: no transceiver configured >> [ 2.190155] musb-hdrc musb-hdrc.0.auto: musb_init_controller failed >> with status -517 >> [ 2.207458] platform musb-hdrc.0.auto: Driver musb-hdrc requests >> probe deferral >> >> on 4430sdp with v3.10-rc1. Does that mean that the musb-hdrc.0.auto was >> indeed correct, and the new value of musb-hdrc.2.auto is not? > > Just checking.. Do you have CONFIG_OMAP_OCP2SCP=y in your .config? Sounds > like the some transceivers should depend on that for omap4. Yes, I have OCP2SCP=y. >> The musb-hdrc id is wrong on overo also. > > Hmm has there been a fix posted for that? I couldn't find with a quick look. We debugged and discussed this on an irc channel with Kishon, who said he'll send a patch. Changing the musb-hdrc ID on overo fixed the issue, and it looks very similar to the error on 4430sdp. The overo fix was just: Is that ID "randomly" chosen? Doesn't that mean that it'll just get broken every now and then? Tomi diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c index 4ca6b68..a496774 100644 --- a/arch/arm/mach-omap2/board-overo.c +++ b/arch/arm/mach-omap2/board-overo.c @@ -472,7 +472,7 @@ static void __init overo_init(void) mt46h32m32lf6_sdrc_params); board_nand_init(overo_nand_partitions, ARRAY_SIZE(overo_nand_partitions), NAND_CS, 0, NULL); - usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); + usb_bind_phy("musb-hdrc.1.auto", 0, "twl4030_usb"); usb_musb_init(NULL); usbhs_init_phys(phy_data, ARRAY_SIZE(phy_data));