From patchwork Mon May 20 07:48:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 2592741 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id CBB253FE81 for ; Mon, 20 May 2013 13:05:18 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UePm7-0002md-JY; Mon, 20 May 2013 13:05:15 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UeKrB-0006qi-HX; Mon, 20 May 2013 07:50:09 +0000 Received: from intranet.asianux.com ([58.214.24.6]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UeKr7-0006pA-Ay for linux-arm-kernel@lists.infradead.org; Mon, 20 May 2013 07:50:07 +0000 Received: by intranet.asianux.com (Postfix, from userid 103) id B514718403F7; Mon, 20 May 2013 15:49:42 +0800 (CST) X-Spam-Score: -100.8 X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on intranet.asianux.com X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=AWL,BAYES_00, RATWARE_GECKO_BUILD,USER_IN_WHITELIST autolearn=no version=3.1.9 Received: from [10.1.0.143] (unknown [219.143.36.82]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranet.asianux.com (Postfix) with ESMTP id 676CD184024F; Mon, 20 May 2013 15:49:42 +0800 (CST) Message-ID: <5199D565.4070307@asianux.com> Date: Mon, 20 May 2013 15:48:53 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: "mingo@redhat.com" , peterz@infradead.org Subject: [PATCH] kernel/sched/core.c: need return NULL when BUG() is defined as empty. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130520_035005_639873_350E1531 X-CRM114-Status: GOOD ( 12.21 ) X-Spam-Score: -3.0 (---) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-3.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.1 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org When neither CONFIG_BUG nor HAVE_ARCH_BUG is defined, need let function return failure value ('NULL') instead of random value. It is generated by randconfig with MMU for arm s5pv210 with EXTRA_CFALGS=-W. The related warnings: kernel/sched/core.c:2353:1: warning: control reaches end of non-void function [-Wreturn-type] Signed-off-by: Chen Gang --- kernel/sched/core.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 9ff7744..94ef8ff 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -2350,6 +2350,7 @@ pick_next_task(struct rq *rq) } BUG(); /* the idle class will always have a runnable task */ + return NULL; } /*