From patchwork Thu Aug 15 14:01:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Austin X-Patchwork-Id: 2845179 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CC3699F239 for ; Thu, 15 Aug 2013 14:02:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 810D22028F for ; Thu, 15 Aug 2013 14:02:44 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DE22201BB for ; Thu, 15 Aug 2013 14:02:39 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V9y8J-0006pJ-M7; Thu, 15 Aug 2013 14:02:35 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V9y8H-0007Dk-HF; Thu, 15 Aug 2013 14:02:33 +0000 Received: from service88.mimecast.com ([195.130.217.12]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V9y8E-0007CT-IN for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2013 14:02:31 +0000 Received: from emea-cam-gw1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) (Using TLS) by service88.mimecast.com; Thu, 15 Aug 2013 15:01:59 +0100 Received: from [10.1.199.156] (10.1.2.13) by emea-cam-gw1.Emea.Arm.com (10.1.248.203) with Microsoft SMTP Server id 8.3.298.1; Thu, 15 Aug 2013 15:01:58 +0100 Message-ID: <520CDF4D.6050702@arm.com> Date: Thu, 15 Aug 2013 15:01:49 +0100 From: Jonathan Austin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH Resend 1/3] PSCI: add missing dependency on CONFIG_OF for PSCI. References: <1376500987-12797-1-git-send-email-jonathan.austin@arm.com> <1376500987-12797-2-git-send-email-jonathan.austin@arm.com> In-Reply-To: <1376500987-12797-2-git-send-email-jonathan.austin@arm.com> X-MC-Unique: 113081515015900402 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130815_100230_839331_0DB4D955 X-CRM114-Status: GOOD ( 14.08 ) X-Spam-Score: -2.6 (--) Cc: Jonathan Austin X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 14/08/13 18:23, Jonathan Austin wrote: > The PSCI initialisation depends on data found in the DT. Without this the > including PSCI support makes little sense, and furthermore the of_* stub > functions aren't broad enough to ensure that this builds without CONFIG_OF. > > As there is little enthusiasm for extending these stubs without useful use-cases > (of which this is *not* an example) this patch prevents building of PSCI > without CONFIG_OF. > > Signed-off-by: Jonathan Austin > --- > arch/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index ba412e0..972ec25 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1577,6 +1577,7 @@ config HOTPLUG_CPU > config ARM_PSCI > bool "Support for the ARM Power State Coordination Interface (PSCI)" > depends on CPU_V7 > + depends on CONFIG_OF > help > Say Y here if you want Linux to communicate with system firmware > implementing the PSCI specification for CPU-centric power > As Sergei pointed out, this should just be OF not CONFIG_OF.... ------8<------- ---->8--------------- -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 43594d5..f004de7 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1577,6 +1577,7 @@ config HOTPLUG_CPU config ARM_PSCI bool "Support for the ARM Power State Coordination Interface (PSCI)" depends on CPU_V7 + depends on OF help Say Y here if you want Linux to communicate with system firmware implementing the PSCI specification for CPU-centric power