diff mbox

[1/2] zynq: Do not explicitely enable icache

Message ID 521bc636ed31ff2958f8c95417b09036a523782c.1388742126.git.michal.simek@xilinx.com (mailing list archive)
State New, archived
Headers show

Commit Message

Michal Simek Jan. 3, 2014, 9:42 a.m. UTC 
icache is already enabled by default.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 board/xilinx/zynq/board.c | 2 --
 1 file changed, 2 deletions(-)

--
1.8.2.3

Comments

Arnd Bergmann Jan. 3, 2014, 12:52 p.m. UTC | #1 
On Friday 03 January 2014, Michal Simek wrote:
> icache is already enabled by default.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  board/xilinx/zynq/board.c | 2 --
>  1 file changed, 2 deletions(-)

You had me confused for a bit. Please mark u-boot patches as such
when you send them to the kernel mailing list, and vice-versa.

	Arnd
Michal Simek Jan. 3, 2014, 1:34 p.m. UTC | #2 
On 01/03/2014 01:52 PM, Arnd Bergmann wrote:
> On Friday 03 January 2014, Michal Simek wrote:
>> icache is already enabled by default.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  board/xilinx/zynq/board.c | 2 --
>>  1 file changed, 2 deletions(-)
> 
> You had me confused for a bit. Please mark u-boot patches as such
> when you send them to the kernel mailing list, and vice-versa.

oou. Patman (tools I use for sending patches to mailing list)
took arm prefix because of my bad setting.

Sorry for that.

Thanks,
Michal
Russell King - ARM Linux Jan. 3, 2014, 2:21 p.m. UTC | #3 
On Fri, Jan 03, 2014 at 01:52:51PM +0100, Arnd Bergmann wrote:
> On Friday 03 January 2014, Michal Simek wrote:
> > icache is already enabled by default.
> > 
> > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> > ---
> > 
> >  board/xilinx/zynq/board.c | 2 --
> >  1 file changed, 2 deletions(-)
> 
> You had me confused for a bit. Please mark u-boot patches as such
> when you send them to the kernel mailing list, and vice-versa.

Better still, they shouldn't be sent to the kernel mailing lists in the
first place - they're off-topic here.
diff mbox

Patch

diff --git a/board/xilinx/zynq/board.c b/board/xilinx/zynq/board.c
index 5119c09..7c1632f 100644
--- a/board/xilinx/zynq/board.c
+++ b/board/xilinx/zynq/board.c
@@ -49,8 +49,6 @@  int board_init(void)
 	}
 #endif

-	icache_enable();
-
 #ifdef CONFIG_FPGA
 	fpga_init();
 	fpga_add(fpga_xilinx, &fpga);