From patchwork Thu Oct 3 13:39:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benoit Cousson X-Patchwork-Id: 2982911 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0303E9F288 for ; Thu, 3 Oct 2013 13:40:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1995620364 for ; Thu, 3 Oct 2013 13:40:28 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2A732035D for ; Thu, 3 Oct 2013 13:40:22 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VRj8W-000730-Jd; Thu, 03 Oct 2013 13:40:12 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VRj8O-0003OM-Ob; Thu, 03 Oct 2013 13:40:04 +0000 Received: from mail-we0-f180.google.com ([74.125.82.180]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VRj8K-0003NQ-S8 for linux-arm-kernel@lists.infradead.org; Thu, 03 Oct 2013 13:40:02 +0000 Received: by mail-we0-f180.google.com with SMTP id q59so2300627wes.11 for ; Thu, 03 Oct 2013 06:39:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:organization:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=ri6GkcgOwLPdSoxcgQD2hWMDkT1et5fOjx0FnUrx5pU=; b=JaSVg3rg5oPA6nArSOY3BzsuXGifeApJN1S+24CD+gk0mRgptdka/hW8pR6bK+jzGw VMfXCW+xh2U2NEhstSy+CqFHQgLtNaU2mH1+9HMYRCKUH3k/W/SMq0pu3b3ChqlN7bSQ 79ubI1Z1W3d5tN+5Ix5+St2EIFkrEPXrnFclm7vvshadIAROgtYbgMzR4H3aQke7QCxv LaVa4lQCtBf5pmVqmbbs5cLQLEWS/S2D5Q8X3PN0rMtvWl1G025i68T8TD0ShAa08Rqa P/axSYax9F/gNivh/tFfKZn1JfjFzMPu+97JGRazXqxslA+30CfQcU4/vdfJIu8BTydo rdaQ== X-Gm-Message-State: ALoCoQkUGRlZHuZRF8VwUY/vi0zySBHatNOSDBkDClJaa0l0BY779pfMibifYah6/UFRSJSKdbcv X-Received: by 10.194.77.167 with SMTP id t7mr7275547wjw.27.1380807578792; Thu, 03 Oct 2013 06:39:38 -0700 (PDT) Received: from [172.31.213.56] ([46.218.123.34]) by mx.google.com with ESMTPSA id j5sm13938227wia.4.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 03 Oct 2013 06:39:37 -0700 (PDT) Message-ID: <524D7397.2000200@baylibre.com> Date: Thu, 03 Oct 2013 15:39:35 +0200 From: Benoit Cousson Organization: BayLibre User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Keerthy Subject: Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes References: <1377495411-21984-1-git-send-email-j-keerthy@ti.com> <522E1FB2.10809@ti.com> <522FFFE2.2000705@ti.com> In-Reply-To: <522FFFE2.2000705@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131003_094001_154583_3ABA7F2B X-CRM114-Status: GOOD ( 16.38 ) X-Spam-Score: -2.6 (--) Cc: Nishanth Menon , devicetree@vger.kernel.org, balajitk@ti.com, pawel.moll@arm.com, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Keerthy, On 11/09/2013 07:30, Keerthy wrote: > On Tuesday 10 September 2013 12:51 AM, Nishanth Menon wrote: >> On 08/26/2013 12:36 AM, Keerthy wrote: >>> The Patch adds nodes for TPS659038 PMIC for DRA7 boards. >>> >>> It is based on top of: >>> http://comments.gmane.org/gmane.linux.ports.arm.omap/102459. >>> >>> Documentation: Documentation/devicetree/bindings/mfd/palmas.txt >>> Documentation/devicetree/bindings/regulator/palmas-pmic.txt >>> >>> Boot Tested on DRA7 d1 Board. >>> >>> Signed-off-by: Keerthy >>> --- >>> arch/arm/boot/dts/dra7-evm.dts | 118 >>> ++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 118 insertions(+) >>> >>> Index: linux/arch/arm/boot/dts/dra7-evm.dts >>> =================================================================== >>> --- linux.orig/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 >>> 09:57:52.496173554 +0530 >>> +++ linux/arch/arm/boot/dts/dra7-evm.dts 2013-08-26 >>> 10:38:44.995414695 +0530 >>> @@ -93,6 +93,119 @@ >>> pinctrl-names = "default"; >>> pinctrl-0 = <&i2c1_pins>; >>> clock-frequency = <400000>; >>> + >>> + tps659038: tps659038@58 { >>> + compatible = "ti,tps659038"; >>> + reg = <0x58>; >>> + >>> + tps659038_pmic { >>> + compatible = "ti,tps659038-pmic"; >>> + >>> + regulators { >>> + smps123_reg: smps123 { >>> + /* VDD_MPU */ >>> + regulator-name = "smps123"; >>> + regulator-min-microvolt = < 850000>; >>> + regulator-max-microvolt = <1250000>; >>> + regulator-always-on; >>> + regulator-boot-on; >>> + }; >>> + >>> + smps45_reg: smps45 { >>> + /* VDD_DSPEVE */ >>> + regulator-name = "smps45"; >>> + regulator-min-microvolt = < 850000>; >>> + regulator-max-microvolt = <1150000>; >>> + regulator-boot-on; >>> + }; >>> + >>> + smps6_reg: smps6 { >>> + /* VDD_GPU - over VDD_SMPS6 */ >>> + regulator-name = "smps6"; >>> + regulator-min-microvolt = <850000>; >>> + regulator-max-microvolt = <12500000>; >>> + regulator-boot-on; >>> + }; >>> + >>> + smps7_reg: smps7 { >>> + /* CORE_VDD */ >>> + regulator-name = "smps7"; >>> + regulator-min-microvolt = <850000>; >>> + regulator-max-microvolt = <1030000>; >>> + regulator-always-on; >>> + regulator-boot-on; >>> + }; >>> + >>> + smps8_reg: smps8 { >>> + /* VDD_IVAHD */ >>> + regulator-name = "smps8"; >>> + regulator-min-microvolt = < 850000>; >>> + regulator-max-microvolt = <1250000>; >>> + regulator-boot-on; >>> + }; >>> + >>> + smps9_reg: smps9 { >>> + /* VDDS1V8 */ >>> + regulator-name = "smps9"; >>> + regulator-min-microvolt = <1800000>; >>> + regulator-max-microvolt = <1800000>; >>> + regulator-always-on; >>> + regulator-boot-on; >>> + }; >>> + >>> + ldo1_reg: ldo1 { >>> + /* LDO1_OUT --> SDIO */ >>> + regulator-name = "ldo1"; >>> + regulator-min-microvolt = <1800000>; >>> + regulator-max-microvolt = <3300000>; >>> + regulator-boot-on; >>> + }; >>> + >>> + ldo2_reg: ldo2 { >>> + /* VDD_RTCIO */ >>> + /* LDO2 -> VDDSHV5, LDO2 also goes to >>> CAN_PHY_3V3 */ >>> + regulator-name = "ldo2"; >>> + regulator-min-microvolt = <3300000>; >>> + regulator-max-microvolt = <3300000>; >>> + regulator-boot-on; >>> + }; >>> + >>> + ldo3_reg: ldo3 { >>> + /* VDDA_1V8_PHY */ >>> + regulator-name = "ldo3"; >>> + regulator-min-microvolt = <1800000>; >>> + regulator-max-microvolt = <1800000>; >>> + regulator-boot-on; >>> + }; >>> + >>> + ldo9_reg: ldo9 { >>> + /* VDD_RTC */ >>> + regulator-name = "ldo9"; >>> + regulator-min-microvolt = <1050000>; >>> + regulator-max-microvolt = <1050000>; >>> + regulator-boot-on; >>> + }; >>> + >>> + ldoln_reg: ldoln { >>> + /* VDDA_1V8_PLL */ >>> + regulator-name = "ldoln"; >>> + regulator-min-microvolt = <1800000>; >>> + regulator-max-microvolt = <1800000>; >>> + regulator-always-on; >>> + regulator-boot-on; >>> + }; >>> + >>> + ldousb_reg: ldousb { >>> + /* VDDA_3V_USB: VDDA_USBHS33 */ >>> + regulator-name = "ldousb"; >>> + regulator-min-microvolt = <3300000>; >>> + regulator-max-microvolt = <3300000>; >>> + regulator-boot-on; >>> + }; >>> + Nit: Extra blank line not needed. >>> + }; >>> + }; >>> + }; >>> }; Nit: You have an extra level on indentation not needed. >>> &i2c2 { >>> >> Acked-by: Nishanth Menon Beside the two minors nits, the patch looks good to me. Since, you've been waiting for some time for it, I fixed it myself and pulled it. I even fixed the changelog... Lucky you :-) You can check the updated version below. Sorry for the delay. Thanks, Benoit --- From 3b8f02a2df475c7a48e12eb1911c014f8060b167 Mon Sep 17 00:00:00 2001 From: Keerthy Date: Mon, 26 Aug 2013 11:06:51 +0530 Subject: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes Add DT nodes for TPS659038 PMIC on DRA7 boards. It is based on top of: http://comments.gmane.org/gmane.linux.ports.arm.omap/102459. Documentation: - Documentation/devicetree/bindings/mfd/palmas.txt - Documentation/devicetree/bindings/regulator/palmas-pmic.txt Boot Tested on DRA7 d1 Board. Signed-off-by: Keerthy Acked-by: Nishanth Menon [bcousson@baylibre.com: Fix indentation and changelog] Signed-off-by: Benoit Cousson --- arch/arm/boot/dts/dra7-evm.dts | 112 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 112 insertions(+) diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts index ca5dab2..fbbe406 100644 --- a/arch/arm/boot/dts/dra7-evm.dts +++ b/arch/arm/boot/dts/dra7-evm.dts @@ -93,6 +93,118 @@ pinctrl-names = "default"; pinctrl-0 = <&i2c1_pins>; clock-frequency = <400000>; + + tps659038: tps659038@58 { + compatible = "ti,tps659038"; + reg = <0x58>; + + tps659038_pmic { + compatible = "ti,tps659038-pmic"; + + regulators { + smps123_reg: smps123 { + /* VDD_MPU */ + regulator-name = "smps123"; + regulator-min-microvolt = < 850000>; + regulator-max-microvolt = <1250000>; + regulator-always-on; + regulator-boot-on; + }; + + smps45_reg: smps45 { + /* VDD_DSPEVE */ + regulator-name = "smps45"; + regulator-min-microvolt = < 850000>; + regulator-max-microvolt = <1150000>; + regulator-boot-on; + }; + + smps6_reg: smps6 { + /* VDD_GPU - over VDD_SMPS6 */ + regulator-name = "smps6"; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <12500000>; + regulator-boot-on; + }; + + smps7_reg: smps7 { + /* CORE_VDD */ + regulator-name = "smps7"; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <1030000>; + regulator-always-on; + regulator-boot-on; + }; + + smps8_reg: smps8 { + /* VDD_IVAHD */ + regulator-name = "smps8"; + regulator-min-microvolt = < 850000>; + regulator-max-microvolt = <1250000>; + regulator-boot-on; + }; + + smps9_reg: smps9 { + /* VDDS1V8 */ + regulator-name = "smps9"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + regulator-boot-on; + }; + + ldo1_reg: ldo1 { + /* LDO1_OUT --> SDIO */ + regulator-name = "ldo1"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + }; + + ldo2_reg: ldo2 { + /* VDD_RTCIO */ + /* LDO2 -> VDDSHV5, LDO2 also goes to CAN_PHY_3V3 */ + regulator-name = "ldo2"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + }; + + ldo3_reg: ldo3 { + /* VDDA_1V8_PHY */ + regulator-name = "ldo3"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + }; + + ldo9_reg: ldo9 { + /* VDD_RTC */ + regulator-name = "ldo9"; + regulator-min-microvolt = <1050000>; + regulator-max-microvolt = <1050000>; + regulator-boot-on; + }; + + ldoln_reg: ldoln { + /* VDDA_1V8_PLL */ + regulator-name = "ldoln"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + regulator-boot-on; + }; + + ldousb_reg: ldousb { + /* VDDA_3V_USB: VDDA_USBHS33 */ + regulator-name = "ldousb"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + }; + }; + }; + }; }; &i2c2 {