From patchwork Thu Oct 17 10:55:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep KarkadaNagesha X-Patchwork-Id: 3060141 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 305BC9F243 for ; Thu, 17 Oct 2013 10:55:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 907F820459 for ; Thu, 17 Oct 2013 10:55:50 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C90E20455 for ; Thu, 17 Oct 2013 10:55:49 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWlF2-0007St-NO; Thu, 17 Oct 2013 10:55:44 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWlF0-0000DT-Bq; Thu, 17 Oct 2013 10:55:42 +0000 Received: from service87.mimecast.com ([91.220.42.44]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWlEx-0000D4-V0 for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2013 10:55:40 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 17 Oct 2013 11:55:15 +0100 Received: from [10.1.207.23] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 17 Oct 2013 11:55:14 +0100 Message-ID: <525FC218.7020404@arm.com> Date: Thu, 17 Oct 2013 11:55:20 +0100 From: Sudeep KarkadaNagesha User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Pawel Moll Subject: Re: [PATCH 2/2] ARM: vexpress: Enable platform-specific options in defconfig References: <1381930594-1701-1-git-send-email-pawel.moll@arm.com> <1381930594-1701-3-git-send-email-pawel.moll@arm.com> <525FB49C.7040607@arm.com> <1382006321.27517.119.camel@hornet> In-Reply-To: <1382006321.27517.119.camel@hornet> X-OriginalArrivalTime: 17 Oct 2013 10:55:14.0698 (UTC) FILETIME=[5BF096A0:01CECB27] X-MC-Unique: 113101711551500501 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131017_065540_169628_E20B12CA X-CRM114-Status: GOOD ( 14.51 ) X-Spam-Score: -2.6 (--) Cc: Fathi Boudra , "arm@kernel.org" , Russell King , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Pawel, On 17/10/13 11:38, Pawel Moll wrote: > On Thu, 2013-10-17 at 10:57 +0100, Sudeep KarkadaNagesha wrote: >>> +CONFIG_MTD_PHYSMAP=y >>> +CONFIG_MTD_PHYSMAP_OF=y >> >> This could cause issues with CPUIdle on TC2. Since TC2 reset vector is in NOR >> flash, NOR flash has to be in Read mode when CPU resets and enter reset vector. >> But what I have seen is that NOR flash is left in Read Identifier Mode after the >> driver is initialised. So we need to make sure NOR device is in Read mode >> whenever CPU enters deeper C-states and also may have to register notifiers >> which seems overkill IMO. Most of the platform have separate(or secure) flash >> for this reason. > > Oh boy, yes, I remember this now. > >> Is it possible to disable flash on TC2 only in it's DT something like >> flash@0,00000000 { >> status = "disabled"; >> }; > > But flash is innocent, really... I may just remove CPU_IDLE for the time > being. > I tried disabling flash device only on TC2 in DT which seem to work for me. Regards, Sudeep -->8 diff --git a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts index d2836a2..f649c58 100644 --- a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts +++ b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts @@ -418,3 +418,12 @@ /include/ "vexpress-v2m-rs1.dtsi" }; }; +/ { + smb { + motherboard { + flash@0,00000000 { + status = "disabled"; + }; + }; + }; +};