From patchwork Wed Dec 11 00:05:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sherman Yin X-Patchwork-Id: 3321361 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1090C9F37A for ; Wed, 11 Dec 2013 00:06:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2C2D8206FE for ; Wed, 11 Dec 2013 00:06:49 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34E16206FA for ; Wed, 11 Dec 2013 00:06:48 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqXK4-0004Qd-Qg; Wed, 11 Dec 2013 00:06:40 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqXK2-0002ED-83; Wed, 11 Dec 2013 00:06:38 +0000 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqXJz-0002DD-Nl for linux-arm-kernel@lists.infradead.org; Wed, 11 Dec 2013 00:06:36 +0000 X-IronPort-AV: E=Sophos;i="4.93,867,1378882800"; d="scan'208";a="1408423" Received: from irvexchcas07.broadcom.com (HELO IRVEXCHCAS07.corp.ad.broadcom.com) ([10.9.208.55]) by mail-gw3-out.broadcom.com with ESMTP; 10 Dec 2013 16:06:21 -0800 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS07.corp.ad.broadcom.com (10.9.208.55) with Microsoft SMTP Server (TLS) id 14.1.438.0; Tue, 10 Dec 2013 16:05:59 -0800 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Tue, 10 Dec 2013 16:05:59 -0800 Received: from [10.136.4.120] (testboard2-syin.ric.broadcom.com [10.136.4.120]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 45CDE246A3; Tue, 10 Dec 2013 16:05:56 -0800 (PST) Message-ID: <52A7AC4A.8010504@broadcom.com> Date: Tue, 10 Dec 2013 16:05:30 -0800 From: Sherman Yin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Christian Daudt , Stephen Warren , Kevin Hilman , Linus Walleij Subject: Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver References: <1380846199-12829-1-git-send-email-syin@broadcom.com> <1380846199-12829-4-git-send-email-syin@broadcom.com> <525FFA40.9050901@wwwdotorg.org> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131210_190635_994181_40710C8F X-CRM114-Status: GOOD ( 18.57 ) X-Spam-Score: -2.1 (--) Cc: Mark Rutland , "devicetree@vger.kernel.org" , Russell King , Markus Mayer , Pawel Moll , Ian Campbell , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rob Herring , bcm-kernel-feedback-list , Rob Landley , Grant Likely , Matt Porter , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 13-10-17 08:31 AM, Christian Daudt wrote: > On Thu, Oct 17, 2013 at 7:54 AM, Stephen Warren wrote: >> On 10/17/2013 12:03 AM, Christian Daudt wrote: >>> On Thu, Oct 3, 2013 at 5:23 PM, Sherman Yin wrote: >>>> Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs. >>>> >>>> Signed-off-by: Sherman Yin >>>> Reviewed-by: Christian Daudt >>>> Reviewed-by: Matt Porter >>>> --- >>>> arch/arm/mach-bcm/Kconfig | 2 + >>>> drivers/pinctrl/Kconfig | 10 + >>>> drivers/pinctrl/Makefile | 1 + >>>> drivers/pinctrl/pinctrl-capri.c | 1727 +++++++++++++++++++++++++++++++++++++++ >>>> 4 files changed, 1740 insertions(+) >>>> create mode 100644 drivers/pinctrl/pinctrl-capri.c >>>> >>>> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig >>>> index 69d67f7..2546365 100644 >>>> --- a/arch/arm/mach-bcm/Kconfig >>>> +++ b/arch/arm/mach-bcm/Kconfig >>>> @@ -10,6 +10,8 @@ config ARCH_BCM >>>> select GENERIC_CLOCKEVENTS >>>> select GENERIC_TIME >>>> select GPIO_BCM >>>> + select PINCTRL >>>> + select PINCTRL_CAPRI >>>> select SPARSE_IRQ >>>> select TICK_ONESHOT >>>> select CACHE_L2X0 >>> >>> On your subsequent patchset pls move this from Kconfig to >>> arm/configs/bcm_defconfig, and break that modification into a separate >>> patch from the drivers/* modification. >> >> The other SoCs I'm familiar with all select this from their ARCH_xxx >> config symbol. >> > I had a discussion on what is best left under ARCH and what is best > left to defconfig with Kevin Hilman a while back and the conclusion > was that any config not strictly required for bootup is best left to > defconfig. This will allow multiplatform kernels to switch to using > them as loadable modules later on, something not possible with configs > put under ARCH_xxx. > > Thanks, > csd > I was just trying to move "select PINCTRL" to a defconfig as Christian suggested. However, CONFIG_PINCTRL is not selectable by a defconfig file (the option will be gone by the time .config is generated), even though PINCTRL has no dependency. Also, this option is not visible in menuconfig. I found that by adding a string after "bool" in the PINCTRL config definition (see diff below), CONFIG_PINCTRL will be selectable in a defconfig file and this option will also be visible in menuconfig. Was this intentional or is this a bug? To address Christian's comment, I'll need to add the following patch. Regards, Sherman ================== diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 6c70fc5..664c8e6 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -3,7 +3,7 @@ # config PINCTRL - bool + bool "Enable the pinctrl framework" if PINCTRL ==================