From patchwork Fri Dec 13 18:51:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Troy Kisky X-Patchwork-Id: 3342141 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BD576C0D4A for ; Fri, 13 Dec 2013 18:51:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DE18B207D1 for ; Fri, 13 Dec 2013 18:51:57 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A6D3207B8 for ; Fri, 13 Dec 2013 18:51:56 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VrXq0-0003Qx-K2; Fri, 13 Dec 2013 18:51:48 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VrXpy-00068L-42; Fri, 13 Dec 2013 18:51:46 +0000 Received: from mail-pa0-f54.google.com ([209.85.220.54]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VrXpw-00067j-0p for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2013 18:51:44 +0000 Received: by mail-pa0-f54.google.com with SMTP id rd3so391218pab.27 for ; Fri, 13 Dec 2013 10:51:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=MhQSFFTbhCQU4I31DXBPyx+WQtd2Mi/LceMpUQWH9Os=; b=PZpiHu73bmaljFHhMvGrHNxB55OxSyCAD72ITsr9ZDWz3h6m7i4c9fIXck1EtWtuXr hHoeHgZSpZLt2IboWs5oo1viYD2NthpGZVFj/3B4ecS7Pau49w5T9fSHlYAkfafUOT3s MPCgnT09KL7A8tshsM1Kp2DsRLPb7ahXtijTVHU+SgR954EDPiQ6xtW1O4tofpnLNFsD aUYJG8hrzLLJSy5Pz5W2XSW+kATEQA5otsV+Viz2AamptJhFHeKQWReqpsIZRtfs5baY oh9n+Jn5iKiUCWjMHbGc7Lu+psoTI8G79wr0X7QpIw2ar/sGQcazTj2glG5NcKqeaBmg uhcg== X-Gm-Message-State: ALoCoQnJSc0VfUh86bfys+xmYc2yZRp3/rB0E+nzYz/Q/I24jOF0elmdgXdQewpd9t3WNye9+Rgp X-Received: by 10.68.88.161 with SMTP id bh1mr5026115pbb.49.1386960682241; Fri, 13 Dec 2013 10:51:22 -0800 (PST) Received: from [192.168.0.242] ([63.226.49.26]) by mx.google.com with ESMTPSA id b3sm6640064pbu.38.2013.12.13.10.51.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Dec 2013 10:51:21 -0800 (PST) Message-ID: <52AB5729.9010603@boundarydevices.com> Date: Fri, 13 Dec 2013 11:51:21 -0700 From: Troy Kisky User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Marek Vasut Subject: Re: [PATCH V1 01/11] ARM: dts: imx: sabrelite: add Dual Lite/Solo support References: <1386899355-17379-1-git-send-email-troy.kisky@boundarydevices.com> <1386899355-17379-2-git-send-email-troy.kisky@boundarydevices.com> <201312131246.00944.marex@denx.de> In-Reply-To: <201312131246.00944.marex@denx.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131213_135144_141233_154ABCAC X-CRM114-Status: GOOD ( 13.46 ) X-Spam-Score: -2.6 (--) Cc: shawn.guo@linaro.org, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, eric.nelson@boundarydevices.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 12/13/2013 4:46 AM, Marek Vasut wrote: > On Friday, December 13, 2013 at 02:49:05 AM, Troy Kisky wrote: >> This makes the structure of Sabre Lite board files the same >> as Sabre SD board files so that they are easier to compare. >> >> By this, I mean that the majority of the file imx6q-sabrelite.dts >> is moved to imx6qdl-sabrelite.dtsi so that both imx6q-sabrelite.dts >> and imx6dl-sabrelite.dts can include it. >> >> Now Sabre Lite has support for Dual Lite/Solo >> processors. >> >> Signed-off-by: Troy Kisky >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/imx6dl-sabrelite.dts | 20 ++ >> arch/arm/boot/dts/imx6q-sabrelite.dts | 214 >> +-------------------- ...{imx6q-sabrelite.dts => imx6qdl-sabrelite.dtsi} | >> 10 - >> 4 files changed, 22 insertions(+), 223 deletions(-) >> create mode 100644 arch/arm/boot/dts/imx6dl-sabrelite.dts >> copy arch/arm/boot/dts/{imx6q-sabrelite.dts => imx6qdl-sabrelite.dtsi} >> (96%) >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 342d16d..3c6f456 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -149,6 +149,7 @@ dtb-$(CONFIG_ARCH_MXC) += \ >> imx6dl-gw53xx.dtb \ >> imx6dl-gw54xx.dtb \ >> imx6dl-sabreauto.dtb \ >> + imx6dl-sabrelite.dtb \ >> imx6dl-sabresd.dtb \ >> imx6dl-wandboard.dtb \ >> imx6q-arm2.dtb \ >> diff --git a/arch/arm/boot/dts/imx6dl-sabrelite.dts >> b/arch/arm/boot/dts/imx6dl-sabrelite.dts new file mode 100644 >> index 0000000..2de0447 >> --- /dev/null >> +++ b/arch/arm/boot/dts/imx6dl-sabrelite.dts >> @@ -0,0 +1,20 @@ >> +/* >> + * Copyright 2011 Freescale Semiconductor, Inc. >> + * Copyright 2011 Linaro Ltd. > Are you sure about this copyright message ? Isn't this copyright BD ? > > Otherwise, > > Reviewed-by: Marek Vasut > > Best regards, > Marek Vasut > Maybe, but the following change doesn't seem worthy of a copyright linux-imx6/arch/arm/boot/dts$ diff -u imx6q-sabrelite.dts imx6dl-sabrelite.dts --- imx6q-sabrelite.dts 2013-12-12 11:22:10.156010652 -0700 +++ imx6dl-sabrelite.dts 2013-12-12 11:22:10.156010652 -0700 @@ -11,14 +11,10 @@ */ /dts-v1/; -#include "imx6q.dtsi" +#include "imx6dl.dtsi" #include "imx6qdl-sabrelite.dtsi" / { - model = "Freescale i.MX6 Quad SABRE Lite Board"; - compatible = "fsl,imx6q-sabrelite", "fsl,imx6q"; -}; - -&sata { - status = "okay"; + model = "Freescale i.MX6 DualLite SABRE Lite Board"; + compatible = "fsl,imx6dl-sabrelite", "fsl,imx6dl"; };