From patchwork Wed Mar 12 16:08:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grygorii Strashko X-Patchwork-Id: 3818551 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D1F759F1CD for ; Wed, 12 Mar 2014 15:22:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 74D5F201F0 for ; Wed, 12 Mar 2014 15:22:10 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7181B201ED for ; Wed, 12 Mar 2014 15:22:08 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WNkyb-0003dX-O2; Wed, 12 Mar 2014 15:21:50 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WNkti-0006jZ-ES; Wed, 12 Mar 2014 15:16:46 +0000 Received: from comal.ext.ti.com ([198.47.26.152]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WNkte-0006i5-Gj for linux-arm-kernel@lists.infradead.org; Wed, 12 Mar 2014 15:16:44 +0000 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id s2CFFciv021685; Wed, 12 Mar 2014 10:15:38 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2CFFbD2020652; Wed, 12 Mar 2014 10:15:37 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Wed, 12 Mar 2014 10:15:37 -0500 Received: from [192.168.192.116] (dlep20.itg.ti.com [157.170.170.23]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2CFFUPw005867; Wed, 12 Mar 2014 10:15:31 -0500 Message-ID: <53208693.0@ti.com> Date: Wed, 12 Mar 2014 18:08:51 +0200 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Russell King - ARM Linux Subject: Re: [PATCHv4 2/2] arm: Get rid of meminfo References: <1392761733-32628-1-git-send-email-lauraa@codeaurora.org> <1392761733-32628-3-git-send-email-lauraa@codeaurora.org> <20140312085401.GB21483@n2100.arm.linux.org.uk> <53205CA1.1090502@ti.com> <20140312133806.GH21483@n2100.arm.linux.org.uk> In-Reply-To: <20140312133806.GH21483@n2100.arm.linux.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140312_111642_779245_127CCA5D X-CRM114-Status: GOOD ( 28.00 ) X-Spam-Score: -6.9 (------) Cc: Nicolas Pitre , Andrew Lunn , Catalin Marinas , Will Deacon , Grant Likely , linux-mm@kvack.org, Daniel Walker , Marek Szyprowski , Kukjin Kim , David Brown , Sebastian Hesselbarth , Laura Abbott , Jason Cooper , linux-arm-msm@vger.kernel.org, Haojian Zhuang , Leif Lindholm , Ben Dooks , linux-arm-kernel@lists.infradead.org, Courtney Cavin , Eric Miao , Ard Biesheuvel , linux-kernel@vger.kernel.org, Santosh Shilimkar , Andrew Morton X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 03/12/2014 03:38 PM, Russell King - ARM Linux wrote: > On Wed, Mar 12, 2014 at 03:09:53PM +0200, Grygorii Strashko wrote: >> Hi Russell, >> >> On 03/12/2014 10:54 AM, Russell King - ARM Linux wrote: >>> On Tue, Feb 18, 2014 at 02:15:33PM -0800, Laura Abbott wrote: >>>> memblock is now fully integrated into the kernel and is the prefered >>>> method for tracking memory. Rather than reinvent the wheel with >>>> meminfo, migrate to using memblock directly instead of meminfo as >>>> an intermediate. >>>> >>>> Acked-by: Jason Cooper >>>> Acked-by: Catalin Marinas >>>> Acked-by: Santosh Shilimkar >>>> Acked-by: Kukjin Kim >>>> Tested-by: Marek Szyprowski >>>> Tested-by: Leif Lindholm >>>> Signed-off-by: Laura Abbott >>> >>> Laura, >>> >>> This patch causes a bunch of platforms to no longer boot - imx6solo with >>> 1GB of RAM boots, imx6q with 2GB of RAM doesn't. Versatile Express doesn't. >>> >>> The early printk messages don't reveal anything too interesting: >>> >>> Booting Linux on physical CPU 0x0 >>> Linux version 3.14.0-rc6+ (rmk@rmk-PC.arm.linux.org.uk) (gcc version 4.6.4 (GCC) ) #630 SMP Wed Mar 12 01:13:36 GMT 2014 >>> CPU: ARMv7 Processor [412fc09a] revision 10 (ARMv7), cr=10c53c7d >>> CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache >>> Machine model: SolidRun Cubox-i Dual/Quad >>> cma: CMA: reserved 64 MiB at 8c000000 >>> Memory policy: Data cache writealloc >>> >>> >>> vs. >>> >>> Booting Linux on physical CPU 0x0 >>> Linux version 3.14.0-rc6+ (rmk@rmk-PC.arm.linux.org.uk) (gcc version 4.6.4 (GCC) ) #631 SMP Wed Mar 12 01:15:37 GMT 2014 >>> CPU: ARMv7 Processor [412fc09a] revision 10 (ARMv7), cr=10c53c7d >>> CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache >>> Machine model: SolidRun Cubox-i Dual/Quad >>> cma: CMA: reserved 64 MiB at 3b800000 >>> Memory policy: Data cache writealloc >>> On node 0 totalpages: 524288 >>> free_area_init_node: node 0, pgdat c09d0240, node_mem_map ea7d8000 >>> Normal zone: 1520 pages used for memmap >>> Normal zone: 0 pages reserved >>> Normal zone: 194560 pages, LIFO batch:31 >>> HighMem zone: 2576 pages used for memmap >>> HighMem zone: 329728 pages, LIFO batch:31 >>> ... >>> >>> The only obvious difference is the address of that CMA reservation, >>> CMA shouldn't make a difference here - but I suspect that other >>> allocations which need to be in lowmem probably aren't. >>> >> >> Could it be possible to enable memblock debug by adding "memblock=debug" >> in cmdline? > > Here's with Laura's patch: > > Uncompressing Linux... done, booting the kernel. > Booting Linux on physical CPU 0x0 > Linux version 3.14.0-rc6+ (rmk@rmk-PC.arm.linux.org.uk) (gcc version 4.6.4 (GCC) ) #633 SMP Wed Mar 12 12:56:15 GMT 2014 > CPU: ARMv7 Processor [412fc09a] revision 10 (ARMv7), cr=10c53c7d > CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache > Machine model: SolidRun Cubox-i Dual/Quad > memblock_reserve: [0x00000010008240-0x0000001112c1f7] flags 0x0 arm_memblock_init+0x28/0x1a8 > memblock_reserve: [0x00000020000040-0x000000201caa57] flags 0x0 arm_memblock_init+0x108/0x1a8 > memblock_reserve: [0x00000010004000-0x00000010007fff] flags 0x0 arm_mm_memblock_reserve+0x1c/0x24 > memblock_reserve: [0x00000018000000-0x0000001800b07f] flags 0x0 arm_dt_memblock_reserve+0x2c/0x70 > memblock_reserve: [0x00000018000000-0x0000001800afff] flags 0x0 arm_dt_memblock_reserve+0x68/0x70 > memblock_reserve: [0x00000020000040-0x000000201caa57] flags 0x0 arm_dt_memblock_reserve+0x68/0x70 > memblock_reserve: [0x0000008c000000-0x0000008fffffff] flags 0x0 memblock_alloc_base_nid+0x40/0x54 > cma: CMA: reserved 64 MiB at 8c000000 > MEMBLOCK configuration: > memory size = 0x80000000 reserved size = 0x52fda50 > memory.cnt = 0x1 > memory[0x0] [0x00000010000000-0x0000008fffffff], 0x80000000 bytes flags: 0x06 > reserved.cnt = 0x5 > reserved[0x0] [0x00000010004000-0x00000010007fff], 0x4000 bytes flags: 0x0 > reserved[0x1] [0x00000010008240-0x0000001112c1f7], 0x1123fb8 bytes flags: 0x0 > reserved[0x2] [0x00000018000000-0x0000001800b07f], 0xb080 bytes flags: 0x0 > reserved[0x3] [0x00000020000040-0x000000201caa57], 0x1caa18 bytes flags: 0x0 > reserved[0x4] [0x0000008c000000-0x0000008fffffff], 0x4000000 bytes flags: 0x0 > Memory policy: Data cache writealloc > memblock_reserve: [0x0000008bffffd8-0x0000008bffffff] flags 0x0 memblock_alloc_base_nid+0x40/0x54 > > Here's without: > > Booting Linux on physical CPU 0x0 > Linux version 3.14.0-rc6+ (rmk@rmk-PC.arm.linux.org.uk) (gcc version 4.6.4 (GCC) ) #635 SMP Wed Mar 12 13:22:15 GMT 2014 > CPU: ARMv7 Processor [412fc09a] revision 10 (ARMv7), cr=10c53c7d > CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache > Machine model: SolidRun Cubox-i Dual/Quad > memblock_reserve: [0x00000010008240-0x0000001112c277] flags 0x0 arm_memblock_init+0x54/0x1d4 > memblock_reserve: [0x00000020000040-0x000000201caa57] flags 0x0 arm_memblock_init+0x134/0x1d4 > memblock_reserve: [0x00000010004000-0x00000010007fff] flags 0x0 arm_mm_memblock_reserve+0x1c/0x24 > memblock_reserve: [0x00000018000000-0x0000001800b07f] flags 0x0 arm_dt_memblock_reserve+0x2c/0x70 > memblock_reserve: [0x00000018000000-0x0000001800afff] flags 0x0 arm_dt_memblock_reserve+0x68/0x70 > memblock_reserve: [0x00000020000040-0x000000201caa57] flags 0x0 arm_dt_memblock_reserve+0x68/0x70 > memblock_reserve: [0x0000003b800000-0x0000003f7fffff] flags 0x0 memblock_alloc_base_nid+0x40/0x54 > cma: CMA: reserved 64 MiB at 3b800000 > MEMBLOCK configuration: > memory size = 0x80000000 reserved size = 0x52fdad0 > memory.cnt = 0x1 > memory[0x0] [0x00000010000000-0x0000008fffffff], 0x80000000 bytes flags: 0x0 > reserved.cnt = 0x5 > reserved[0x0] [0x00000010004000-0x00000010007fff], 0x4000 bytes flags: 0x0 > reserved[0x1] [0x00000010008240-0x0000001112c277], 0x1124038 bytes flags: 0x0 > reserved[0x2] [0x00000018000000-0x0000001800b07f], 0xb080 bytes flags: 0x0 > reserved[0x3] [0x00000020000040-0x000000201caa57], 0x1caa18 bytes flags: 0x0 > reserved[0x4] [0x0000003b800000-0x0000003f7fffff], 0x4000000 bytes flags: 0x0 > Memory policy: Data cache writealloc > memblock_reserve: [0x0000003b7fffd8-0x0000003b7fffff] flags 0x0 memblock_alloc_base_nid+0x40/0x54 > memblock_reserve: [0x0000003b7fe000-0x0000003b7fefff] flags 0x0 memblock_alloc_base_nid+0x40/0x54 > memblock_reserve: [0x0000003b7fd000-0x0000003b7fdfff] flags 0x0 memblock_alloc_base_nid+0x40/0x54 > memblock_reserve: [0x0000003b7fc000-0x0000003b7fcfff] flags 0x0 memblock_alloc_base_nid+0x40/0x54 > ... > > So it looks like allocations which must come from lowmem aren't being > limited to lowmem. > > Try booting a machine with 2G of RAM with page offset set to 3GB and > highmem enabled - it will fail as per the above. > > In fact, if we look at sanity_check_meminfo() post that patch, it's > clearly wrong: > > for_each_memblock(memory, reg) { > phys_addr_t block_start = reg->base; > phys_addr_t block_end = reg->base + reg->size; > phys_addr_t size_limit = reg->size; > > if (reg->base >= vmalloc_limit) > highmem = 1; > else > size_limit = vmalloc_limit - reg->base; > ... > if (!highmem) { > if (block_end > arm_lowmem_limit) > arm_lowmem_limit = block_end; In v3, above was arm_lowmem_limit = reg->base + size_limit; so, it has worked somehow, even arm_lowmem_limit can point on non existed address. It was changed because of my comment - sorry. I think, it should be smth like: if (!highmem) { if (block_end > arm_lowmem_limit) if (reg->size > size_limit) arm_lowmem_limit = vmalloc_limit; else arm_lowmem_limit = block_end; I've created and attached the patch which allows me to boot on keystone. > ... > } regards, -grygorii From 3a210330f15c4cfc6728d83b28750c696d9eaefb Mon Sep 17 00:00:00 2001 From: Grygorii Strashko Date: Wed, 12 Mar 2014 18:04:02 +0200 Subject: [PATCH] arm: get rid of meminfo: fix lowmem_limit calculation Signed-off-by: Grygorii Strashko --- arch/arm/mm/mmu.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index c3ae96c..f8b5175 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -1096,8 +1096,12 @@ void __init sanity_check_meminfo(void) } if (!highmem) { - if (block_end > arm_lowmem_limit) - arm_lowmem_limit = block_end; + if (block_end > arm_lowmem_limit) { + if (reg->size > size_limit) + arm_lowmem_limit = vmalloc_limit; + else + arm_lowmem_limit = block_end; + } /* @@ -1117,7 +1121,7 @@ void __init sanity_check_meminfo(void) if (!IS_ALIGNED(block_start, SECTION_SIZE)) memblock_limit = block_start; else if (!IS_ALIGNED(block_end, SECTION_SIZE)) - memblock_limit = block_end; + memblock_limit = arm_lowmem_limit; } }