From patchwork Tue Mar 18 15:01:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grygorii Strashko X-Patchwork-Id: 3848251 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 063199F369 for ; Tue, 18 Mar 2014 14:09:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 21D7C20220 for ; Tue, 18 Mar 2014 14:09:35 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0CA720256 for ; Tue, 18 Mar 2014 14:09:33 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WPuhs-0007h2-Sz; Tue, 18 Mar 2014 14:09:29 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WPuhq-0003b6-G4; Tue, 18 Mar 2014 14:09:26 +0000 Received: from devils.ext.ti.com ([198.47.26.153]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WPuhk-0003aU-Np for linux-arm-kernel@lists.infradead.org; Tue, 18 Mar 2014 14:09:24 +0000 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s2IE8v2A031501; Tue, 18 Mar 2014 09:08:57 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2IE8vQN021172; Tue, 18 Mar 2014 09:08:57 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Tue, 18 Mar 2014 09:08:56 -0500 Received: from [192.168.192.173] (dlep20.itg.ti.com [157.170.170.23]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s2IE8sL1015940; Tue, 18 Mar 2014 09:08:54 -0500 Message-ID: <53285FE7.5010203@ti.com> Date: Tue, 18 Mar 2014 17:01:59 +0200 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: linux-arm , Tejun Heo , Christoph Lameter , Andrew Morton , , Santosh Shilimkar , Ingo Molnar Subject: [linux-next][regression] [PATCH] percpu: add preemption checks to __this_cpu ops X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140318_100920_866189_9EBEE263 X-CRM114-Status: UNSURE ( 8.33 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -6.9 (------) Cc: Grygorii.Strashko@ti.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi All, The regression is observed in the current linux-next on ARM Keystone 2 SoC: - system is booted till console and in a second or two and then stall, no messages displayed (CONFIG_DEBUG_PREEMPT=y). The cause of regression has been bisected to the commit: commit 589a606f9539663f162e4a110d117527833b58a4 Author: Christoph Lameter Date: Mon Mar 17 11:27:41 2014 +1100 percpu: add preemption checks to __this_cpu ops We define a check function in order to avoid trouble with the include files. Then the higher level __this_cpu macros are modified to invoke the preemption check. Signed-off-by: Christoph Lameter Acked-by: Ingo Molnar Cc: Tejun Heo Signed-off-by: Andrew Morton [=== 1 ===] If above patch is reverted - system can boot again. [=== 2 ===] If I apply below change - system can boot again. linux-next top commits: 3bd688c Add linux-next specific files for 20140318 9a63a74 Merge branch 'akpm/master' ccdf335 mm: add strictlimit knob 589a606 percpu: add preemption checks to __this_cpu ops cdbd87c net: replace __this_cpu_inc in route.c with raw_cpu_inc 049fcfe modules: use raw_cpu_write for initialization of per cpu refcount. b46b094 mm: use raw_cpu ops for determining current NUMA node d934df8 percpu: add raw_cpu_ops c4a8790 arm: move arm_dma_limit to setup_dma_zone Regards, -grygorii diff --git a/lib/smp_processor_id.c b/lib/smp_processor_id.c index a270dce..73a2004 100644 --- a/lib/smp_processor_id.c +++ b/lib/smp_processor_id.c @@ -58,9 +58,6 @@ EXPORT_SYMBOL(debug_smp_processor_id); notrace void __this_cpu_preempt_check(const char *op) { - char text[40]; - - snprintf(text, sizeof(text), "__this_cpu_%s()", op); - check_preemption_disabled(text); + check_preemption_disabled(op); } EXPORT_SYMBOL(__this_cpu_preempt_check);