From patchwork Thu May 8 17:12:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Paton X-Patchwork-Id: 4137911 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 67CEFBFF02 for ; Thu, 8 May 2014 17:22:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8BA8C2026D for ; Thu, 8 May 2014 17:22:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3CD120265 for ; Thu, 8 May 2014 17:22:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WiS0F-0005h0-Nb; Thu, 08 May 2014 17:21:03 +0000 Received: from mail-we0-x231.google.com ([2a00:1450:400c:c03::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WiS0D-0005Ys-Jb for linux-arm-kernel@lists.infradead.org; Thu, 08 May 2014 17:21:02 +0000 Received: by mail-we0-f177.google.com with SMTP id x48so2783092wes.22 for ; Thu, 08 May 2014 10:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=NXpstdikPJ8ELGhl2eo+/SuRTAkjHVrmozdbWUkIolo=; b=UBNBjE1T6m0Lr/pDAJt8JEYOkQkU36Wf7kuSPOkXbhDBphvM+5bKqomMf+WZf3UTz1 3SZz34kDJwvmwIWpsLlzBohT2RQc7rVkCnmp65cZKV95c3QZVc0hV9fT1CHqwag2xD+m NU2qV65o4GLAE3UXcnqHHpfyRpAnq/en28yr+5/WUJLCFLEaiXX24Tt/5wnegTM125Gd zJxgJamsEuRx12z7FoLcz8ECtOvlpIFVofgVvEnj+1HgU6kmreGNeD/aF+73j42DzL73 7e2lEWPm0Cgz4OJDHElZ18vLKojMxhp6X6DlyOJZvqdWTuDaw0f4S5+Li2umX0ti8YJG LrfQ== X-Received: by 10.180.8.66 with SMTP id p2mr13913595wia.37.1399569154546; Thu, 08 May 2014 10:12:34 -0700 (PDT) Received: from [172.20.0.44] (hades.darkvoyage.org.uk. [81.187.177.1]) by mx.google.com with ESMTPSA id be3sm2024786wjc.5.2014.05.08.10.12.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 08 May 2014 10:12:33 -0700 (PDT) Message-ID: <536BBAE2.7060203@gmail.com> Date: Thu, 08 May 2014 18:12:02 +0100 From: Iain Paton User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Alexander Shiyan Subject: Re: [PATCH v2] ARM: dts: imx6: add new board RIoTboard References: <53695C34.5000604@gmail.com> <536B9654.7020509@gmail.com> <1399560632.547109991@f294.i.mail.ru> In-Reply-To: <1399560632.547109991@f294.i.mail.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140508_102101_791998_FB4FBC89 X-CRM114-Status: GOOD ( 14.78 ) X-Spam-Score: 0.1 (/) Cc: Fabio Estevam , Fabio Estevam , Shawn Guo , =?UTF-8?B?RXJpYyBCw6luYXI=?= =?UTF-8?B?ZA==?= , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 08/05/14 15:50, Alexander Shiyan wrote: > I think you should make patch series: > 1. Add missing clock into imx6dl.dtsi > 2. Add label to AIPS2 to imx6qdl.dtsi and use this label in imx6dl.dtsi > 3. This patch I'm not sure I follow 1/2. You mean something like this then the riotboard patch with clock-frequency lines dropped from all i2c sections and clocks line dropped from i2c4? Ok, I can see how that works, if it's acceptable to everyone I'll post the series shortly. Thanks, Iain diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index eca0971..0645069 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -767,7 +767,7 @@ }; }; - aips-bus@02100000 { /* AIPS2 */ + aips2: aips-bus@02100000 { /* AIPS2 */ compatible = "fsl,aips-bus", "simple-bus"; #address-cells = <1>; #size-cells = <1>; followed by diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 5c5f574..81b7501 100644 --- a/arch/arm/boot/dts/imx6dl.dtsi +++ b/arch/arm/boot/dts/imx6dl.dtsi @@ -80,16 +80,6 @@ }; }; - aips2: aips-bus@02100000 { - i2c4: i2c@021f8000 { - #address-cells = <1>; - #size-cells = <0>; - compatible = "fsl,imx1-i2c"; - reg = <0x021f8000 0x4000>; - interrupts = <0 35 IRQ_TYPE_LEVEL_HIGH>; - status = "disabled"; - }; - }; }; display-subsystem { @@ -98,6 +88,18 @@ }; }; +&aips2 { + i2c4: i2c@021f8000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "fsl,imx1-i2c"; + reg = <0x021f8000 0x4000>; + interrupts = <0 35 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clks 116>; + status = "disabled"; + }; +}; + &hdmi { compatible = "fsl,imx6dl-hdmi"; };