From patchwork Fri Jun 13 14:59:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Figa X-Patchwork-Id: 4349521 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E8F0F9F314 for ; Fri, 13 Jun 2014 15:03:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D21D42021F for ; Fri, 13 Jun 2014 15:03:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADFE720211 for ; Fri, 13 Jun 2014 15:03:06 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WvSy7-0000lK-1v; Fri, 13 Jun 2014 15:00:39 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WvSy3-0000i7-Un for linux-arm-kernel@lists.infradead.org; Fri, 13 Jun 2014 15:00:37 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N7400GA24C8W2C0@mailout1.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 13 Jun 2014 16:00:08 +0100 (BST) X-AuditID: cbfec7f5-b7f626d000004b39-d5-539b11fb1863 Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 96.DA.19257.BF11B935; Fri, 13 Jun 2014 16:00:11 +0100 (BST) Received: from [106.116.147.199] by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N74002M74CAFV10@eusync1.samsung.com>; Fri, 13 Jun 2014 16:00:11 +0100 (BST) Message-id: <539B11EB.6010304@samsung.com> Date: Fri, 13 Jun 2014 16:59:55 +0200 From: Tomasz Figa Organization: Samsung R&D Institute Poland User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Daniel Drake Subject: Re: [PATCH 0/5] Handle non-secure L2C initialization on Exynos4 References: In-reply-to: Content-type: multipart/mixed; boundary=------------000206000902070303060701 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t/xy7q/BWcHG8ydL2HxaP5jZov+aR2s Fr0LrrJZbO+cwW4x5c9yJotNj6+xWlzeNYfNYvaSfhaL25d5LV73rWG2WLXrD6PF/iteDjwe Lc09bB7fvk5i8bjc18vkseh7lsfOWXfZPe5c28PmsXlJvUffllWMHnevv2TyOH5jO5PH501y AdxRXDYpqTmZZalF+nYJXBl7F71hLnhnX9F1s5GxgXGuaRcjJ4eEgIlE77EmVghbTOLCvfVs XYxcHEICSxklWrsOQTmfGSU2Tb3I1MXIwcEroCUxYVYFSAOLgKrEuQ1/GUFsNgE1ic8Nj9hA bH6gkjVN11lAykUFIiQeXxACCfMKCEr8mHyPBcQWAWr9tbyZFWQ8s8B0ZolpN28xgySEBTwk vn4/AnaQkECAxPO/N8FmcgoES3yZMB3MZhbwkdi38TnLBEaBWUjmzkKSgrB1JN71PWCGsOUl tr+dA2RzANkpEocabVGFQc5oYJTYs28rVG+KxK37FxmxKrp/+jYrRCJW4vqZy2gWgNgZEn33 57AvYORdxSiaWppcUJyUnmukV5yYW1yal66XnJ+7iRGSPL7uYFx6zOoQowAHoxIP78uSWcFC rIllxZW5hxhVgOY82rD6AqMUS15+XqqSCO+9BqA0b0piZVVqUX58UWlOavEhRiYOTqkGRqGv L8/Js5SldjzU+awgpfNVYvfUzYfa458/e5biJXPHZUd9anyLa2l6pc8bo2/L9yQf2lCqricV 8vPZzMnyJVu2ajBUf9qjrf4/Y4vcwvAMyxOhynsW5bNe43r75ubRkJ+/55s4qdqqfLZYrTzT mzPr/eXnrum5K8VWVivJifM+jpNxzm/bpcRSnJFoqMVcVJwIAIvmbLEIAwAA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140613_080036_156336_B4F65DB1 X-CRM114-Status: GOOD ( 23.61 ) X-Spam-Score: -5.7 (-----) Cc: Kukjin Kim , Laura Abbott , Tony Lindgren , Linus Walleij , linux-kernel@vger.kernel.org, Tomasz Figa , Santosh Shilimkar , Robin Holt , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Daniel, I have attached, three patches which make the kernel boot fine with L2 cache enabled on ODROID-U3. Could you test them on your setup to verify that they indeed fix the issue? Best regards, Tomasz On 12.06.2014 15:38, Daniel Drake wrote: > Hi Tomasz, > > Thanks for working on this! > > I have just tried this, against Linus master > 64b2d1fbbfda07765dae3f601862796a61b2c451. > Added patch "ARM: dts: Initial ODROID U2 support" and booted on > ODROID-U2. I believe this board has the security enabled. > > Unfortunately, it hangs during early boot. With earlyprintk the last > messages seen are: > > L2C: platform modifies aux control register: 0x02070000 -> 0x3e470001 > L2C: platform provided aux values permit register corruption. > L2C: DT/platform modifies aux control register: 0x02070000 -> 0x3e470001 > L2C-310 enabling early BRESP for Cortex-A9 > L2C-310: enabling full line of zeros but not enabled in Cortex-A9 > L2C-310 ID prefetch enabled, offset 1 lines > L2C-310 dynamic clock gating enabled, standby mode enabled > L2C-310 cache controller enabled, 16 ways, 1024 kB > L2C-310: CACHE_ID 0x4100c4c8, AUX_CTRL 0x7e470001 > > I then tried to go back to the earlier patch "ARM: EXYNOS: Add secure > firmware support for l2x0 init" (attached, needed a rebase) but that > one also now hangs at: > > L2C: platform modifies aux control register: 0x02070000 -> 0x3e470001 > > It did work on 3.14 though. Looking at the changelogs, many changes > have been made to l2x0 recently. Can you confirm that you have tested > your patches against a kernel with all of Russell King's recent > changes? > > Thanks > Daniel > From 032125d7f099d9160ad98371313a829131ebed8c Mon Sep 17 00:00:00 2001 From: Tomasz Figa Date: Fri, 13 Jun 2014 16:49:09 +0200 Subject: [PATCH 3/3] ARM: dts: exynos4x12: Override prefetch settings. Signed-off-by: Tomasz Figa --- arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi index 9487f9c..ddffefe 100644 --- a/arch/arm/boot/dts/exynos4x12.dtsi +++ b/arch/arm/boot/dts/exynos4x12.dtsi @@ -67,6 +67,11 @@ cache-level = <2>; arm,tag-latency = <2 2 1>; arm,data-latency = <3 2 1>; + arm,double-linefill = <1>; + arm,double-linefill-incr = <0>; + arm,double-linefill-wrap = <1>; + arm,prefetch-drop = <1>; + arm,prefetch-offset = <7>; }; clock: clock-controller@10030000 { -- 1.9.3