From patchwork Fri Jul 4 09:18:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chanwoo Choi X-Patchwork-Id: 4479071 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 55A509F26C for ; Fri, 4 Jul 2014 09:20:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7C9F32024C for ; Fri, 4 Jul 2014 09:20:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A990C20225 for ; Fri, 4 Jul 2014 09:20:41 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X2zdh-00068V-G8; Fri, 04 Jul 2014 09:18:41 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X2zdf-00065b-H3 for linux-arm-kernel@lists.infradead.org; Fri, 04 Jul 2014 09:18:40 +0000 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N86002SKKIE2900@mailout3.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 04 Jul 2014 18:18:14 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.113]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 15.1E.24374.65176B35; Fri, 04 Jul 2014 18:18:14 +0900 (KST) X-AuditID: cbfee68d-b7fd46d000005f36-99-53b67156729f Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 1C.89.05196.65176B35; Fri, 04 Jul 2014 18:18:14 +0900 (KST) Received: from [10.252.81.195] by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N8600BHOKIDQZA0@mmp1.samsung.com>; Fri, 04 Jul 2014 18:18:14 +0900 (KST) Message-id: <53B67156.2020702@samsung.com> Date: Fri, 04 Jul 2014 18:18:14 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Tomasz Figa Subject: Re: [PATCH] ARM: dts: Add I2S dt node for Exynos3250 References: <1404373939-10510-1-git-send-email-cw00.choi@samsung.com> <53B66066.4030202@gmail.com> In-reply-to: <53B66066.4030202@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRmVeSWpSXmKPExsWyRsSkUDescFuwQd98EYtdf+8zWvQuuMpm cbbpDbvFpsfXWC0u75rDZjHj/D4mi9uXeS3Wz3jNYrFq1x9GB06PluYeNo+ds+6ye2xeUu/R t2UVo8fnTXIBrFFcNimpOZllqUX6dglcGW+a5jIV/BWqODrrE1MD41z+LkZODgkBE4lnW9ay QNhiEhfurWfrYuTiEBJYyigx4XILaxcjB1jR4zZhiPgiRoknjZ2MEM5rRolJC5ayg3TzCmhJ /L40nwnEZhFQlehofgkWZwOK739xgw3EFhUIk1g5/QoLRL2gxI/J98BsEQF1iW9T+tlBhjIL PGWU2NQykREkISxgK9F1rAGsSEggRaL//CewOKeApkT3sSVgQ5kFdCT2t06DsuUlNq95ywwy SELgFrvEjZ/fWCAuEpD4NvkQC8Q7shKbDjBDvCwpcXDFDZYJjGKzkNw0C8nYWUjGLmBkXsUo mlqQXFCclF5kqFecmFtcmpeul5yfu4kRGImn/z3r3cF4+4D1IcZkoJUTmaVEk/OBkZxXEm9o bGZkYWpiamxkbmlGmrCSOG/Sw6QgIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYyZ6R61q5me xq3yqniklKp85HRWfGIs139FDt7AK6t26Io+XKCTIcEy7+GJ29mTkjV/Z09tUj7cNm3GleOa J9SCO6XWvJrwa/Nz33tx4UwypZmT3BfN/azqzf84lWPSPz8JB5MJYp5XbIqa9h4+n/vz7tlO 4yueNjMmB1jfDi47azm7ZnPDvClKLMUZiYZazEXFiQBex3BZ2gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsVy+t9jAd2wwm3BBl9n81js+nuf0aJ3wVU2 i7NNb9gtNj2+xmpxedccNosZ5/cxWdy+zGuxfsZrFotVu/4wOnB6tDT3sHnsnHWX3WPzknqP vi2rGD0+b5ILYI1qYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy 8QnQdcvMAbpHSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5jxpmkuU8Ff oYqjsz4xNTDO5e9i5OCQEDCReNwm3MXICWSKSVy4t56ti5GLQ0hgEaPEk8ZORgjnNaPEpAVL 2UGqeAW0JH5fms8EYrMIqEp0NL8Ei7MBxfe/uMEGYosKhEmsnH6FBaJeUOLH5HtgtoiAusS3 Kf3sIEOZBZ4ySmxqmcgIkhAWsJXoOtYAViQkkCLRf/4TWJxTQFOi+9gSsKHMAjoS+1unQdny EpvXvGWewCgwC8mOWUjKZiEpW8DIvIpRNLUguaA4KT3XSK84Mbe4NC9dLzk/dxMjOM6fSe9g XNVgcYhRgINRiYfXo2hrsBBrYllxZe4hRgkOZiUR3uSUbcFCvCmJlVWpRfnxRaU5qcWHGE2B QTCRWUo0OR+YgvJK4g2NTcyMLI3MDS2MjM2VxHkPtloHCgmkJ5akZqemFqQWwfQxcXBKNTCq m54+sPeEwKGInZnf2c2FlrAu81pufeTEL8G+xsDSovunXdlLbj2y6Ddtl/2d0fNu+1y7145Z ItUbXbR7inns5k8zLAm7uuBf/p3YpacUVhZNvPO/bX9M73r7/+WbN0VIpv3mWcCotWd6YskS trBeXuWU3sLG31dV/rW1Mj82dWCZ0cpz744SS3FGoqEWc1FxIgDicitVCQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140704_021839_741481_3D5D52B0 X-CRM114-Status: GOOD ( 12.61 ) X-Spam-Score: -5.0 (-----) Cc: kgene.kim@samsung.com, linux@arm.linux.org.uk, t.figa@samsung.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ideal.song@samsung.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Dear Kukjin and Tomasz, On 07/04/2014 05:05 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 03.07.2014 09:52, Chanwoo Choi wrote: >> From: Tomasz Figa >> >> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo >> (1 channels) IIS-bus for audio interface with DMA-based operation. >> >> Signed-off-by: Tomasz Figa >> Signed-off-by: Inha Song >> Tested-by: Inha Song >> Signed-off-by: Chanwoo Choi >> Acked-by: Kyungmin Park >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index 1f8384f..e9017ef 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -644,6 +644,19 @@ >> status = "disabled"; >> }; >> >> + i2s: i2s@13970000 { > > Shouldn't the label be rather called "i2s2" as the pinctrl entry below > suggests? > >> + compatible = "samsung,s3c6410-i2s"; >> + reg = <0x13970000 0x100>; >> + interrupts = <0 126 0>; >> + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; >> + clock-names = "iis", "i2s_opclk0"; >> + dmas = <&pdma0 14>, <&pdma0 13>; >> + dma-names = "tx", "rx"; >> + pinctrl-0 = <&i2s2_bus>; >> + pinctrl-name = "default"; > > "pinctrl-name" is not a valid property. I suppose it should be > "pinctrl-names". I modify this patch as following. If you confirm following patch, I'll re-send patchset(v2). diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 3e678fa..77a06df 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -425,6 +425,19 @@ status = "disabled"; }; + i2s2: i2s@13970000 { + compatible = "samsung,s3c6410-i2s"; + reg = <0x13970000 0x100>; + interrupts = <0 126 0>; + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; + clock-names = "iis", "i2s_opclk0"; + dmas = <&pdma0 14>, <&pdma0 13>; + dma-names = "tx", "rx"; + pinctrl-0 = <&i2s2_bus>; + pinctrl-names = "default"; + status = "disabled"; + }; + pwm: pwm@139D0000 { compatible = "samsung,exynos4210-pwm"; reg = <0x139D0000 0x1000>;