From patchwork Wed Oct 8 15:04:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 5054101 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BC02C9F30B for ; Wed, 8 Oct 2014 15:07:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F2C25201ED for ; Wed, 8 Oct 2014 15:07:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77992200FE for ; Wed, 8 Oct 2014 15:07:24 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xbsnz-0000Hh-00; Wed, 08 Oct 2014 15:05:31 +0000 Received: from mail-wi0-f173.google.com ([209.85.212.173]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xbsnu-0007p3-OA for linux-arm-kernel@lists.infradead.org; Wed, 08 Oct 2014 15:05:27 +0000 Received: by mail-wi0-f173.google.com with SMTP id fb4so10841901wid.0 for ; Wed, 08 Oct 2014 08:05:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=e2cBrm81sbZaw1jymmT6S03tIh1kiM3VI+y/IUln9L8=; b=mIqFH7jNXnDKJ7CUsArQfEEsC3glGyqYYy8u/fsvOx6Yol5gUG66JaDCe4tFe0995e lm/82NImgxHGoowDYzrQ2u6OXx/u7JXk1B/zyYy1fsd10VW6vm6DNCuDo+0helYpe4oU dQk5nvHqeX5gFy8qGSlbDHfMcdd72LaEfRkfsWbkdLKn2bBRuTv1W9jq1fXh+rLCP+53 aORtWnudTt+ibTIPgEXcvabfoGpbMefuRF3yBJHOX7BrEHlmY7e4gD5CAL/3YOQq0NjL Ut5UQFUnOzGsl2aovh4LCCqlCiSo7GlE29+VsJYg4wOi1onMyaCxOJ60G2sWdnFBTElH 0xUQ== X-Gm-Message-State: ALoCoQmy0B+jkHjIWecxz8tLvgFnpPRpPUdExIw1/95sp0ildLkfs1Ak9wadjidUyFmutsI0MQLk X-Received: by 10.194.48.81 with SMTP id j17mr2280513wjn.128.1412780702947; Wed, 08 Oct 2014 08:05:02 -0700 (PDT) Received: from [192.168.1.7] (host-78-149-2-97.as13285.net. [78.149.2.97]) by mx.google.com with ESMTPSA id os4sm346318wjc.48.2014.10.08.08.04.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Oct 2014 08:05:01 -0700 (PDT) Message-ID: <54355299.4000501@linaro.org> Date: Wed, 08 Oct 2014 16:04:57 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Stephen Boyd Subject: Re: [PATCH v2 04/15] clk: divider: Make generic for usage elsewhere References: <1409957256-23729-1-git-send-email-sboyd@codeaurora.org> <1409957256-23729-5-git-send-email-sboyd@codeaurora.org> <542EE5FE.9080806@codeaurora.org> <54342287.7020005@linaro.org> <54343038.2060007@codeaurora.org> In-Reply-To: <54343038.2060007@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141008_080526_929329_A40CF9C6 X-CRM114-Status: GOOD ( 11.54 ) X-Spam-Score: -0.7 (/) Cc: Mike Turquette , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Viresh Kumar , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 07/10/14 19:26, Stephen Boyd wrote: > On 10/07/2014 10:27 AM, Srinivas Kandagatla wrote: >> Hi Stephen, >> >> Just noticed this regression while testing the patch on Arndale board. >> >> https://bugs.linaro.org/show_bug.cgi?id=740 > > If you return value it works correctly right? > I think you are right, .. From last message from bugs.linaro.org: " That seems to be it! This change: - makes Arndale to boot; rootfs on mmc mounts OK. " thanks, srini --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -366,7 +366,7 @@ int divider_get_val(unsigned long rate, unsigned long parent min_t(unsigned int, value, div_mask(width)); - return 0; + return value; } EXPORT_SYMBOL_GPL(divider_get_val);