From patchwork Tue Dec 23 14:22:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Grygorii.Strashko@linaro.org" X-Patchwork-Id: 5533731 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 438BB9F326 for ; Tue, 23 Dec 2014 14:27:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3A23E2017D for ; Tue, 23 Dec 2014 14:27:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF43820165 for ; Tue, 23 Dec 2014 14:27:11 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y3QN0-0001OW-1W; Tue, 23 Dec 2014 14:23:30 +0000 Received: from mail-lb0-f178.google.com ([209.85.217.178]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y3QMv-0001M2-MY for linux-arm-kernel@lists.infradead.org; Tue, 23 Dec 2014 14:23:26 +0000 Received: by mail-lb0-f178.google.com with SMTP id f15so6030793lbj.37 for ; Tue, 23 Dec 2014 06:23:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=UkrTaMXYw1xgWn76R1lY5qFTFwqtl6FCpmRX/8fRWo4=; b=LCU2qcsm8flk6QzhuNcsQ4TtjTTNW85G4QeyUmJqd9Cxwk7dpFYb2oX82cegWJBzf7 CRYZMHO+ozG26OJ5urHIxVCRmGqiZZ1ayslpuuj8pS824i04hseuxn9cz8TZr7cKGlfW YVcAIkP78yk5QUpWJ2r7XaD/5X9E+yUEN9NJCf4xURyJiYSBGftoAKDiDAp2vtRb7hFE T4EEDS4YLlc59+rtXxSn4MCzL/68BiWk0oRgNMD98XsMu7vJ3G7xI0fNoFQ/s4QKkMWD RWhZ+Rkih6aI4j0WUG7CiV3WqcGtC8jW1u2efdV/wMfxaE5UN4uG/eOsXJhEyTivC88u Rnlg== X-Gm-Message-State: ALoCoQnIjIbWo7YnnzBuzzAMxzQyFAxKd/lud2NLgyHiwi6Qos4E1x04pNTyf/wDA1fWpXHReh0N X-Received: by 10.152.18.225 with SMTP id z1mr28263367lad.0.1419344582223; Tue, 23 Dec 2014 06:23:02 -0800 (PST) Received: from [172.22.39.20] ([195.238.92.128]) by mx.google.com with ESMTPSA id zo3sm5897148lbb.10.2014.12.23.06.23.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Dec 2014 06:23:01 -0800 (PST) From: "Grygorii.Strashko@linaro.org" X-Google-Original-From: "Grygorii.Strashko@linaro.org" Message-ID: <54997AC2.1040507@linaro.org> Date: Tue, 23 Dec 2014 16:22:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Murali Karicheri , =?windows-1252?Q?Uwe_Kleine?= =?windows-1252?Q?-K=F6nig?= , Kees Cook Subject: Re: kernel.org - master not booting on keystone (ARM v7 Cortex A15 SoC) EVMs References: <549490D6.3090804@ti.com> <20141219211816.GH10857@pengutronix.de> <5494B932.6060602@ti.com> <20141221102925.GJ10857@pengutronix.de> <54983304.3080302@ti.com> In-Reply-To: <54983304.3080302@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141223_062325_937605_033FB40D X-CRM114-Status: GOOD ( 17.07 ) X-Spam-Score: -0.7 (/) Cc: Tyler Baker , Laura Abbott , linux-arm-kernel , Nicolas Pitre X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 12/22/2014 05:04 PM, Murali Karicheri wrote: > On 12/21/2014 05:29 AM, Uwe Kleine-König wrote: >> Hello, >> >> I cannot say anything here, but maybe the people being involved in >> 1e6b48116a950 can. I added them to Cc and didn't trim the mail for them. > Uwe, > > Thanks for copying the commit owners. Looking forward for a response > from them. > > Murali >> >> Best regards >> Uwe >> >> On Fri, Dec 19, 2014 at 06:48:02PM -0500, Murali Karicheri wrote: >>> On 12/19/2014 04:25 PM, Tyler Baker wrote: >>>> Hello, >>>> >>>> On 19 December 2014 at 13:18, Uwe Kleine-König >>>> wrote: >>>>> Hello, >>>>> >>>>> On Fri, Dec 19, 2014 at 03:55:50PM -0500, Murali Karicheri wrote: >>>>>> I have pulled the latest master from >>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and >>>>>> tried booting on keystone k2hk and k2e EVM. The boot hangs with >>>>>> following log. Has anyone seen this? Keystone is an ARM v7 cortex >>>>>> A15 SMP platform. I am assuming master branch is broken for ARM v7 >>>>>> and someone is working to address this. v3.18 booted up fine on my >>>>>> EVM. >>>>>> >>>>>> Any idea? >>>>> You forgot to attach the log?! So no, I don't have any idea. Did you >>>>> bisect? >>> >>> This was my first git bisect work. git bisect showed me below commit >>> as bad commit. But it is pretty old commit. I tried reverting the >>> commit and my board booted up fine. The boot log attached below. I >>> did following until I got the bad commit. v3.18 also worked fine. >>> >>> git bisect start >>> git bisect good >>> git bisect bad >>> >>> I build and test. If boots fine, I did git bisect good and if not, >>> git bisect bad until I got the bad commit. Can someone comment if my >>> bisect steps look sane? If so, what is wrong with the below commit? >>> Ours is a LPAE SoC. >>> >>> commit 1e6b48116a95046ec51f3d40f83aff8b006674d7 >>> Author: Kees Cook >>> Date: Thu Apr 3 17:28:11 2014 -0700 >>> >>> ARM: mm: allow non-text sections to be non-executable >>> >>> Adds CONFIG_ARM_KERNMEM_PERMS to separate the kernel memory regions >>> into section-sized areas that can have different permisions. >>> Performs >>> the NX permission changes during free_initmem, so that init >>> memory can be >>> reclaimed. >>> >>> This uses section size instead of PMD size to reduce memory lost to >>> padding on non-LPAE systems. >>> >>> Based on work by Brad Spengler, Larry Bassel, and Laura Abbott. >>> >>> Signed-off-by: Kees Cook >>> Tested-by: Laura Abbott >>> Acked-by: Nicolas Pitre >>> Looks like kernel_x_start, kernel_x_end are calculated wrongly in LPAE case. kernel_x_start == 0x0000 0000 kernel_x_end == 0x0080 0000 but should be: kernel_x_start == 0x0000 0008 0000 0000 kernel_x_end == 0x0000 0008 0080 0000 Below diff restores boot for me: Tested-By: Murali Karicheri Acked-by: Kees Cook diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index cda7c40..4e6ef89 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -1329,8 +1329,8 @@ static void __init kmap_init(void) static void __init map_lowmem(void) { struct memblock_region *reg; - unsigned long kernel_x_start = round_down(__pa(_stext), SECTION_SIZE); - unsigned long kernel_x_end = round_up(__pa(__init_end), SECTION_SIZE); + phys_addr_t kernel_x_start = round_down(__pa(_stext), SECTION_SIZE); + phys_addr_t kernel_x_end = round_up(__pa(__init_end), SECTION_SIZE); /* Map all the lowmem memory banks. */ for_each_memblock(memory, reg) {