From patchwork Thu Dec 25 10:32:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pankaj Dubey X-Patchwork-Id: 5541531 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AC7A79F1CD for ; Thu, 25 Dec 2014 10:35:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C7AF1201BB for ; Thu, 25 Dec 2014 10:35:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0C0F20148 for ; Thu, 25 Dec 2014 10:35:36 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y45iq-0003Vt-2w; Thu, 25 Dec 2014 10:32:48 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y45in-0003UP-Me for linux-arm-kernel@lists.infradead.org; Thu, 25 Dec 2014 10:32:46 +0000 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NH400CT4VXWFO90@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 25 Dec 2014 19:32:21 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.124]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id EB.0B.19034.4B7EB945; Thu, 25 Dec 2014 19:32:20 +0900 (KST) X-AuditID: cbfee691-f79b86d000004a5a-dc-549be7b44093 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 08.60.09430.4B7EB945; Thu, 25 Dec 2014 19:32:20 +0900 (KST) Received: from pankaj.dubey-ubuntu ([107.108.83.158]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NH400IU5VXVC3A0@mmp2.samsung.com>; Thu, 25 Dec 2014 19:32:20 +0900 (KST) Message-id: <549BE7CC.1000005@samsung.com> Date: Thu, 25 Dec 2014 16:02:44 +0530 From: Pankaj Dubey User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-version: 1.0 To: Ming Lei , Russell King , Kukjin Kim , linux-arm-kernel , linux-samsung-soc@vger.kernel.org Subject: Re: kernel panic when booting on exynos 5440 References: In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsWyRsSkRnfL89khBl93WFn0P37NbLHp8TVW ixnn9zFZ3L7Ma9GxjNHi/Y/r7A5sHi3NPWweO2fdZffYtKqTzWPzknqPvi2rGD0+b5ILYIvi sklJzcksSy3St0vgyri67BxbwVXBiubLX9kaGFv4uhg5OCQETCRWXq/rYuQEMsUkLtxbzwZi CwksZZRYuckMIm4i0fDiAVMXIxdQfDqjxIXzD1ghnFYmiXdLN7ODDOIV0JK4cSYZxGQRUJVY PDcJpJdNQFfiyfu5zCC2qECExJU1cxhBbF4BQYkfk++xgIwRETjDKPFj9V2wxcxAYyY/3cUK MkdYwFTiyj1niHsCJF59+88EYnMKBEtsfLyPBaLcTOLLy8OsELa8xOY1b5lBZkoInGOXOHjo BNgyFgEBiW+TD7FA/CsrsekAM8RfkhIHV9xgmcAoNgvJSbOQjJ2FZOwCRuZVjKKpBckFxUnp RaZ6xYm5xaV56XrJ+bmbGIGxdvrfs4k7GO8fsD7EKMDBqMTD+yBmdogQa2JZcWXuIUZToCsm MkuJJucDIzqvJN7Q2MzIwtTE1NjI3NJMSZxXR/pnsJBAemJJanZqakFqUXxRaU5q8SFGJg5O qQbGBlkLsXwfcQGOB1pMQVEyJx61H3gQ5XVSarLhg5kZZWGPS6y5V8y/EGjsfm5zRaWM7yHx 2Ncy+6//lWMN/bkoVa/o9cLFLtWs/x8Gy95atcLr2LmW552Ltp3YYORSUsm+8elSo0MGloZr D62qCl52ozZMNTZzu/lp7bal0RJxlvaeWw07NI8rsRRnJBpqMRcVJwIAFDcdRrACAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsVy+t9jQd0tz2eHGFzsMLTof/ya2WLT42us FjPO72OyuH2Z16JjGaPF+x/X2R3YPFqae9g8ds66y+6xaVUnm8fmJfUefVtWMXp83iQXwBbV wGiTkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA3SEkkJZ Yk4pUCggsbhYSd8O04TQEDddC5jGCF3fkCC4HiMDNJCwhjHj6rJzbAVXBSuaL39la2Bs4eti 5OSQEDCRaHjxgAnCFpO4cG89WxcjF4eQwHRGiQvnH7BCOK1MEu+WbmbvYuTg4BXQkrhxJhnE ZBFQlVg8Nwmkl01AV+LJ+7nMILaoQITElTVzGEFsXgFBiR+T77GAjBEROMMo8WP1XTaQBDPQ mMlPd7GCzBEWMJW4cs8ZJCwkECDx6tt/sHs4BYIlNj7exwJRbibx5eVhVghbXmLzmrfMExgF ZiFZMQtJ2SwkZQsYmVcxiqYWJBcUJ6XnGukVJ+YWl+al6yXn525iBEfzM+kdjKsaLA4xCnAw KvHwPoiZHSLEmlhWXJl7iFGCg1lJhLdwKVCINyWxsiq1KD++qDQntfgQoykwACYyS4km5wMT TV5JvKGxibmpsamliYWJmaWSOK+SfVuIkEB6YklqdmpqQWoRTB8TB6dUA2PUjB2378geeJGd cWJ53OXVfbNfPAtRnv+rPSDsc3ctV8x7242OpjUvrNdf1lxrKvmtUKpnZ/gXt2CP6eZvDSzj +gs7RcVUvP/oyK2+WGMo33l829mzW341WOVYvxOe1dhlwsbqOfmxnnFVsmWTxAenNd+zWY9O N+/+KHru2EnFpUf/qXe1pCuxFGckGmoxFxUnAgDnhrFH/AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141225_023245_895620_8D09D192 X-CRM114-Status: GOOD ( 15.68 ) X-Spam-Score: -5.0 (-----) Cc: Thomas Abraham X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP +CC: Thomas Abraham Hi Ming, On Thursday 25 December 2014 02:18 PM, Ming Lei wrote: > Hi Pankaj, > > In your commit fce9e5bb2(ARM: EXYNOS: Add support for > mapping PMU base address via DT), 'pmu_base_addr' is > only parsed for very limited machines from the table of > 'exynos_dt_pmu_match'. For other boards, 'pmu_base_addr' > will keep its default value of null, then panic() is triggered. > Yes, it will. As exynos5440 DT does not have PMU device node, neither above mentioned patch added corresponding matching device_id. If I remember correctly, I might have missed this because exynos5440 DT was not having PMU node. > What do you think about the problem? I missed this part, and I should have taken care of this in original patch itself. Well as of now I can think of only one solution that if we really want to keep support for exynos5440 in mainline kernel, to avoid above issue we should skip pmu mapping for exynos5440. In this case following patch will do this work. Also I will like to know from Kukjin that what best can be done now. If he is OK with below solution I can post the same. --------------------------------------------------------------- Subject: [PATCH] ARM: EXYNOS: do not try to map PMU for exynos5440 Commit id: 2e94ac42898f84d76e3c21dd91bc is not taking care of mapping of exynos5440 PMU register which will result in kernel panic. As of now let's avoid mapping of exynos5440 PMU. Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/exynos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ------------------------------------------------------ > > Thanks, > Ming Lei > Thanks, Pankaj Dubey diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index c13d083..1891b8c 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -208,7 +208,8 @@ static void __init exynos_init_irq(void) * DT is not unflatten so we can't use DT APIs before * init_irq */ - exynos_map_pmu(); + if (!of_machine_is_compatible("samsung,exynos5440")) + exynos_map_pmu(); } static void __init exynos_dt_machine_init(void)