From patchwork Fri Jan 9 06:51:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Nan X-Patchwork-Id: 5596851 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6683FC058D for ; Fri, 9 Jan 2015 06:54:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 710622050E for ; Fri, 9 Jan 2015 06:54:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F1BE2050B for ; Fri, 9 Jan 2015 06:54:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y9TQy-00014h-SC; Fri, 09 Jan 2015 06:52:36 +0000 Received: from szxga03-in.huawei.com ([119.145.14.66]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y9TQt-0000Qf-T3 for linux-arm-kernel@lists.infradead.org; Fri, 09 Jan 2015 06:52:32 +0000 Received: from 172.24.2.119 (EHLO szxeml419-hub.china.huawei.com) ([172.24.2.119]) by szxrg03-dlp.huawei.com (MOS 4.4.3-GA FastPath queued) with ESMTP id AZU99662; Fri, 09 Jan 2015 14:51:42 +0800 (CST) Received: from [127.0.0.1] (10.111.69.90) by szxeml419-hub.china.huawei.com (10.82.67.158) with Microsoft SMTP Server id 14.3.158.1; Fri, 9 Jan 2015 14:51:33 +0800 Message-ID: <54AF7A79.20500@huawei.com> Date: Fri, 9 Jan 2015 14:51:37 +0800 From: Wang Nan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: , , Subject: Re: [PATCH v19 08/11] ARM: kprobes: enable OPTPROBES for ARM 32 References: <1420457284-76923-1-git-send-email-wangnan0@huawei.com> <1420457376-77366-1-git-send-email-wangnan0@huawei.com> In-Reply-To: <1420457376-77366-1-git-send-email-wangnan0@huawei.com> X-Originating-IP: [10.111.69.90] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.54AF7A87.0103, ss=1, re=0.001, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 3880913c2de46d35530972a079e31d9d X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150108_225232_164566_BC9D5A03 X-CRM114-Status: UNSURE ( 5.56 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.3 (--) Cc: lizefan@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Tixy and other, Similar to patch 01/11, build robot found a building error in this patch when ARM version is lower than 4. In such processors 'blx' instruction is unusable. I have posted a new version of this patch, which has following code change: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/314542.html Tixy, could you please collect it into your repository and test again? Thank you! diff --git a/arch/arm/probes/kprobes/opt-arm.c b/arch/arm/probes/kprobes/opt-arm.c index 6a60df3..cb47eff 100644 --- a/arch/arm/probes/kprobes/opt-arm.c +++ b/arch/arm/probes/kprobes/opt-arm.c @@ -58,7 +58,12 @@ asm ( */ " and r4, sp, #4\n" " sub sp, sp, r4\n" +#if __LINUX_ARM_ARCH__ >= 5 " blx r2\n" +#else + " mov lr, pc\n" + " bx r2\n" +#endif " add sp, sp, r4\n" " ldr r1, [sp, #64]\n" " tst r1, #"__stringify(PSR_T_BIT)"\n"