From patchwork Tue Jan 27 10:59:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 5716351 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7AAB09F302 for ; Tue, 27 Jan 2015 11:02:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 76D92201FB for ; Tue, 27 Jan 2015 11:02:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86151201B9 for ; Tue, 27 Jan 2015 11:02:08 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YG3sf-0003ZD-Kr; Tue, 27 Jan 2015 11:00:25 +0000 Received: from mailout3.w1.samsung.com ([210.118.77.13]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YG3sa-0002Di-7B for linux-arm-kernel@lists.infradead.org; Tue, 27 Jan 2015 11:00:21 +0000 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NIU007M51ELQL10@mailout3.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 27 Jan 2015 11:03:58 +0000 (GMT) X-AuditID: cbfec7f4-b7f126d000001e9a-f9-54c76f182ea6 Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 7C.F6.07834.81F67C45; Tue, 27 Jan 2015 10:57:28 +0000 (GMT) Received: from [106.116.147.32] by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NIU008XD17SES90@eusync2.samsung.com>; Tue, 27 Jan 2015 10:59:53 +0000 (GMT) Message-id: <54C76F9D.7040805@samsung.com> Date: Tue, 27 Jan 2015 11:59:41 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-version: 1.0 To: Tobias Jakobi Subject: Re: [PATCH v2 00/16] ASoC: samsung: Add clk provider for I2S internal clocks References: <1418997336-17777-1-git-send-email-s.nawrocki@samsung.com> <54C2FB25.4030501@gmx.net> In-reply-to: <54C2FB25.4030501@gmx.net> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t/xK7oS+cdDDLasVLO4cvEQk8XUh0/Y LOYfOcdq8Wj+Y2aL/sevmS02Pb7GajHj/D4mi66fP9ksft/8zmZxccUXJgcujw2fm9g8Fn3P 8li8aT+bx6ZVnWwem5fUe/RtWcXo8XmTXAB7FJdNSmpOZllqkb5dAlfG4XftrAUvhSsOPTrF 0sD4nL+LkZNDQsBE4t/2U8wQtpjEhXvr2UBsIYGljBLzT4h1MXIB2Z8YJQ4cWwmW4BXQknj7 9BEjiM0ioCqxYe49FhCbTcBQovdoH1hcVCBC4uTdPewQ9YISPyZD1IgIqEu8//+ADWQos8A7 RomzzzuBijg4hAXCJebOM4dYnCwx/dEeJhCbE6h+18TdbCAlzED2lCm5IGFmAXmJzWveMk9g FJiFZMMshKpZSKoWMDKvYhRNLU0uKE5KzzXUK07MLS7NS9dLzs/dxAiJhy87GBcfszrEKMDB qMTDO2Hi0RAh1sSy4srcQ4wSHMxKIrxeEcdDhHhTEiurUovy44tKc1KLDzEycXBKNTCmGDjU 5H1/4vz5hnhDX6nOhP2r3m4+e3FvRtK3TJfZngutlMrzWhMjbh140Mdd/nSmg0Is5wET0xM3 f/EbyB+Scvy/66HFhHDfyHLjGXYPf0i+y+3hMDJ73Vnu/lWq1/v9NefZt2YufNxSJ3OoPffV wf7dRj3pdxoL1lbE/3xX6jV/+VSHqflKLMUZiYZazEXFiQAInux+ZQIAAA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150127_030020_432520_A470BE15 X-CRM114-Status: GOOD ( 19.33 ) X-Spam-Score: -5.0 (-----) Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, padma.v@samsung.com, sbkim73@samsung.com, drake@endlessm.com, broonie@kernel.org, kgene@kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Tobias, On 24/01/15 02:53, Tobias Jakobi wrote: > Hello, > > I've tested the series on my X2 and so far I haven't encountered any > obvious issues with it. > > I have a small question though. With the move to simple-audio-card the > old driver (selected by SND_SOC_ODROIDX2) is probably going away after > some time. > Currently SND_SOC_ODROIDX2 also selects SND_SOC_MAX98090 and > SND_SAMSUNG_I2S, which I believe (correct me if I'm wrong) are necessary > to use the sound subsystem even with simple-audio-card (since the > max98090 codec has to be built at least). I've found no way of selecting > these two manually, so at the moment I need both CONFIG_SND_SIMPLE_CARD > and SND_SOC_ODROIDX2 enabled to use sound. Is this intended behaviour? Thanks for the feedback. It seems I finally forgot to update Kconfig, presumably we should make SND_SOC_ODROIDX2 selecting SND_SIMPLE_CARD, i.e. Making SND_SOC_SAMSUNG selecting SND_SIMPLE_CARD is probably not a good idea and still we would be missing the codec part. I'm going to post a patch as above. > And while I'm at it. I'm booting the board with an upstream u-boot > version which sets the MPLL to 800MHz, which AFAIK is the clocking rate > that makes less 'trouble' (but at the expense of performance). > I was wondering if anyone can comment on whether the recent rework has > any influence on the behaviour when booting with the vendor u-boot > (which sets the MPLL to 880MHz). IIRC then clock rounding issues arose > there. > > It would be interesting to know if this series gets us closer to drive > the MPLL with the recommended (?) higher clocking rate. No, (unfortunately) this series has nothing to do with MPLL. The whole clock tree for sound is configured by the kernel, including the EPLL, which provides reference clock for the audio subsystem. MPLL and EPLL are normally used in different clock domains. So there should be no any clock rounding issues related to bootloader as far as audio is concerned. Please let me know if you find any related problems. diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig index 58c797a..7fb728c 100644 --- a/sound/soc/samsung/Kconfig +++ b/sound/soc/samsung/Kconfig @@ -247,6 +247,7 @@ config SND_SOC_ODROIDX2 depends on SND_SOC_SAMSUNG select SND_SOC_MAX98090 select SND_SAMSUNG_I2S + select SND_SIMPLE_CARD help Say Y here to enable audio support for the Odroidx2.