From patchwork Wed Jan 28 17:37:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Hurley X-Patchwork-Id: 5728831 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4B07D9F399 for ; Wed, 28 Jan 2015 17:40:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D1B1E202FE for ; Wed, 28 Jan 2015 17:40:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B751A201DD for ; Wed, 28 Jan 2015 17:40:08 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YGWZH-0000Eq-Ul; Wed, 28 Jan 2015 17:38:19 +0000 Received: from mail-qc0-f171.google.com ([209.85.216.171]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YGWZ6-0008Ji-OL for linux-arm-kernel@lists.infradead.org; Wed, 28 Jan 2015 17:38:10 +0000 Received: by mail-qc0-f171.google.com with SMTP id s11so17541362qcv.2 for ; Wed, 28 Jan 2015 09:37:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=SVzNntK9CCIupl9v2HG33V2+UJUgKwyOKg3Vh9nKrQk=; b=QLNgXq7kCG9EalYqwGCxkkh7fe0Vc+X0VnymnzZ/0NIBCSffLJhBjNPlehYlUA2H+A 89ZEazHYIz9DvcGBQnYTnF6gZBGyVISvHnZMFEw+D3DVfDdey+rswcZuMae2GsJJlszT uFBPmd/nPUEqVrXpjWNIb3kJjVKFlpjXlc/KSY7FSxYm1Nw7W6psatZlmromP38CTyNf 3K3bt3p9zBphKmaLFG0nrV6IEVVT85scc34g7Ng5qkLgaqQFeAieJVX/QKkZuyLh2Np8 DzEotYRd+KghP+zr9v65/4Q70vFvb3lS215v4I2BmqEhkPIH0QhgWrshCGLvCkJMpiK2 4K2w== X-Gm-Message-State: ALoCoQlKrSDlJyZTJk92euN2QNZaUHKsfn0Z1VjP3wDNgSyJ6Jp6cHYTE3WjWmuqATfrVdRywBQo X-Received: by 10.140.40.211 with SMTP id x77mr14289426qgx.25.1422466667228; Wed, 28 Jan 2015 09:37:47 -0800 (PST) Received: from [192.168.1.139] (h96-61-87-245.cntcnh.dsl.dynamic.tds.net. [96.61.87.245]) by mx.google.com with ESMTPSA id 35sm4579649qgm.39.2015.01.28.09.37.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jan 2015 09:37:46 -0800 (PST) Message-ID: <54C91E67.2070501@hurleysoftware.com> Date: Wed, 28 Jan 2015 12:37:43 -0500 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rob Herring Subject: Re: [PATCH 2/3] tty/serial: of_serial: add support for PXA/MMP uarts References: <1422334209-23125-1-git-send-email-robh@kernel.org> <1422334209-23125-2-git-send-email-robh@kernel.org> <54C78823.7050504@hurleysoftware.com> <54C7AA2D.7080202@hurleysoftware.com> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150128_093808_862294_4B40A264 X-CRM114-Status: GOOD ( 12.76 ) X-Spam-Score: -0.7 (/) Cc: Greg Kroah-Hartman , Jiri Slaby , "linux-arm-kernel@lists.infradead.org" , "linux-serial@vger.kernel.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 01/27/2015 11:44 AM, Rob Herring wrote: > On Tue, Jan 27, 2015 at 9:09 AM, Peter Hurley wrote: [...] >> Maybe Kconfig should warn if they're both built-in or both modules? > > Is there a way to do that? Well, it's not what I had in mind originally, but the diff below generates a broken dependencies warning without causing build problems: $ scripts/kconfig/mconf Kconfig warning: (SERIAL_PXA) selects TTYS_DRIVER_PXA which has unmet direct dependencies (TTY && HAS_IOMEM && !TTYS_DRIVER) (My original idea was thwarted by the requirement that choice/endchoice requires prompts). That said, for PXA, I think we agree splitting out a standalone 8250 platform driver is the solution. Regards, Peter Hurley diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index 0fcbcd2..c367542 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -6,6 +6,7 @@ config SERIAL_8250 tristate "8250/16550 and compatible serial support" select SERIAL_CORE + select TTYS_DRIVER ---help--- This selects whether you want to include the driver for the standard serial ports. The standard answer is Y. People who might say N diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index c79b43c..10c3e27 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -7,6 +7,13 @@ if TTY menu "Serial drivers" depends on HAS_IOMEM +config TTYS_DRIVER + tristate + +config TTYS_DRIVER_PXA + tristate + depends on !TTYS_DRIVER + config SERIAL_EARLYCON bool help @@ -438,6 +445,7 @@ config SERIAL_PXA bool "PXA serial port support" depends on ARCH_PXA || ARCH_MMP select SERIAL_CORE + select TTYS_DRIVER_PXA help If you have a machine based on an Intel XScale PXA2xx CPU you can enable its onboard serial ports by enabling this option.