From patchwork Wed Mar 11 01:10:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chanwoo Choi X-Patchwork-Id: 5981341 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6276ABF440 for ; Wed, 11 Mar 2015 01:12:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7F8AE2012E for ; Wed, 11 Mar 2015 01:12:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9943C200F0 for ; Wed, 11 Mar 2015 01:12:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YVVAV-0005Dz-Gz; Wed, 11 Mar 2015 01:10:39 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YVVAN-0004SV-B7 for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2015 01:10:36 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NL000JROWKTG3C0@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2015 10:10:06 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.112]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id AC.C8.11124.DE59FF45; Wed, 11 Mar 2015 10:10:05 +0900 (KST) X-AuditID: cbfee68e-f79b46d000002b74-7a-54ff95ed56a9 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 92.59.20081.DE59FF45; Wed, 11 Mar 2015 10:10:05 +0900 (KST) Received: from [10.252.81.195] by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NL0003JCWKTL160@mmp2.samsung.com>; Wed, 11 Mar 2015 10:10:05 +0900 (KST) Message-id: <54FF95ED.1040003@samsung.com> Date: Wed, 11 Mar 2015 10:10:05 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Valentin Rothberg Subject: Re: ARCH_EXYNOS5433 missing in Kconfig References: In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42JZI2JSoPt26v8Qg+W9+hZ/Jx1jt5h/5Byr Rf+bhawW516tZLSYdH8Ci0X/49fMFpseX2O1uLxrDpvFjPP7mCyWXr/IZPF0wkU2iwnT17JY LLp1htmide8Rdotjr96zWxx+085q8eNMN4tF9/1JbBardv1htPjU3MbsIOKxZt4aRo/fvyYx elzu62Xy+P99KovH+fbZLB47Z91l91i5/Aubx6ZVnWwed67tYfPYvKTeo2/LKkaPjdufMHl8 3iQXwBvFZZOSmpNZllqkb5fAlbF51gTWgpvCFc03/rA1MC4U6GLk5JAQMJG439fKDGGLSVy4 t56ti5GLQ0hgKaPEv/1HWWGKWiauZ4RITGeUmL9hMyuE85pRomtCE1gVr4CWxKObn5lAbBYB VYmv/28xgthsQPH9L26wgdiiAmESK6dfYYGoF5T4MfkemC0iYCRx9PVaZpChzAJdbBL7vvwB axAW0JeY23kbbJCQQIBE1553YLdyCgRLHHncBhZnFlCXmDRvETOELS+xec1bsEESAi84JDq+ vWaEuEhA4tvkQ0DbOIASshKbDkD9LClxcMUNlgmMYrOQ3DQLydhZSMYuYGRexSiaWpBcUJyU XmSkV5yYW1yal66XnJ+7iRGYSk7/e9a3g/HmAetDjAIcjEo8vAwm/0KEWBPLiitzDzGaAl0x kVlKNDkfmLDySuINjc2MLExNTI2NzC3NlMR5E6R+BgsJpCeWpGanphakFsUXleakFh9iZOLg lGpgzF0dcS6Vfbrhlt702O+3rC/xnV9lvu//gsrnkga5q/tYXAxZ95VE+RQpPkhazvNn7vbN 9c8D+VntJDNn7pE8tvW217SHu/S4NxVenTmrRVB5v9cMw+miE943bE9kOih3kcs2a+/NRcy8 l5fJXT41h5Vr+4w+ubxunWmuWRaPNmf+KY+ZHVvOp8RSnJFoqMVcVJwIABvQoHsgAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOKsWRmVeSWpSXmKPExsVy+t9jQd23U/+HGDQcUrH4O+kYu8X8I+dY LfrfLGS1OPdqJaPFpPsTWCz6H79mttj0+BqrxeVdc9gsZpzfx2Sx9PpFJounEy6yWUyYvpbF YtGtM8wWrXuPsFsce/We3eLwm3ZWix9nulksuu9PYrNYtesPo8Wn5jZmBxGPNfPWMHr8/jWJ 0eNyXy+Tx//vU1k8zrfPZvHYOesuu8fK5V/YPDat6mTzuHNtD5vH5iX1Hn1bVjF6bNz+hMnj 8ya5AN6oBkabjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfM HKB/lRTKEnNKgUIBicXFSvp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGENYwZm2dNYC24KVzRfOMP WwPjQoEuRk4OCQETiZaJ6xkhbDGJC/fWs3UxcnEICUxnlJi/YTMrhPOaUaJrQhMrSBWvgJbE o5ufmUBsFgFVia//b4F1swHF97+4wQZiiwqESaycfoUFol5Q4sfke2C2iICRxNHXa5lBhjIL dLFJ7PvyB6xBWEBfYm7nbbBBQgIBEl173jGD2JwCwRJHHreBxZkF1CUmzVvEDGHLS2xe85Z5 AqPALCQ7ZiEpm4WkbAEj8ypG0dSC5ILipPRcQ73ixNzi0rx0veT83E2M4ET1TGoH48oGi0OM AhyMSjy8DCb/QoRYE8uKK3MPMUpwMCuJ8F7O+x8ixJuSWFmVWpQfX1Sak1p8iNEUGAQTmaVE k/OBSTSvJN7Q2MTMyNLI3NDCyNhcSZxXyb4tREggPbEkNTs1tSC1CKaPiYNTCpgo3r6au/rB x+7zB3xd9BvusgS0a1Rn+LJcneRx/PT2fS36d5rq65cp9yxNeXLv2c/jIhkd6Y9/yc316Jgw v+nNv9ufRHvZ33NwiNWF3vIMdWlYqLZpxrlMtw4Zt36mZ/NW3Nd/K61a9D3y0/XXeYI5HXeq NTtm5mYd9pJiDBDZabtTY+PcQ81KLMUZiYZazEXFiQA83Fx1agMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150310_181031_603289_AD0D55CA X-CRM114-Status: GOOD ( 17.54 ) X-Spam-Score: -5.0 (-----) Cc: Mark Rutland , devicetree@vger.kernel.org, Paul Bolle , linux-samsung-soc@vger.kernel.org, Mike Turquette , Arnd Bergmann , Pawel Moll , Ian Campbell , Stephen Boyd , Tomasz Figa , linux-kernel@vger.kernel.org, Inki Dae , Rob Herring , =?UTF-8?B?Iuq5gOq1reynhEBrZXJuZWwub3JnIg==?= , Sylwester Nawrocki , Kumar Gala , Andreas Ruprecht , hengelein Stefan , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Valentin, I sent the Exynos5433 clock patch and then separately I'm sending the Exynos5433 devicetree patch-set[1]. [1] [PATCH v6 0/9] arm64: Add the support for new Exynos5433 SoC - https://lkml.org/lkml/2015/3/9/1036 But, according to Arnd bergmann's comment[2], latest Exynos5433 dt patch-set[1] removed the CONFIG_ARCH_EXYNOS5433. [2] https://lkml.org/lkml/2015/2/24/85 So, I have plan to send following patch. --- clk: samsung: Use CONFIG_ARCH_EXYNOS instead of Exynos-specific configuration This patch removes the CONFIG_ARCH_EXYNOS{5433|7} and then use only the CONFIG_ARCH_EXYNOS for ARM-64bit Exynos SoC. Cc: Sylwester Nawrocki Cc: Tomasz Figa Cc: Arnd Bergmann Signed-off-by: Chanwoo Choi --- drivers/clk/samsung/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) On 03/11/2015 12:32 AM, Valentin Rothberg wrote: > Hi Chanwoo, > > your commit 96bd6224f07b ("clk: samsung: exynos5433: Add clocks using > common clock framework") is included in today's linux-next tree (i.e., > next-20150310). > > This patch conditionally compiles clk-exynos5433.c depending on the > Kconfig option ARCH_EXYNOS5433. However, this option is not defined > in Kconfig, so that the driver cannot be compiled at the current > state: > > +obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o > > Is there a patch queued somewhere that adds this Kconfig symbol? I > detected the issue by running undertaker-checkpatch from the > Undertaker tool suite (undertaker.cs.fau.de). There is also a tool in > the git tree that can detect such issues (i.e., > scripts/checkkconfigsymbols.py). > > Kind regards, > Valentin > diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile index 17e9af7..561719d 100644 --- a/drivers/clk/samsung/Makefile +++ b/drivers/clk/samsung/Makefile @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o -obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o +obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o Regards, Chanwoo Choi