From patchwork Fri May 22 19:17:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 6467481 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 06D189F1CC for ; Fri, 22 May 2015 19:20:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0D94220497 for ; Fri, 22 May 2015 19:20:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FEC32045E for ; Fri, 22 May 2015 19:20:24 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YvsS0-0004eY-8O; Fri, 22 May 2015 19:17:44 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YvsRx-0004Is-IP for linux-arm-kernel@lists.infradead.org; Fri, 22 May 2015 19:17:42 +0000 Received: from smtp.codeaurora.org (localhost [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 69AD5141486; Fri, 22 May 2015 19:17:20 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 486) id 5015414148A; Fri, 22 May 2015 19:17:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from [10.134.64.202] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id ACB2C141486; Fri, 22 May 2015 19:17:18 +0000 (UTC) Message-ID: <555F80BE.8070204@codeaurora.org> Date: Fri, 22 May 2015 12:17:18 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Brent Wang Subject: Re: [PATCH v7 6/7] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC References: <1432117752-7074-1-git-send-email-bintian.wang@huawei.com> <1432117752-7074-2-git-send-email-bintian.wang@huawei.com> <555D09F3.7020506@codeaurora.org> <555D57BB.8080702@huawei.com> <555E1D55.1050907@codeaurora.org> <555EBCA4.9030303@huawei.com> <555F76D9.10308@codeaurora.org> <20150522184131.GD1885@codeaurora.org> In-Reply-To: X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150522_121741_683661_23278DA8 X-CRM114-Status: GOOD ( 21.98 ) X-Spam-Score: -0.0 (/) Cc: Mark Rutland , "dan.zhao@hisilicon.com" , Catalin Marinas , "wangbinghui@hisilicon.com" , Will Deacon , "huxinwei@huawei.com" , Kevin Hilman , Haojian Zhuang , Haifeng Yan , linux-clk@vger.kernel.org, Mike Turquette , Kevin Hilman , "victor.lixin@hisilicon.com" , Xu Wei , "zhenwei.wang@hisilicon.com" , "sledge.yanwei@huawei.com" , XinWei Kong , "heyunlei@huawei.com" , "puck.chen@hisilicon.com" , Zhangfei Gao , "z.liuxinliang@huawei.com" , Bintian , Arnd Bergmann , Tyler Baker , "xuejiancheng@huawei.com" , Rob Herring , Russell King - ARM Linux , "w.f@huawei.com" , linux-arm-kernel , Tomeu Vizoso , Guodong Xu , "linux-kernel@vger.kernel.org" , Olof Johansson , Jorge Ramirez-Ortiz , "xuyiping@hisilicon.com" , "Liguozhu \(Kenneth\)" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 05/22/15 11:57, Brent Wang wrote: > Hello Stephen, > > 2015-05-23 2:41 GMT+08:00 Stephen Boyd : >> On 05/22, Stephen Boyd wrote: >>> On 05/22/15 11:30, Brent Wang wrote: >>>> Hello Stephen, >>>> >>>> 2015-05-22 13:20 GMT+08:00 Bintian : >>>>>> Is pl011 the uart device? Does it have a node in DT somewhere? If it >>>>>> does, then we could put the assigned-parents properties in that node so >>>>>> that when the pl011 probes the uart1 clock has its parent set to >>>>>> clk_150m. See the "Assigned clock parents and rates" section of >>>>>> Documentation/devicetree/bindings/clock/clock-bindings.txt. >>>>>> >>>>> I will verify this. >>>> Currently the "assigned-clock*" doesn't work for pl011 UART device >>>> node, maybe we will >>>> do some fix for its driver later or other modules. >>> Why doesn't it work? >>> >> Does this patch help? > Yes, it works! > > I also tested adding "of_clk_set_defaults" to "pl011_probe()", and > "assigned-clock*" > also works. > > So you will submit another patch to fix this problem and I can revove > the "clk_set_parent" > from my patch, right ? > > How about you take it as part of your series? Or if you're planning on splitting out the clk patch to go through clk-tree I can apply it before applying the clock driver patch. ----8<----- From: Stephen Boyd Subject: [PATCH] amba: Support clk parents and rates assigned in DT Add the call to of_clk_set_defaults() into the amba probe path so that devices on the amba bus can use the assigned rates and parents feature of the common clock framework. Signed-off-by: Stephen Boyd Tested-by: Bintian Wang --- drivers/amba/bus.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index f0099360039e..350ed93d4281 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -19,6 +19,7 @@ #include #include #include +#include #include @@ -237,6 +238,10 @@ static int amba_probe(struct device *dev) int ret; do { + ret = of_clk_set_defaults(dev->of_node, false); + if (ret < 0) + break; + ret = dev_pm_domain_attach(dev, true); if (ret == -EPROBE_DEFER) break;