From patchwork Thu Jun 25 05:57:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Hiremath X-Patchwork-Id: 6672181 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CF86DC05AC for ; Thu, 25 Jun 2015 06:00:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C3291206F7 for ; Thu, 25 Jun 2015 06:00:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B12FD206F6 for ; Thu, 25 Jun 2015 06:00:21 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z80Ao-0004Io-Dx; Thu, 25 Jun 2015 05:58:06 +0000 Received: from mail-pa0-f50.google.com ([209.85.220.50]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z80Ak-0004GW-Sq for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2015 05:58:03 +0000 Received: by padev16 with SMTP id ev16so43337479pad.0 for ; Wed, 24 Jun 2015 22:57:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=UfR1zkwC4q13CQFWDJoewyZ824UC2du2qXQd8qcNrfA=; b=fAUQyoRO8K+mgkcSRakSPOLSzyy0OCsXzI/1l/Yb2Aa45SnQV1usMi1pj0kYb10u+g zTdRgTYRsTSQct+zB3pT5vQWmpuKWKrB2Fg54ZzcB5yCmxLG8veZfn10ziYZE4gzJ7iE C/0oJE00fCaFJepqMLk05QWiferhCxX4gfxjA6yaRTg70toQPvehPDw+JHjFkQV4kDwc 0vb0N/j3ddmyWuTRI4omCzL88MUNT5JW/+LxCkC9jyt+OExPeCz1kCLHk1AE95TFVyxW Dm9LQF9QVu8YsRZBDoTAl088Jm3UldlW9B+TAvFaTVcGjtdUDn9UORuwdz8ar6ky2S4B pX0A== X-Gm-Message-State: ALoCoQnT4P3FAlPF3LYvjlMOxOPSeX444Igdjlsd5qTsejT4JgABxzQJ3mIO2NhYiRnGq+stNvWX X-Received: by 10.68.135.136 with SMTP id ps8mr88487637pbb.78.1435211860514; Wed, 24 Jun 2015 22:57:40 -0700 (PDT) Received: from [192.168.0.102] ([202.62.77.106]) by mx.google.com with ESMTPSA id go5sm28622952pbd.36.2015.06.24.22.57.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jun 2015 22:57:39 -0700 (PDT) Message-ID: <558B984D.9040309@linaro.org> Date: Thu, 25 Jun 2015 11:27:33 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Krzysztof Kozlowski Subject: Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method References: <1435137673-1629-1-git-send-email-vaibhav.hiremath@linaro.org> <1435137673-1629-3-git-send-email-vaibhav.hiremath@linaro.org> <558B90F7.80700@linaro.org> <558B9272.6090100@samsung.com> <558B9549.5010705@linaro.org> <558B96B7.3030501@samsung.com> In-Reply-To: <558B96B7.3030501@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150624_225802_992216_B1B3D162 X-CRM114-Status: GOOD ( 17.69 ) X-Spam-Score: -2.6 (--) Cc: Zhao Ye , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thursday 25 June 2015 11:20 AM, Krzysztof Kozlowski wrote: > On 25.06.2015 14:44, Vaibhav Hiremath wrote: >> >> >> On Thursday 25 June 2015 11:02 AM, Krzysztof Kozlowski wrote: >>> On 25.06.2015 14:26, Vaibhav Hiremath wrote: >>>> >>>> >>>> On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: >>>>> 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath >>>>> : >>>>>> As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe >>>>>> (page 0) controls the method of clearing interrupt >>>>>> status of 88pm800 family of devices; >>>>>> >>>>>> 0: clear on read >>>>>> 1: clear on write >>>>>> >>>>>> This patch allows to configure this field, through DT. >>>>>> >>>>>> Also, as suggested by "Lee Jones" renaming DT property and variable >>>>>> field to appropriate name. >>>>>> >>>>>> Signed-off-by: Zhao Ye >>>>>> Signed-off-by: Vaibhav Hiremath >>>>> >>> >> >> Yes, >> Fair enough... >> >> I see very little value in runtime configuration, why not just do it >> only way (either read or write)? >> I would prefer to just set it by default (during init), to clear irq on >> write. > > Hard-coding a default value, if board files are not present, looks OK to me. > This is how it will look, I will also update the binding information with this. hvaibhav@hvaibhav-ThinkPad-T440p:~/projects/mainline/linux$ git diff --cached ret = pm80x_init(client); Thanks, Vaibhav diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index 0a417ac..e415a06 100644 --- a/drivers/mfd/88pm800.c +++ b/drivers/mfd/88pm800.c @@ -645,9 +645,8 @@ static int pm800_probe(struct i2c_client *client, dev_err(&client->dev, "failed to allocaate memory\n"); return -ENOMEM; } - - pdata->irq_clr_on_wr = of_property_read_bool(np, - "marvell,irq-clr-on-write"); + /* Setting irq clear method on write */ + pdata->irq_clr_on_wr = true; }