From patchwork Thu Jul 16 18:24:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Murali Karicheri X-Patchwork-Id: 6810451 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CB5D1C05AC for ; Thu, 16 Jul 2015 18:28:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DFA4E20674 for ; Thu, 16 Jul 2015 18:28:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08866205C6 for ; Thu, 16 Jul 2015 18:28:35 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZFnrP-0007Sf-4W; Thu, 16 Jul 2015 18:26:19 +0000 Received: from devils.ext.ti.com ([198.47.26.153]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZFnqV-0004wK-Me for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2015 18:25:34 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id t6GIOw2S015165; Thu, 16 Jul 2015 13:24:58 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id t6GIOwSU023326; Thu, 16 Jul 2015 13:24:58 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.224.2; Thu, 16 Jul 2015 13:24:32 -0500 Received: from [158.218.101.213] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id t6GIOoRK001116; Thu, 16 Jul 2015 13:24:53 -0500 Message-ID: <55A7F6F6.40202@ti.com> Date: Thu, 16 Jul 2015 14:24:54 -0400 From: Murali Karicheri Organization: Texas Instruments User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: santosh shilimkar , , Subject: Re: arm: dts: update for 4.2-rcx References: <55A7C561.9020406@ti.com> <55A7DE91.7050003@oracle.com> <55A7E0D0.9070104@ti.com> <55A7E1F2.7000100@oracle.com> In-Reply-To: <55A7E1F2.7000100@oracle.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150716_112523_917780_2198D543 X-CRM114-Status: GOOD ( 18.85 ) X-Spam-Score: -8.2 (--------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 07/16/2015 12:55 PM, santosh shilimkar wrote: > On 7/16/2015 9:50 AM, Murali Karicheri wrote: >> On 07/16/2015 12:40 PM, santosh shilimkar wrote: >>> On 7/16/2015 7:53 AM, Murali Karicheri wrote: >>>> Santosh, >>>> >>>> Do you have my patch for https://lkml.org/lkml/2015/7/15/879 ? >>>> This one should be applied to v4.2-rc kernel with priority. >>>> Please review and do the needful. >>>> >>> Yes I have it for next merge window. It won't be qualified as a >>> fix rather more of enhancement. Do you have also patches for >>> board DTS files which enables PCIE. I can queue them together >>> for next merge window. >> No this is a fix for v4.2-rc. PCIe driver is not complete without having >> a SerDes driver. Currently the version we send is not accepted since the >> config blobs are used. On K2E EVM, this causes problem since the EVM has >> Marvell SATA controller present and with default values in the SerDes >> register, it seems to pass the PCIe link check, but causes issues since >> the configuration is not correct. The manifestation is that when EVM is >> booted with NFS rootfs, the boot hangs. We can't enable PCIe on this EVM >> since to work, SerDes driver has to be present as well. So by default, >> the PCIe DT binding should be disabled in SoC specific DTS. It can be >> enabled in the board specific DTS when the SerDes device driver is also >> present. We plan to upstream a common SerDes driver soon. But at this >> point this has to be disabled by default. >> > Please add this information and respin the patch. Thanks for explaining > it. > >> I can provide more details if needed in the patch commit description, >> but I though it is not correct to keep the PCIe DT bindings to be >> enabled in the SoC specific DTS to begin with. So this is a fix for >> v4.2-rc. >> > Please do. It wasn't clear from the patch description. With above added > description its a legitimate fix which I can queue it up for rc's. > Ok. Will do. Need an additional patch to rename the PCI nodes such that status can be overridden in a board specific DTS. + +&pcie1 { + status = "okay"; +}; Same for pcie0 in keystone.dtsi. Do you prefer to put both in the same patch or a separate one for this? Murali > Regards, > Santosh > > diff --git a/arch/arm/boot/dts/k2e.dtsi b/arch/arm/boot/dts/k2e.dtsi index 71e2b1c..0055477 100644 --- a/arch/arm/boot/dts/k2e.dtsi +++ b/arch/arm/boot/dts/k2e.dtsi @@ -94,7 +94,7 @@ status = "disabled"; }; - pcie@21020000 { + pcie1: pcie@21020000 { compatible = "ti,keystone-pcie","snps,dw-pcie"; clocks = <&clkpcie1>; clock-names = "pcie";