From patchwork Sat Aug 8 18:20:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Cvek X-Patchwork-Id: 6975791 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BCEC69F402 for ; Sat, 8 Aug 2015 18:21:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D4CBB20625 for ; Sat, 8 Aug 2015 18:21:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0673920621 for ; Sat, 8 Aug 2015 18:21:12 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZO8hB-0006PC-3l; Sat, 08 Aug 2015 18:18:13 +0000 Received: from bubo.tul.cz ([2001:718:1c01:16::aa]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZO8h7-0006Lx-05 for linux-arm-kernel@lists.infradead.org; Sat, 08 Aug 2015 18:18:10 +0000 Received: from [78.80.185.17] (78-80-185-17.tmcz.cz [78.80.185.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by bubo.tul.cz (Postfix) with ESMTPSA id EBBB11F0004; Sat, 8 Aug 2015 20:17:32 +0200 (CEST) Message-ID: <55C64864.6070405@tul.cz> Date: Sat, 08 Aug 2015 20:20:20 +0200 From: Petr Cvek User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20131204 Thunderbird/17.0.11 MIME-Version: 1.0 To: Robert Jarzmik , daniel@zonque.org, haojian.zhuang@gmail.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com Subject: [PATCH v1, TRIVIAL] Fix pxafb nonstd field documentation and add errata info X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150808_111809_231740_AFB8BFEE X-CRM114-Status: GOOD ( 10.73 ) X-Spam-Score: -2.3 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix pxafb nonstd field documentation and add warning comment to Kconfig and pxafb.c (errata: YUV420 hangs LCD). Signed-off-by: Petr Cvek Acked-by: Robert Jarzmik --- Documentation/fb/pxafb.txt | 8 ++++---- drivers/video/fbdev/Kconfig | 5 +++++ drivers/video/fbdev/pxafb.c | 4 ++++ 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/Documentation/fb/pxafb.txt b/Documentation/fb/pxafb.txt index d143a0a..dbbf5eb 100644 --- a/Documentation/fb/pxafb.txt +++ b/Documentation/fb/pxafb.txt @@ -123,12 +123,12 @@ Overlay Support for PXA27x and later LCD controllers framebuffer framework, application has to take care of the offsets and lengths of each component within the framebuffer. - 4. var->nonstd is used to pass starting (x, y) position and color format, + 4. var->nonstd is used to pass starting (y, x) position and color format, the detailed bit fields are shown below: 31 23 20 10 0 +-----------------+---+----------+----------+ - | ... unused ... |FOR| XPOS | YPOS | + | ... unused ... |FOR| YPOS | XPOS | (as in OVLxC2 register) +-----------------+---+----------+----------+ FOR - color format, as defined by OVERLAY_FORMAT_* in pxafb.h @@ -136,7 +136,7 @@ Overlay Support for PXA27x and later LCD controllers 1 - YUV444 PACKED 2 - YUV444 PLANAR 3 - YUV422 PLANAR - 4 - YUR420 PLANAR + 4 - YUV420 PLANAR - XPOS - starting horizontal position YPOS - starting vertical position + XPOS - starting horizontal position diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 2d98de5..8f485ec 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1893,6 +1893,11 @@ config FB_PXA_OVERLAY bool "Support PXA27x/PXA3xx Overlay(s) as framebuffer" default n depends on FB_PXA && (PXA27x || PXA3xx) + ---help--- + Using the overlay 2 and YUV420 mode on a PXA27x C0 chip revision will + hang the LCD until the next SoC restart (errata E24). + + If unsure, say N or check /proc/cpuinfo for "CPU revision : 4". config FB_PXA_SMARTPANEL bool "PXA Smartpanel LCD support" diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index 7245611..e573699 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -30,6 +30,10 @@ * * Copyright (C) 2006-2008 Marvell International Ltd. * All Rights Reserved + * + * NOTICE + * According to PXA27x errata E24 an enable of the overlay 2 in YUV420 mode + * on C0 chip revision will hang the LCD until the next SoC reset. */ #include