From patchwork Wed Sep 2 13:07:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Hiremath X-Patchwork-Id: 7111741 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F418ABEEC1 for ; Wed, 2 Sep 2015 13:12:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 31389205FE for ; Wed, 2 Sep 2015 13:12:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EF9620638 for ; Wed, 2 Sep 2015 13:12:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZX7lm-0003KD-H4; Wed, 02 Sep 2015 13:08:06 +0000 Received: from mail-pa0-f46.google.com ([209.85.220.46]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZX7lj-0003IB-PI for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2015 13:08:04 +0000 Received: by padhy1 with SMTP id hy1so11447937pad.1 for ; Wed, 02 Sep 2015 06:07:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=boE7k72BGwdxVMNzAJUCtahi/mGx9D79OCPjUFdSjuQ=; b=QKRfpLJMLxl5DlX68k3O9AvIh4r/16fcGeGhWhCvkAM+eZiTT6FvA6vZTd2BAeOIaA IK1omfUxXGf9weAD63gHwAmCPodLf7/+qVFXoIlq13inIT407CPpU/KF+1sjyAttHpIe CeHYK+jEh/ZBRna+mmsAUlwzDODT52l+tc1bn355EWl1ZtGlSDiqwi6ZxhwjOV+FKbIF IUDTgfvPMEQpB9I6wrDQa8gOb1zjYbltu8XYnP9wBTevaWtZggvR11jY2/WFIDtGPiWq Qk+VuKRZL28SCbJnwDPoUooFcFaQ2ekte8mys2RaVwMVRYa0hZ7xn6ygPFD/OwY9V/Ay nm1Q== X-Gm-Message-State: ALoCoQliWRrDcsfMvmWlTRw/0Vwz7X5h2CCXcxhvuEGKIE++jc03+9dftr/c5cmwKMn9zl2jly42 X-Received: by 10.69.2.227 with SMTP id br3mr55903578pbd.9.1441199260964; Wed, 02 Sep 2015 06:07:40 -0700 (PDT) Received: from [192.168.0.101] ([202.62.93.138]) by smtp.googlemail.com with ESMTPSA id vv2sm21797927pab.21.2015.09.02.06.07.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Sep 2015 06:07:40 -0700 (PDT) Subject: Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn To: Joe Perches References: <1441135454-6902-1-git-send-email-vaibhav.hiremath@linaro.org> <1441135454-6902-3-git-send-email-vaibhav.hiremath@linaro.org> <1441139838.12163.5.camel@perches.com> From: Vaibhav Hiremath Message-ID: <55E6F497.8080300@linaro.org> Date: Wed, 2 Sep 2015 18:37:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441139838.12163.5.camel@perches.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150902_060803_849788_EDAF437B X-CRM114-Status: GOOD ( 17.58 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: > On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: >> Return value would give clear information about the actual root-cause >> of the failure. >> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c >> @@ -455,7 +455,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev) >> >> ret = sdhci_add_host(host); >> if (ret) { >> - dev_err(&pdev->dev, "failed to add host\n"); >> + dev_err(&pdev->dev, "failed to add host ret - %d\n", ret); >> goto err_add_host; >> } >> > > If this is really desirable, there are many other callers of > sdhci_add_host with error messages just like this one. > How about this? If you are ok, I can change it and submit the patch again. UHS */ if (!IS_ERR(mmc->supply.vqmmc)) { Thanks, Vaibhav diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index d2caa60..3a4902c 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -3176,8 +3176,11 @@ int sdhci_add_host(struct sdhci_host *host) mmc->caps |= MMC_CAP_NEEDS_POLL; /* If there are external regulators, get them */ - if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER) + if (mmc_regulator_get_supply(mmc) == -EPROBE_DEFER) { + pr_err("%s: regulator supply unavailable, deferring probe. \n", + mmc_hostname(mmc)); return -EPROBE_DEFER; + } /* If vqmmc regulator and no 1.8V signalling, then there's no