From patchwork Fri Sep 25 16:09:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mason X-Patchwork-Id: 7266261 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1B631BF036 for ; Fri, 25 Sep 2015 16:12:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3CFB7208FA for ; Fri, 25 Sep 2015 16:12:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56CE72069A for ; Fri, 25 Sep 2015 16:12:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZfVZr-0000C2-0A; Fri, 25 Sep 2015 16:10:27 +0000 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZfVZm-0006zj-LP for linux-arm-kernel@lists.infradead.org; Fri, 25 Sep 2015 16:10:23 +0000 Received: from [172.27.0.114] (unknown [83.142.147.193]) (Authenticated sender: shill) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 9B6394B009F; Fri, 25 Sep 2015 18:09:50 +0200 (CEST) Subject: Re: Steps to submit a new arch/arm port To: Arnd Bergmann References: <56001B78.2090001@free.fr> <7559792.th4E1kM5gi@wuerfel> <56056836.4060307@free.fr> <8912441.4NjM1sFKRe@wuerfel> From: Mason Message-ID: <560571CE.1000304@free.fr> Date: Fri, 25 Sep 2015 18:09:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 SeaMonkey/2.35 MIME-Version: 1.0 In-Reply-To: <8912441.4NjM1sFKRe@wuerfel> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150925_091022_902106_B2BD1C47 X-CRM114-Status: GOOD ( 15.46 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , Russell King , Stephen Boyd , Linux ARM Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 25/09/2015 17:52, Arnd Bergmann wrote: > On Friday 25 September 2015 17:28:54 Mason wrote: >> On 25/09/2015 16:11, Arnd Bergmann wrote: >>> On Friday 25 September 2015 15:35:36 Mason wrote: >>>> >>>> So 'default y' enables ARCH_TANGO4 only if ARCH_TANGOX is selected, >>>> right? >>> >>> You should really only have one of the two. >> >> I plan to add ARCH_TANGO5 in a few weeks. So I copied the layout used >> by Samsung for EXYNOSx and TI for OMAPx. > > Better start simple, I wouldn't expect there to be too much code > that is specific to just one of them to warrant a top-level Kconfig > option like on OMAP. I don't understand. If I create only ARCH_TANGO4, then I'll have to move everything around when ARCH_TANGO5 shows up... >>>> It will build, but it won't run! My port uses the TWD for clockevents, >>>> and smp_twd.c is only compiled if HAVE_ARM_TWD. So I must set SMP. >>> >>> I think this has come up before and should be fixed. Could you >>> send a patch that allows using TWD in uniprocessor configurations? >> >> This was discussed here: >> http://thread.gmane.org/gmane.linux.ports.arm.kernel/389931/focus=15737 >> >> I can re-post the same patch. > > Yes, please include that patch in the series. Just to be sure, we are talking about this patch: Regards. diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 1c5021002fe4..774dc59650c5 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1407,7 +1407,6 @@ config HAVE_ARM_ARCH_TIMER config HAVE_ARM_TWD bool - depends on SMP select CLKSRC_OF if OF help This options enables support for the ARM timer and watchdog unit diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c index 172c6a05d27f..877c1d5ec942 100644 --- a/arch/arm/kernel/smp_twd.c +++ b/arch/arm/kernel/smp_twd.c @@ -388,9 +388,6 @@ static void __init twd_local_timer_of_register(struct device_node *np) { int err; - if (!is_smp() || !setup_max_cpus) - return; - twd_ppi = irq_of_parse_and_map(np, 0); if (!twd_ppi) { err = -EINVAL;