From patchwork Fri Oct 30 09:24:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pankaj Dubey X-Patchwork-Id: 7525761 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DEC41BEEA4 for ; Fri, 30 Oct 2015 09:26:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E74DB20854 for ; Fri, 30 Oct 2015 09:26:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2C8D2084B for ; Fri, 30 Oct 2015 09:26:20 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zs5vF-00061j-Jz; Fri, 30 Oct 2015 09:24:33 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zs5vC-00060X-Cq for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2015 09:24:31 +0000 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NX100ABK0S65VD0@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2015 18:24:06 +0900 (KST) Received: from epcpsbgm2new.samsung.com ( [172.20.52.125]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id F6.C1.05385.63733365; Fri, 30 Oct 2015 18:24:06 +0900 (KST) X-AuditID: cbfee691-f79d66d000001509-f7-563337362150 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 12.43.18629.63733365; Fri, 30 Oct 2015 18:24:06 +0900 (KST) Received: from pankaj.dubey-ubuntu ([107.108.83.158]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NX100E1Q0QX0PL0@mmp1.samsung.com>; Fri, 30 Oct 2015 18:24:06 +0900 (KST) Message-id: <56333731.1000400@samsung.com> Date: Fri, 30 Oct 2015 14:54:01 +0530 From: Pankaj Dubey User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Pavel Fedin Subject: Re: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410 References: <009f01d112dd$fab40830$f01c1890$@samsung.com> In-reply-to: <009f01d112dd$fab40830$f01c1890$@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsWyRsSkVtfM3DjMoPOfmsX8I+dYLfrfLGS1 OPdqJaPF6xeGFv2PXzNbbHp8jdXi8q45bBYzzu9jslh6/SKTxatLq9gsJkxfy2LRuvcIuwOP x5p5axg9Lvf1MnmsXP6FzWPTqk42j81L6j36tqxi9Pi8SS6APYrLJiU1J7MstUjfLoEr4+37 qoI38hXrrjSyNzBeFOti5OSQEDCROPL2NwuELSZx4d56ti5GLg4hgRWMEp8Pr2GEKdo26TAr RGIpo8S56UcYIZzvjBI3Vu1nA6niFdCSuLOsixnEZhFQlVj1by3YWDYBXYkn7+eCxUUFIiTe Xj7JBFEvKPFj8j2wGhGg+vsNV9lBhjIL7GGW6F5xCmgoB4ewgJ3E7Ss+EMv+Mkpc7FrCAhLn FLCS+LhGGaSXWcBM4stLkOtAbHmJzWveMoPUSwi0ckgs/tjHCHGQgMS3yYfAeiUEZCU2HWCG +ExS4uCKGywTGMVmITlpFpKxs5CMXcDIvIpRNLUguaA4Kb3IVK84Mbe4NC9dLzk/dxMjMHJP /3s2cQfj/QPWhxgFOBiVeHgDko3ChFgTy4orcw8xmgJdMZFZSjQ5H5ge8kriDY3NjCxMTUyN jcwtzZTEeXWkfwYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYFxXeffxga0Hgk4tnGBTlsx7 +WG+V/+/onNi/+9yWce/XPP4Qu+/2mbWGxbri1kjtjeUz9v3cXa4ndvUq1mfZ3tF3j281uOi 3r7Na2Z1V6bcbo2OECme2emYusPMIis4e6fazD0qBsaZncbFejvSdyrUhs/fKtTTxxD5oNfg RfYnvdpKW31NbSWW4oxEQy3mouJEAKISlP3XAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsVy+t9jAV0zc+Mwg11v5SzmHznHatH/ZiGr xblXKxktXr8wtOh//JrZYtPja6wWl3fNYbOYcX4fk8XS6xeZLF5dWsVmMWH6WhaL1r1H2B14 PNbMW8Pocbmvl8lj5fIvbB6bVnWyeWxeUu/Rt2UVo8fnTXIB7FENjDYZqYkpqUUKqXnJ+SmZ eem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QIcqKZQl5pQChQISi4uV9O0wTQgN cdO1gGmM0PUNCYLrMTJAAwlrGDPevq8qeCNfse5KI3sD40WxLkZODgkBE4ltkw6zQthiEhfu rWfrYuTiEBJYyihxbvoRRgjnO6PEjVX72UCqeAW0JO4s62IGsVkEVCVW/VvLAmKzCehKPHk/ FywuKhAh8fbySSaIekGJH5PvgdWIANXfb7jKDjKUWWAPs0T3ilNAQzk4hAXsJG5f8YFY9pdR 4mLXEhaQOKeAlcTHNcogvcwCZhJfXkJcyiwgL7F5zVvmCYwCs5CsmIWkbBaSsgWMzKsYJVIL kguKk9JzjfJSy/WKE3OLS/PS9ZLzczcxgpPDM+kdjId3uR9iFOBgVOLhDUg2ChNiTSwrrsw9 xCjBwawkwvtOwThMiDclsbIqtSg/vqg0J7X4EKMpMBAmMkuJJucDE1deSbyhsYm5qbGppYmF iZmlkjivvifQHIH0xJLU7NTUgtQimD4mDk6pBsbNkntSIm4u6bj1sblvjcytCbY5c4MtBTOX yRX/23zxktUnlTTDyYw/1905tuCcz5l0rse1BhN/1bZvaekOElGbXcWYvb9f1WjSfcEzBot2 JpZMtrl97eH9Rw5dx754/HfNvrv93/OSRrcqqfn6njOuq7081dOUWWHRuNfkmV52NGMn91WX outKLMUZiYZazEXFiQCJmj5ZJAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151030_022430_598993_9F02412A X-CRM114-Status: GOOD ( 21.51 ) X-Spam-Score: -6.9 (------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 'Mark Rutland' , devicetree@vger.kernel.org, 'Krzysztof Kozlowski' , 'linux-samsung-soc' , 'Pawel Moll' , 'Ian Campbell' , linux-kernel@vger.kernel.org, 'Rob Herring' , 'Kukjin Kim' , 'Kumar Gala' , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Pavel, On Friday 30 October 2015 12:11 PM, Pavel Fedin wrote: > Hello! > >> -----Original Message----- >> From: linux-samsung-soc-owner@vger.kernel.org [mailto:linux-samsung-soc-owner@vger.kernel.org] >> On Behalf Of Pankaj Dubey >> Sent: Thursday, October 29, 2015 8:28 PM >> To: Pavel Fedin >> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc; >> linux-kernel@vger.kernel.org; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; >> Kukjin Kim; Krzysztof Kozlowski >> Subject: Re: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410 >> >> Hi Pavel, >> >> On 29 October 2015 at 18:12, Pavel Fedin wrote: >>> This machine uses own SoC device tree file, add missing part. >>> >>> Signed-off-by: Pavel Fedin >>> --- >>> arch/arm/boot/dts/exynos5410.dtsi | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi >>> index 4603356..da6a8fa0e 100644 >>> --- a/arch/arm/boot/dts/exynos5410.dtsi >>> +++ b/arch/arm/boot/dts/exynos5410.dtsi >>> @@ -101,6 +101,15 @@ >>> reg = <0x10000000 0x100>; >>> }; >>> >>> + sromc: sromc@12250000 { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges; >>> + >> >> We do not need to specify these three properties as they are already >> present in parent node "soc". > > We do, otherwise dtc complains about defaults of #address-cells = 2 and #size-cells=1, and without empty "ranges" subnode's resources are not correctly translated. > First of all this patch will not give this error. So this part should not be a part of this patch. You should be getting above error after applying v4 4/4 "ARM: dts: Add Ethernet chip to SMDK5410". So if its failing for ethernet subnode, you can move this address-cells and size-cells in dts file just above ethernet node as shown below: index 311e7be..d69981d 100644 And another question still remains open, we can't just like that change "smsc,lan9115" binding by adding samsung specific properties. If you want to do and there is no other way, you need to update DT binding of "smsc,lan9115" and get it reviewed. Probably you can check suggestions from Krzysztof, where he pointed out some hint on how other places this is getting used. Thanks, Pankaj Dubey >> >>> + compatible = "samsung,exynos-srom"; >>> + reg = <0x12250000 0x14>; >>> + }; >>> + >>> pmu_system_controller: system-controller@10040000 { >>> compatible = "samsung,exynos5410-pmu", "syscon"; >>> reg = <0x10040000 0x5000>; >>> @@ -133,6 +142,12 @@ >>> <10 &gic 0 130 0>, >>> <11 &gic 0 131 0>; >>> }; >>> + >>> + arch_timer { >>> + compatible = "arm,armv7-timer"; >>> + clock-frequency = <24000000>; >>> + }; >>> + >> >> This change should not be part of this patch. > > Ooops, thank you very much, this should not have been here at all. This is a leftover from my experiments, i was tracing DT parsing code and added it just for test, to see why timer gets probed as a subnode. > Just forgot to remove it afterwards and it slipped into the patch. > > Kind regards, > Pavel Fedin > Expert Engineer > Samsung Electronics Research center Russia > > --- a/arch/arm/boot/dts/exynos5410-smdk5410.dts +++ b/arch/arm/boot/dts/exynos5410-smdk5410.dts @@ -95,6 +95,9 @@ }; &sromc { + #address-cells = <1>; + #size-cells = <1>; + ranges; pinctrl-names = "default"; pinctrl-0 = <&srom_ctl>, <&srom_ebi>;