From patchwork Fri Nov 6 17:55:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Shi X-Patchwork-Id: 7570331 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 09BBAC05C6 for ; Fri, 6 Nov 2015 17:58:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3B92820715 for ; Fri, 6 Nov 2015 17:58:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6560220626 for ; Fri, 6 Nov 2015 17:58:22 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZulFL-0000tl-Tb; Fri, 06 Nov 2015 17:56:19 +0000 Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZulFI-0000qA-Tg for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2015 17:56:18 +0000 Received: by pasz6 with SMTP id z6so133513587pas.2 for ; Fri, 06 Nov 2015 09:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=zC1zfrgCdvDHX/BHQan2lj2d3lmgsFa/sm6IZIy/R60=; b=uyAoO/opj5wBLlrz6S3IvlAMDZ7Ah5F3sxI36Pf6xqA4eCFkw2NfYsVab423A3H+1n SZvtAiRQZkjLvyn0E7NG4RAWgAhbVS1l3awGWVAgeWb1YKuAr82EMDo7quXq0Kl+k+E/ RupkGHycFLVSAxQQ6cetTSHI0lnoD23yWfeRTEo7fK8lN6flDxyD6jMZNcHvvSxIIibb 70rDi8aIsuEC27U7s4KKSfNqZcljdkHZKHYi82MX2w/GR/1HyVpx5e8sL6Xm4EVWaprL 7SLCFqscDZylXEAGmZ8GNXrJoTh6/c/4vAu5faljc2ZTE8oU2nJYfoBVIP4mxSAzCtL1 JnsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=zC1zfrgCdvDHX/BHQan2lj2d3lmgsFa/sm6IZIy/R60=; b=Ow3Ol7g+omIMey9oIPZYMvoGvKKGwoe4D8ag1F4HM9afsqBKIhGtqgOcOpJr40xk5Z bKq0LHj76p66E5YYQhXI7Ce8L8LiKRFg83E9ZfpdT7cua/ZrzLfJBoHOwMXeiaCu9+XH YJNIHkZbo6mbBe3fA+mTzAfJKHMMJvEzhgtp3LXsQHjhMtdYIJsxxU9cbpOYuTVX1rPc 82h9Yh3IG1IUNSVKOsA6n3ciIfSWW3dTcIRBw9yQVuvLKrTQ8KP7w8lt3VhHBUd3s5nM fojJ5CwD/6ckJqiqtqlghJQNvYdRMh/Fo/fsEnxEdOiRTXCXn1Vb0Q5WjCY56SR9St3r +ArQ== X-Gm-Message-State: ALoCoQk27VlMZgl6njagUULLkwzmsgyfbjNLfsVCtqId2u1jA0Ko117jwkj1TteZVpYlKKT86Rrk X-Received: by 10.68.200.103 with SMTP id jr7mr19630602pbc.77.1446832555707; Fri, 06 Nov 2015 09:55:55 -0800 (PST) Received: from [147.11.216.210] (unknown-216-210.windriver.com. [147.11.216.210]) by smtp.googlemail.com with ESMTPSA id im9sm1277178pbc.1.2015.11.06.09.55.54 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 06 Nov 2015 09:55:54 -0800 (PST) Message-ID: <563CE9AA.8050905@linaro.org> Date: Fri, 06 Nov 2015 09:55:54 -0800 From: "Shi, Yang" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Catalin Marinas Subject: Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option References: <1446658671-16238-1-git-send-email-yang.shi@linaro.org> <20151106123008.GK6087@arm.com> <20151106125002.GA8116@leverpostej> <20151106162109.GZ7637@e104818-lin.cambridge.arm.com> <20151106162538.GU6087@arm.com> <563CE21A.6060803@linaro.org> <20151106173558.GC7637@e104818-lin.cambridge.arm.com> <563CE5BB.2080701@linaro.org> <20151106175119.GD7637@e104818-lin.cambridge.arm.com> In-Reply-To: <20151106175119.GD7637@e104818-lin.cambridge.arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151106_095616_999742_30699CE2 X-CRM114-Status: GOOD ( 18.70 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linaro-kernel@lists.linaro.org, Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 11/6/2015 9:51 AM, Catalin Marinas wrote: > On Fri, Nov 06, 2015 at 09:39:07AM -0800, Shi, Yang wrote: >> On 11/6/2015 9:35 AM, Catalin Marinas wrote: >>> On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: >>>> On 11/6/2015 8:25 AM, Will Deacon wrote: >>>>> However, the patch would allow one to >>>>> disable FRAME_POINTERS (not sure it has any effect on the aarch64 gcc >>>>> though). >>>> >>>> No, it doesn't. Actually, FRAME_POINTER could be disabled regardless of the >>>> patch. >>> >>> In which case I suggest that we always select it just as a clearer >>> statement that the feature cannot be disabled (and you never know what >>> the compiler people decide to do in the future). >> >> Do you mean select FRAME_POINTER in ARCH_WANT_FRAME_POINTERS? >> >> Yes, we could, but this may cause other architectures which select >> ARCH_WANT_FRAME_POINTERS to have FRAME_POINTER selected too. > > This would have been the ideal option, something like: > > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -322,7 +322,7 @@ config ARCH_WANT_FRAME_POINTERS > help > > config FRAME_POINTER > - bool "Compile the kernel with frame pointers" > + bool "Compile the kernel with frame pointers" if !ARCH_WANT_FRAME_POINTERS > depends on DEBUG_KERNEL && \ > (CRIS || M68K || FRV || UML || \ > AVR32 || SUPERH || BLACKFIN || MN10300 || METAG) || \ > > But, as you said, we would need to check the other architectures > selecting ARCH_WANT_FRAME_POINTERS. How about: If other architectures want the same behavior, they could easily append to the is statement. If all arches which selects ARCH_WANT_FRAME_POINTERS, the if statement could be just removed. Yang > > In the meantime: > > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -27,6 +27,7 @@ config ARM64 > select CPU_PM if (SUSPEND || CPU_IDLE) > select DCACHE_WORD_ACCESS > select EDAC_SUPPORT > + select FRAME_POINTER > select GENERIC_ALLOCATOR > select GENERIC_CLOCKEVENTS > select GENERIC_CLOCKEVENTS_BROADCAST > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1d1521c..709255a 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -319,6 +319,7 @@ config DEBUG_SECTION_MISMATCH # config ARCH_WANT_FRAME_POINTERS bool + select FRAME_POINTER if ARM64 help config FRAME_POINTER