From patchwork Wed Feb 17 16:48:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Murzin X-Patchwork-Id: 8341521 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 65D019F399 for ; Wed, 17 Feb 2016 16:59:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8374E203DC for ; Wed, 17 Feb 2016 16:59:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ACBA203AE for ; Wed, 17 Feb 2016 16:59:37 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aW5QT-000818-Tb; Wed, 17 Feb 2016 16:58:05 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aW5Hv-0006An-6L for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2016 16:49:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DA7A83A1; Wed, 17 Feb 2016 08:48:03 -0800 (PST) Received: from [10.1.87.55] (e103136-lin.cambridge.arm.com [10.1.87.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 250E93F21A; Wed, 17 Feb 2016 08:48:51 -0800 (PST) Message-ID: <56C4A46C.50506@arm.com> Date: Wed, 17 Feb 2016 16:48:44 +0000 From: Vladimir Murzin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Arnd Bergmann Subject: Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 References: <1455617295-23736-1-git-send-email-vladimir.murzin@arm.com> <1455617295-23736-10-git-send-email-vladimir.murzin@arm.com> <7562697.iiO7rmWd7c@wuerfel> <56C349E6.2000002@arm.com> In-Reply-To: <56C349E6.2000002@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160217_084916_371489_5F3A2FEA X-CRM114-Status: GOOD ( 14.84 ) X-Spam-Score: -6.9 (------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, gregkh@linuxfoundation.org, daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com, robh+dt@kernel.org, linux-serial@vger.kernel.org, galak@codeaurora.org, u.kleine-koenig@pengutronix.de, tglx@linutronix.de, linux-api@vger.kernel.org, jslaby@suse.cz, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 16/02/16 16:10, Vladimir Murzin wrote: > On 16/02/16 11:01, Arnd Bergmann wrote: >> On Tuesday 16 February 2016 10:08:14 Vladimir Murzin wrote: >>> + >>> + ethernet@40200000 { >>> + compatible = "smsc,lan9220", "smsc,lan9115"; >>> + reg = <0x40200000 0x10000>; >>> + interrupts = <13>; >>> + interrupt-parent = <&nvic>; >>> + smsc,irq-active-high; >>> + }; >>> +}; >>> + >>> >> >> This node seems slightly misplaced. Is there some external bus interface >> that this is connected to? The address suggests that it should be somewhere >> below the /soc node, and you probably want to list the external bus >> interface with a "ranges" property that identifies the addresses visibile >> there, and put the external chip under there. >> > > I might messed it up since the MAC/PHY connects to the same 16-bit > interface as the 16MB PSRAM external memory and both connected via AHB. > > Not sure how it should be expressed, so some help form DT camp would be > appreciated. Arnd, Does following fixup address your point on where/how ethernet node should be placed? Cheers Vladimir > > Cheers > Vladimir > >> Arnd >> >> >> > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > diff --git a/arch/arm/boot/dts/mps2-an385.dts b/arch/arm/boot/dts/an385.dts index 976f86d..50c8d24 100644 --- a/arch/arm/boot/dts/mps2-an385.dts +++ b/arch/arm/boot/dts/mps2-an385.dts @@ -63,14 +63,10 @@ device_type = "memory"; reg = <0x21000000 0x1000000>; }; +}; - ethernet@40200000 { - compatible = "smsc,lan9220", "smsc,lan9115"; - reg = <0x40200000 0x10000>; - interrupts = <13>; - interrupt-parent = <&nvic>; - smsc,irq-active-high; - }; +&mb { + ranges = <0 0x40200000 0x10000>; }; &uart0 { diff --git a/arch/arm/boot/dts/mps2.dtsi b/arch/arm/boot/dts/mps2.dtsi index 5d2c539..1673472 100644 --- a/arch/arm/boot/dts/mps2.dtsi +++ b/arch/arm/boot/dts/mps2.dtsi @@ -223,5 +223,21 @@ default-state = "off"; }; }; + + }; + + mb: smb { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + ethernet@0 { + compatible = "smsc,lan9220", "smsc,lan9115"; + reg = <0x0 0x10000>; + interrupts = <13>; + interrupt-parent = <&nvic>; + smsc,irq-active-high; + }; }; };