From patchwork Fri Apr 15 09:46:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sekhar Nori X-Patchwork-Id: 8846871 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 672FEC0553 for ; Fri, 15 Apr 2016 09:48:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4E79C202F0 for ; Fri, 15 Apr 2016 09:48:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 842CF20274 for ; Fri, 15 Apr 2016 09:48:19 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ar0L7-0001Dh-II; Fri, 15 Apr 2016 09:47:01 +0000 Received: from bear.ext.ti.com ([192.94.94.41]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ar0L4-00016c-8y for linux-arm-kernel@lists.infradead.org; Fri, 15 Apr 2016 09:46:59 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id u3F9kbiE018770; Fri, 15 Apr 2016 04:46:37 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id u3F9kbal032509; Fri, 15 Apr 2016 04:46:37 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.224.2; Fri, 15 Apr 2016 04:46:36 -0500 Received: from [172.24.190.171] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id u3F9kZpN004485; Fri, 15 Apr 2016 04:46:36 -0500 Subject: Re: [PATCH] ARM: davinci_all_defconfig: enable CONFIG_FHANDLE To: Kevin Hilman References: <1460023562-7907-1-git-send-email-nsekhar@ti.com> <7h37qvn4v5.fsf@baylibre.com> <570B7C89.9030200@ti.com> From: Sekhar Nori Message-ID: <5710B87A.7060201@ti.com> Date: Fri, 15 Apr 2016 15:16:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <570B7C89.9030200@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160415_024658_419378_55D11344 X-CRM114-Status: GOOD ( 12.23 ) X-Spam-Score: -7.9 (-------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM Mailing List Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Monday 11 April 2016 03:59 PM, Sekhar Nori wrote: > On Saturday 09 April 2016 03:24 AM, Kevin Hilman wrote: >> Sekhar Nori writes: >> >>> CONFIG_FHANDLE is required by systemd, which is the >>> default init system in more and more distributions. >> >> There's a bunch more options required for basic systemd support also[1], >> so those should probably be added with the changelog referencing the >> source[1] > > Good point. Will send a v2. I looked at this bit more closely. CONFIG_EPOLL, CONFIG_SIGNALFD, and CONFIG_TIMERFD are all default y and so actually get removed when the next 'make savedefconfig' syncup will be done. Same thing for PROC_FS and SYSFS. Looking at the list of required options, FHANDLE is the only one which needs to get enabled explicitly. Also, CONFIG_INOTIFY is actually a stale entry that can be removed. Based on this, I think the updated patch can be: ---8<--- From: Sekhar Nori Date: Fri, 15 Apr 2016 14:19:26 +0530 Subject: [PATCH] ARM: davinci_all_defconfig: support systemd CONFIG_FHANDLE is required by systemd[1], which is the default init system in more and more distributions. So lets enable it for DaVinci platforms as well. While at it, remove stale entry CONFIG_INOTIFY=y [1] https://github.com/systemd/systemd/blob/master/README#L37 Signed-off-by: Sekhar Nori Acked-by: Kevin Hilman --- arch/arm/configs/davinci_all_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig index c5bccd9d010e..776fd8ad792f 100644 --- a/arch/arm/configs/davinci_all_defconfig +++ b/arch/arm/configs/davinci_all_defconfig @@ -2,6 +2,7 @@ CONFIG_EXPERIMENTAL=y # CONFIG_SWAP is not set CONFIG_SYSVIPC=y CONFIG_POSIX_MQUEUE=y +CONFIG_FHANDLE=y CONFIG_IKCONFIG=y CONFIG_IKCONFIG_PROC=y CONFIG_LOG_BUF_SHIFT=14 @@ -188,7 +189,6 @@ CONFIG_TI_EDMA=y CONFIG_EXT2_FS=y CONFIG_EXT3_FS=y CONFIG_XFS_FS=m -CONFIG_INOTIFY=y CONFIG_AUTOFS4_FS=m CONFIG_MSDOS_FS=y CONFIG_VFAT_FS=y