CONFIG_ZBOOT_ROM_TEXT and CONFIG_ZBOOT_ROM_BSS in defconfig

Commit Message

Mason May 18, 2016, 8:30 a.m. UTC

On 17/05/2016 17:56, Mason wrote:

> I can submit a patch changing the default from 0 to 0x0, i.e.
> no functional change. The two entries would then disappear
> from defconfigs.

Specifically, this is what I meant:

Comments

Joshua Clayton May 18, 2016, 5:38 p.m. UTC | #1

On Wed, 18 May 2016 10:30:17 +0200
Mason <[e-mail]> wrote:

> On 17/05/2016 17:56, Mason wrote:
> 
> > I can submit a patch changing the default from 0 to 0x0, i.e.
> > no functional change. The two entries would then disappear
> > from defconfigs.  
> 
> Specifically, this is what I meant:
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 70764838dfcc..6831c46a3672 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1823,7 +1823,7 @@ config DEPRECATED_PARAM_STRUCT
>  # TEXT and BSS so we preserve their values in the config files.
>  config ZBOOT_ROM_TEXT
>  	hex "Compressed ROM boot loader base address"
> -	default "0"
> +	default 0x0
>  	help
>  	  The physical address at which the ROM-able zImage is to be
>  	  placed in the target.  Platforms which normally make use of
> @@ -1834,7 +1834,7 @@ config ZBOOT_ROM_TEXT
>  
>  config ZBOOT_ROM_BSS
>  	hex "Compressed ROM boot loader BSS address"
> -	default "0"
> +	default 0x0
>  	help
>  	  The base address of an area of read/write memory in the
> target for the ROM-able zImage which must be available while the
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> [e-mail]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

If the goal is to get rid of the 0x0's in the defconfigs, would it not
be just as effective to drop those so they land at "0"?

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 70764838dfcc..6831c46a3672 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1823,7 +1823,7 @@  config DEPRECATED_PARAM_STRUCT
 # TEXT and BSS so we preserve their values in the config files.
 config ZBOOT_ROM_TEXT
 	hex "Compressed ROM boot loader base address"
-	default "0"
+	default 0x0
 	help
 	  The physical address at which the ROM-able zImage is to be
 	  placed in the target.  Platforms which normally make use of
@@ -1834,7 +1834,7 @@  config ZBOOT_ROM_TEXT
 
 config ZBOOT_ROM_BSS
 	hex "Compressed ROM boot loader BSS address"
-	default "0"
+	default 0x0
 	help
 	  The base address of an area of read/write memory in the target
 	  for the ROM-able zImage which must be available while the