diff mbox

[2/2] ARM: dts: Use architected timer on Exynos 5410

Message ID 57f3491726014e3817bdf9988b1aa30436b45e00.1444119342.git.p.fedin@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Pavel Fedin Oct. 6, 2015, 8:24 a.m. UTC 
This switches the kernel to timer accesses using CP15, allowing to use
KVM virtualization.

Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
---
 arch/arm/boot/dts/exynos5410.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Chanwoo Choi Oct. 6, 2015, 8:33 a.m. UTC | #1 
Hi Pavel,

On 2015? 10? 06? 17:24, Pavel Fedin wrote:
> This switches the kernel to timer accesses using CP15, allowing to use
> KVM virtualization.
> 
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5410.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
> index d8de015..c14f100 100644
> --- a/arch/arm/boot/dts/exynos5410.dtsi
> +++ b/arch/arm/boot/dts/exynos5410.dtsi
> @@ -138,6 +138,17 @@
>  						<10 &gic 0 130 0>,
>  						<11 &gic 0 131 0>;
>  			};
> +
> +			arch_timer {
> +				compatible = "arm,armv7-timer";
> +				interrupt-parent = <&gic>;

You don't need to add 'interrupt-parent' because exynos5410.dtsi already includes
it on top.

> +				interrupts = <1 13 0xf08>,
> +						<1 14 0xf08>,
> +						<1 11 0xf08>,
> +						<1 10 0xf08>;
> +				clock-frequency = <24000000>;
> +			};
> +
>  		};
>  
>  		sysram@02020000 {
> 

Thanks,
Chanwoo Choi
Pavel Fedin Oct. 6, 2015, 8:49 a.m. UTC | #2 
Hello!

> > +
> > +			arch_timer {
> > +				compatible = "arm,armv7-timer";
> > +				interrupt-parent = <&gic>;
> 
> You don't need to add 'interrupt-parent' because exynos5410.dtsi already includes
> it on top.

 I do, because otherwise it tries to use interrupt-map, written for MCT (which is specified as interrupt-parent for its node), and looks like interrupt-map specifies totally different things.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
index d8de015..c14f100 100644
--- a/arch/arm/boot/dts/exynos5410.dtsi
+++ b/arch/arm/boot/dts/exynos5410.dtsi
@@ -138,6 +138,17 @@ 
 						<10 &gic 0 130 0>,
 						<11 &gic 0 131 0>;
 			};
+
+			arch_timer {
+				compatible = "arm,armv7-timer";
+				interrupt-parent = <&gic>;
+				interrupts = <1 13 0xf08>,
+						<1 14 0xf08>,
+						<1 11 0xf08>,
+						<1 10 0xf08>;
+				clock-frequency = <24000000>;
+			};
+
 		};
 
 		sysram@02020000 {