From patchwork Mon Aug 7 11:02:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 9885043 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 85D6760363 for ; Mon, 7 Aug 2017 11:04:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79B0928610 for ; Mon, 7 Aug 2017 11:04:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E80E2861E; Mon, 7 Aug 2017 11:04:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E100128610 for ; Mon, 7 Aug 2017 11:04:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ShAnoyGXb6gvZsPZC3ud3O1EdcVzgMvspDsKaId7EyI=; b=G99gdwJlw3R3ANEaYinTwh9ftc bmghXhVeSvXzM42968oQMbnsgQTLi+4SqEsd6vOzVlxHKUbfQgkZzDr4n/reowiPa1mN7MWtqjZsV z3j/yVHHVoGZvGnEez1gM5l23INCg7q+4Cjta58QlcvhJAKtvXoTX1g6kOurKtIxrQZv4AYdAPHXb wmyG8WxO1LBKI78RS+hwYDHXZKQnnOfGniW1cvU1GRuuGb/bPtA/qVpgLJSmHb8x6fyUdtb2ixsLm si5qtkwYN8gTwvwvar6K7IFJ8rosTwSt1evNl+uk+g9TkBSSC3IrTjIQyCmBiOZKykccofzgzmcKa aXNwVyEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1defq3-0003R6-BJ; Mon, 07 Aug 2017 11:04:47 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1defns-000142-KW for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2017 11:02:36 +0000 Received: by mail-wm0-x244.google.com with SMTP id d40so602741wma.3 for ; Mon, 07 Aug 2017 04:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=WwlyiBoAO5zWgSRD3ZHFKuhIxhLtvkrisDTlWMg9NRQ=; b=T9Kcp5pzrpfKVQyZIf4AnRb2wfqwCjiPYSHCD4UsjG4znZYt5gkiobOwcLMlSQfLFz eOhn6QnqC6p6m5TAq2XeZvWQRYu1cvGMPhBYd/PdfCHiUxYEiwv0kh6cTzDlpVkbyTjd crl1PivMxYz1HPQUdLJAenMYCDhZqkyJ1j220smCadzIkDy4I6Ale3rYxn0ZPCs7taJ0 hZ7BGhOLa8Jm5syMM+kpq3qyyY37CyKDj9SSiOVA6TjXcExVcyhOnpPnYds+RU3pD/jK mhVbTHI9j1+VJJXDKFCB9OIo2ECITnKxQ0+oqOD+VGHPsMfktaZOAPg2lr8FJMGmWanW +vqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=WwlyiBoAO5zWgSRD3ZHFKuhIxhLtvkrisDTlWMg9NRQ=; b=oLRWNq7AcTRB2sRx8sQRKcNk1j6vuzavLpM7I+7dwJYhjIpOc1VddtO3VEHxHo17hW TaxzjbKkcxcsYEb+t3T8RqvsgNh/JYJnVLVRQTLDa8WXKyZFBuwz4EPGJhAXhrM3qqYo E7bX/L7SoLxd0iabHsWm1llB+I908vaEqKtaxOnnyPn5xNkBAN9h/DSlq5IfiWDGhcoE pRA0L6Gioih8SPFfJ900Oo36NVM4gF2LNk2Kmjr27Wtu4pAYH21u2lhuxcC1dsrWSWJ/ i5v3M4mBpsipktGu5u0L+UUY0QlP7t4k5Docgd4gkXqHtfPa6Yi+MrJsNMTz6Tt08ACE pfpw== X-Gm-Message-State: AHYfb5jui0LBT5vwza5w6o/GtjkSxJcWx+o3Z6fDiKETKy4v4dXvj/GM oqlFpDHUpmhLYGdG X-Received: by 10.28.61.4 with SMTP id k4mr388094wma.148.1502103733358; Mon, 07 Aug 2017 04:02:13 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id f9sm7442063wmf.9.2017.08.07.04.02.12 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 07 Aug 2017 04:02:12 -0700 (PDT) From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu Subject: [PATCH 7/8] gpio: zynq: Fix warnings in the driver Date: Mon, 7 Aug 2017 13:02:00 +0200 Message-Id: <58146421d2af970cedef5fd4b9e1b2d07bd13d6e.1502103715.git.michal.simek@xilinx.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170807_040233_058590_DF448809 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Josh Cartwright , Peter Crosthwaite , Nava kishore Manne , Linus Walleij , linux-gpio@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Steffen Trumtrar , =?UTF-8?q?S=C3=B6ren=20Brinkmann?= MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Nava kishore Manne This patch fixes the below warning -->Block comments should align the * on each line. -->suspect code indent for conditional statements. -->Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Nava kishore Manne Signed-off-by: Michal Simek --- drivers/gpio/gpio-zynq.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index 2d9f27e34d31..26653bf89e58 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -198,10 +198,10 @@ static inline void zynq_gpio_get_bank_pin(unsigned int pin_num, for (bank = 0; bank < gpio->p_data->max_bank; bank++) { if ((pin_num >= gpio->p_data->bank_min[bank]) && (pin_num <= gpio->p_data->bank_max[bank])) { - *bank_num = bank; - *bank_pin_num = pin_num - - gpio->p_data->bank_min[bank]; - return; + *bank_num = bank; + *bank_pin_num = pin_num - + gpio->p_data->bank_min[bank]; + return; } } @@ -751,7 +751,7 @@ static int __maybe_unused zynq_gpio_runtime_resume(struct device *dev) return clk_prepare_enable(gpio->clk); } -static int zynq_gpio_request(struct gpio_chip *chip, unsigned offset) +static int zynq_gpio_request(struct gpio_chip *chip, unsigned int offset) { int ret; @@ -764,7 +764,7 @@ static int zynq_gpio_request(struct gpio_chip *chip, unsigned offset) return ret < 0 ? ret : 0; } -static void zynq_gpio_free(struct gpio_chip *chip, unsigned offset) +static void zynq_gpio_free(struct gpio_chip *chip, unsigned int offset) { pm_runtime_put(chip->parent); }