From patchwork Thu Jan 11 21:04:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 10158549 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 412D5605BA for ; Thu, 11 Jan 2018 21:04:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 304172874F for ; Thu, 11 Jan 2018 21:04:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2460028773; Thu, 11 Jan 2018 21:04:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 69E052874F for ; Thu, 11 Jan 2018 21:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hd/zSvZAJNDO+l20D4UtyrSHxulHjDFGGEN98bX84mM=; b=bFPiYAeuh/cFM0qm0kn8SeP8g nx2qHaw3YO9q/LJ2FYqVpYo6D9mY0yyeg/0pvv7sikE/VSF6r8j4YAfTbfMLP45NkSZ/4lSx1gdpU 4w9OT90WkUZA8wInaEzXBU+SnQVXYXLKYdlhTMzkfqPoW6vnjCYPlbRsFdHigdIF4R+3x3KemmF0b jILPmpjoJAZUXvniuoMVxLyDSQ5LjfZaX5GGroXhVPiE5SKlwWW2snMeQTMxr4iJbek4sxpsO2d2w r1fGBTuGGwMLnL9VsLo8ZpPLtbaOY9fIDIu/iQST8PRbhjpksz8nJec/V0XdiMofm6+rLwpAZVVbD 5tt0xCWTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eZk1k-00010n-Ii; Thu, 11 Jan 2018 21:04:44 +0000 Received: from vern.gendns.com ([206.190.152.46]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eZk1g-0000yu-DD for linux-arm-kernel@lists.infradead.org; Thu, 11 Jan 2018 21:04:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZSsDbxggfTGITsUHSn48JRNrL2EB55Wpv5gKVVlpAw4=; b=gW83dN8hUNm10OP5qRrUJEi6ZS llhWc9SOzDHoQh7SUTSHmuaP36kBnyeC7yyIetn0zpt6ctkB1CZ/NRUdW/I/fOuCTVKgYtbLV8fAt nsiaJoRUD+644bR3+6pNAqgDMR0M+sZ8JTgoEboQIUkGsaVm3E8DhV4rIwIKG7cBmEGbeK/4JMIu4 XFiENyy7DOZRld/o17cKB5T+RKm0hD6qvS3ApITpTF+EEiKq6S6c51ea4UCq9xWM+bl16keZClnSp w4ra8linY1izT29a5b3z6NAkBd+BrRQWn1vc33Vsc7VX0P70Uwy2WZ9nEtNqATvDYrOnod449820G QEh341Rw==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:37442 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1eZk1F-003Jvq-6L; Thu, 11 Jan 2018 16:04:13 -0500 Subject: Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks To: Adam Ford References: <1515377863-20358-1-git-send-email-david@lechnology.com> <1515377863-20358-2-git-send-email-david@lechnology.com> <22409e49-5c14-4068-b137-7535afaf90d7@lechnology.com> <0f90b5f7-f21e-5f81-1154-9a815bbb786d@ti.com> <5aacc350-6236-2e4f-35bb-a681fc9d47e7@ti.com> <40501635-6f5b-20c9-f8bc-d17e26b58426@lechnology.com> From: David Lechner Message-ID: <5832fd62-16aa-e167-7e52-2ce493e33cdc@lechnology.com> Date: Thu, 11 Jan 2018 15:04:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180111_130440_509406_30D9ED42 X-CRM114-Status: GOOD ( 18.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Kevin Hilman , Sekhar Nori , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, Rob Herring , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 01/11/2018 02:58 PM, Adam Ford wrote: > On Thu, Jan 11, 2018 at 2:04 PM, David Lechner wrote: >> On 01/11/2018 12:50 PM, Adam Ford wrote: >>> >>> On Thu, Jan 11, 2018 at 12:29 PM, David Lechner >>> wrote: >>>> >>>> If removing the "clk_ignore_unused" option causes the board to not boot, >>>> then we still have problems that need to be fixed, so please also test >>>> without this option. >>> >>> >>> Without this option, it still does not boot. Without device tree it >>> hangs after: >>> >>> [snip] >>> >>> NET: Registered protocol family 17 >>> Loading compiled-in X.509 certificates >>> console [netcon0] enabled >>> netconsole: network logging started >>> davinci_emac davinci_emac.1: using random MAC addr: 5e:38:1a:1f:4f:77 >>> mmc0: host does not support reading read-only switch, assuming >>> write-enable >>> hctosys: unable to open rtc device (rtc0) >>> mmc0: new high speed SDHC card at address b368 >>> >>> >>> With device tree it hangs after: >>> >>> [snip] >>> mmc0: host does not support reading read-only switch, assuming >>> write-enable >>> mmc0: new high speed SDHC card at address b368 >>> mmcblk0: mmc0:b368 00000 3.75 GiB >>> mmcblk0: p1 p2 >>> pca953x 0-0020: 0-0020 supply vcc not found, using dummy regulator >>> pca953x 0-0020: failed reading register >>> pca953x: probe of 0-0020 failed with error -121 >>> console [netcon0] enabled >>> netconsole: network logging started >>> davinci_emac 1e20000.ethernet: incompatible machine/device type for >>> reading mac address >>> hctosys: unable to open rtc device (rtc0) >>> >>> >> >> Please try this change: >> >> diff --git a/drivers/clk/davinci/psc-da850.c >> b/drivers/clk/davinci/psc-da850.c >> index 3fd6b49..a526cc2 100644 >> --- a/drivers/clk/davinci/psc-da850.c >> +++ b/drivers/clk/davinci/psc-da850.c >> @@ -17,7 +17,7 @@ static const struct davinci_psc_clk_info da850_psc0_info[] >> __initconst = { >> LPSC(0, 0, tpcc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >> LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >> LPSC(2, 0, tptc1, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >> - LPSC(3, 0, aemif, pll0_sysclk3, 0), >> + LPSC(3, 0, aemif, pll0_sysclk3, LPSC_ALWAYS_ENABLED), >> LPSC(4, 0, spi0, pll0_sysclk2, 0), >> LPSC(5, 0, mmcsd0, pll0_sysclk2, 0), >> LPSC(6, 0, aintc, pll0_sysclk4, LPSC_ALWAYS_ENABLED), >> >> >> >> If that does not work, try adding LPSC_ALWAYS_ENABLED to all of the clocks >> in this file and then eliminate them one by one until you find which one is >> preventing boot. >> > Unfortunately, that didn't work. I switch all the entries in both > tables that had a 0 to LPSC_ALWAYS_ENABLED, but no luck booting. > >> If it still does not boot, there is a similar DIVCLK_ALWAYS_ENABLED flag in >> drivers/clk/davinci/pll-da850.c that you can repeat the exercise with. Add >> DIVCLK_ALWAYS_ENABLED to all of the clocks there and then eliminate it one >> by one until you find the clock that is causing the problem. > > Still no good news. I switched all the entries with a 0 to > DIVCLK_ALWAYS_ENABLED and it still didn't finish booting. > > I wonder if Sekhar Nori might have some suggestions. I didn't look at > the code or try to understand it. I just changed the settings. >> Even if a clock had another flag besides zero, you will need to add LPSC_ALWAYS_ENABLED by or-ing it with the other flag. diff --git a/drivers/clk/davinci/psc-da850.c b/drivers/clk/davinci/psc-da850.c index 3fd6b49..3375df6a1 100644 --- a/drivers/clk/davinci/psc-da850.c +++ b/drivers/clk/davinci/psc-da850.c @@ -17,38 +17,38 @@ static const struct davinci_psc_clk_info da850_psc0_info[] __initconst = { LPSC(0, 0, tpcc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), LPSC(2, 0, tptc1, pll0_sysclk2, LPSC_ALWAYS_ENABLED), - LPSC(3, 0, aemif, pll0_sysclk3, 0), - LPSC(4, 0, spi0, pll0_sysclk2, 0), - LPSC(5, 0, mmcsd0, pll0_sysclk2, 0), + LPSC(3, 0, aemif, pll0_sysclk3, LPSC_ALWAYS_ENABLED), + LPSC(4, 0, spi0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), + LPSC(5, 0, mmcsd0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), LPSC(6, 0, aintc, pll0_sysclk4, LPSC_ALWAYS_ENABLED), LPSC(7, 0, arm_rom, pll0_sysclk2, LPSC_ALWAYS_ENABLED), - LPSC(9, 0, uart0, pll0_sysclk2, 0), - LPSC(13, 0, pruss, pll0_sysclk2, 0), + LPSC(9, 0, uart0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), + LPSC(13, 0, pruss, pll0_sysclk2, LPSC_ALWAYS_ENABLED), LPSC(14, 0, arm, pll0_sysclk6, LPSC_ALWAYS_ENABLED), - LPSC(15, 1, dsp, pll0_sysclk1, LPSC_FORCE | LPSC_LOCAL_RESET), + LPSC(15, 1, dsp, pll0_sysclk1, LPSC_FORCE | LPSC_LOCAL_RESET | LPSC_ALWAYS_ENABLED), { } }; static const struct davinci_psc_clk_info da850_psc1_info[] __initconst = { LPSC(0, 0, tpcc1, pll0_sysclk2, LPSC_ALWAYS_ENABLED), - LPSC(1, 0, usb0, pll0_sysclk2, 0), - LPSC(2, 0, usb1, pll0_sysclk4, 0), - LPSC(3, 0, gpio, pll0_sysclk4, 0), - LPSC(5, 0, emac, pll0_sysclk4, 0), + LPSC(1, 0, usb0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), + LPSC(2, 0, usb1, pll0_sysclk4, LPSC_ALWAYS_ENABLED), + LPSC(3, 0, gpio, pll0_sysclk4, LPSC_ALWAYS_ENABLED), + LPSC(5, 0, emac, pll0_sysclk4, LPSC_ALWAYS_ENABLED), LPSC(6, 0, emif3, pll0_sysclk5, LPSC_ALWAYS_ENABLED), - LPSC(7, 0, mcasp0, async3, 0), - LPSC(8, 0, sata, pll0_sysclk2, LPSC_FORCE), - LPSC(9, 0, vpif, pll0_sysclk2, 0), - LPSC(10, 0, spi1, async3, 0), - LPSC(11, 0, i2c1, pll0_sysclk4, 0), - LPSC(12, 0, uart1, async3, 0), - LPSC(13, 0, uart2, async3, 0), - LPSC(14, 0, mcbsp0, async3, 0), - LPSC(15, 0, mcbsp1, async3, 0), - LPSC(16, 0, lcdc, pll0_sysclk2, 0), - LPSC(17, 0, ehrpwm, async3, 0), - LPSC(18, 0, mmcsd1, pll0_sysclk2, 0), - LPSC(20, 0, ecap, async3, 0), + LPSC(7, 0, mcasp0, async3, LPSC_ALWAYS_ENABLED), + LPSC(8, 0, sata, pll0_sysclk2, LPSC_FORCE | LPSC_ALWAYS_ENABLED), + LPSC(9, 0, vpif, pll0_sysclk2, LPSC_ALWAYS_ENABLED), + LPSC(10, 0, spi1, async3, LPSC_ALWAYS_ENABLED), + LPSC(11, 0, i2c1, pll0_sysclk4, LPSC_ALWAYS_ENABLED), + LPSC(12, 0, uart1, async3, LPSC_ALWAYS_ENABLED), + LPSC(13, 0, uart2, async3, LPSC_ALWAYS_ENABLED), + LPSC(14, 0, mcbsp0, async3, LPSC_ALWAYS_ENABLED), + LPSC(15, 0, mcbsp1, async3, LPSC_ALWAYS_ENABLED), + LPSC(16, 0, lcdc, pll0_sysclk2, LPSC_ALWAYS_ENABLED), + LPSC(17, 0, ehrpwm, async3, LPSC_ALWAYS_ENABLED), + LPSC(18, 0, mmcsd1, pll0_sysclk2, LPSC_ALWAYS_ENABLED), + LPSC(20, 0, ecap, async3, LPSC_ALWAYS_ENABLED), LPSC(21, 0, tptc2, pll0_sysclk2, LPSC_ALWAYS_ENABLED), { } }; diff --git a/drivers/clk/davinci/pll-da850.c b/drivers/clk/davinci/pll-da850.c index 77a7223..f334e69 100644 --- a/drivers/clk/davinci/pll-da850.c +++ b/drivers/clk/davinci/pll-da850.c @@ -22,21 +22,21 @@ static const struct davinci_pll_divclk_info da850_pll0_divclk_info[] __initconst = { - DIVCLK(1, pll0_sysclk1, pll0, DIVCLK_FIXED_DIV), - DIVCLK(2, pll0_sysclk2, pll0, DIVCLK_FIXED_DIV), - DIVCLK(3, pll0_sysclk3, pll0, 0), - DIVCLK(4, pll0_sysclk4, pll0, DIVCLK_FIXED_DIV), - DIVCLK(5, pll0_sysclk5, pll0, 0), - DIVCLK(6, pll0_sysclk6, pll0, DIVCLK_ARM_RATE | DIVCLK_FIXED_DIV), - DIVCLK(7, pll0_sysclk7, pll0, 0), + DIVCLK(1, pll0_sysclk1, pll0, DIVCLK_FIXED_DIV | DIVCLK_ALWAYS_ENABLED), + DIVCLK(2, pll0_sysclk2, pll0, DIVCLK_FIXED_DIV | DIVCLK_ALWAYS_ENABLED), + DIVCLK(3, pll0_sysclk3, pll0, DIVCLK_ALWAYS_ENABLED), + DIVCLK(4, pll0_sysclk4, pll0, DIVCLK_FIXED_DIV | DIVCLK_ALWAYS_ENABLED), + DIVCLK(5, pll0_sysclk5, pll0, DIVCLK_ALWAYS_ENABLED), + DIVCLK(6, pll0_sysclk6, pll0, DIVCLK_ARM_RATE | DIVCLK_FIXED_DIV| DIVCLK_ALWAYS_ENABLED), + DIVCLK(7, pll0_sysclk7, pll0, DIVCLK_ALWAYS_ENABLED), { } }; static const struct davinci_pll_divclk_info da850_pll1_divclk_info[] __initconst = { DIVCLK(1, pll1_sysclk1, pll1, DIVCLK_ALWAYS_ENABLED), - DIVCLK(2, pll1_sysclk2, pll1, 0), - DIVCLK(3, pll1_sysclk3, pll1, 0), + DIVCLK(2, pll1_sysclk2, pll1, DIVCLK_ALWAYS_ENABLED), + DIVCLK(3, pll1_sysclk3, pll1, DIVCLK_ALWAYS_ENABLED), { } };