From patchwork Fri Apr 21 08:06:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mason X-Patchwork-Id: 9692061 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3BEAF60328 for ; Fri, 21 Apr 2017 08:07:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 37BC52022C for ; Fri, 21 Apr 2017 08:07:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 298B5284D1; Fri, 21 Apr 2017 08:07:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B26D32022C for ; Fri, 21 Apr 2017 08:07:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dsm84JK9FeVGpbUvcAPNylSBhYsFo9WvaDb0FamoUrY=; b=HmhJWdJDdolrBD qZZXgr79RCeN4FX5HfpWy5AJ+5W08fni1wdmN1nkquSGF0R2EjrqOKf3tVwFfZu5QwU06R3Jktb6F zW/6zpM+lDTLwLsnXlZksQznH9qKIEMbTrzetVRmjdNkAd/qDTrOyn5teG0OJIR6eRD9SDTDNqq0K 19lZqDN7PbJzwGUJUH0KAtG0GVIQ2dlZ5vzWHCq1Heh7Xk5KfMYRA9YvisdJXLj3hkbSq0zd06th5 T5P+xEmi8DtcuDoy9nJAz9MQBIGzoz1M7IKydK5ux4ZHg8fsxeT5reAmb9WZyJZ8MG75nKBWCGvq5 WypE34aAGBgkvwIeWzIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1d1Tat-0001QO-Be; Fri, 21 Apr 2017 08:07:07 +0000 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d1Tap-0001Mq-U3 for linux-arm-kernel@lists.infradead.org; Fri, 21 Apr 2017 08:07:05 +0000 Received: from [192.168.0.66] (unknown [88.191.210.51]) (Authenticated sender: shill) by smtp2-g21.free.fr (Postfix) with ESMTPSA id A8C472003E8; Fri, 21 Apr 2017 10:06:15 +0200 (CEST) Subject: [PATCH] dmaengine: sun4i: fix invalid argument From: Mason To: Stephen Rothwell , Russell King , Vinod Koul , Dan Williams References: <20170421084033.5c987e13@canb.auug.org.au> <9858a4ed-bdd9-bd6c-d8a4-e9e6bd539904@free.fr> Message-ID: <584a2c53-100b-945b-d665-cef3fa856526@free.fr> Date: Fri, 21 Apr 2017 10:06:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49 MIME-Version: 1.0 In-Reply-To: <9858a4ed-bdd9-bd6c-d8a4-e9e6bd539904@free.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170421_010704_120929_457E180A X-CRM114-Status: UNSURE ( 6.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arm-soc , Emilio Lopez , LKML , Chen-Yu Tsai , linux-next , dmaengine@vger.kernel.org, Maxime Ripard , Linux ARM Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The "pchans_used" field is an unsigned long array. for_each_clear_bit_from() expects an unsigned long pointer, not an array address. $ make C=2 drivers/dma/sun4i-dma.o CHECK drivers/dma/sun4i-dma.c drivers/dma/sun4i-dma.c:241:9: warning: incorrect type in argument 1 (different base types) drivers/dma/sun4i-dma.c:241:9: expected unsigned long const *p drivers/dma/sun4i-dma.c:241:9: got unsigned long ( * )[1] Signed-off-by: Mason --- drivers/dma/sun4i-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c index 57aa227bfadb..f4ed3f17607c 100644 --- a/drivers/dma/sun4i-dma.c +++ b/drivers/dma/sun4i-dma.c @@ -238,7 +238,7 @@ static struct sun4i_dma_pchan *find_and_use_pchan(struct sun4i_dma_dev *priv, } spin_lock_irqsave(&priv->lock, flags); - for_each_clear_bit_from(i, &priv->pchans_used, max) { + for_each_clear_bit_from(i, priv->pchans_used, max) { pchan = &pchans[i]; pchan->vchan = vchan; set_bit(i, priv->pchans_used);