| Message ID | 590a5fbc4f8b552355a93c1002041765352cd1c3.1411662961.git.stefan@agner.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 25, 2014 at 06:37:08PM +0200, Stefan Agner wrote: > Use GPIO support by adding SD card detection configuration and > GPIO pinmux for Colibri's standard GPIO pins. Attach the GPIO > pins to the iomuxc node to get the GPIO pin settings applied. > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > arch/arm/boot/dts/vf610-colibri.dtsi | 9 +++++++++ > arch/arm/boot/dts/vf610-twr.dts | 1 + > arch/arm/boot/dts/vf610.dtsi | 1 + > 3 files changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi > index 0cd8343..efd4322 100644 > --- a/arch/arm/boot/dts/vf610-colibri.dtsi > +++ b/arch/arm/boot/dts/vf610-colibri.dtsi > @@ -31,6 +31,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_esdhc1>; > bus-width = <4>; > + cd-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>; > }; > > &fec1 { > @@ -71,6 +72,14 @@ > > &iomuxc { > vf610-colibri { > + pinctrl_gpio_ext: gpio_ext { > + fsl,pins = < > + VF610_PAD_PTD10__GPIO_89 0x22ed /* EXT_IO_0 */ > + VF610_PAD_PTD9__GPIO_88 0x22ed /* EXT_IO_1 */ > + VF610_PAD_PTD26__GPIO_68 0x22ed /* EXT_IO_2 */ > + >; > + }; > + I'm not sure these GPIOs will be set up at anywhere. To set them up, you need to either have pinctrl_gpio_ext referenced by some client device in its pinctrl-* property or put these pins into hog group (see example in arch/arm/boot/dts/vf610-twr.dts). Shawn > pinctrl_esdhc1: esdhc1grp { > fsl,pins = < > VF610_PAD_PTA24__ESDHC1_CLK 0x31ef > diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts > index 189b697..3fe8a8f 100644 > --- a/arch/arm/boot/dts/vf610-twr.dts > +++ b/arch/arm/boot/dts/vf610-twr.dts > @@ -116,6 +116,7 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_esdhc1>; > bus-width = <4>; > + cd-gpios = <&gpio5 6 GPIO_ACTIVE_LOW>; > status = "okay"; > }; > > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi > index 4d2ec32..467c97e 100644 > --- a/arch/arm/boot/dts/vf610.dtsi > +++ b/arch/arm/boot/dts/vf610.dtsi > @@ -11,6 +11,7 @@ > #include "vf610-pinfunc.h" > #include <dt-bindings/clock/vf610-clock.h> > #include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/gpio/gpio.h> > > / { > aliases { > -- > 2.1.0 >
Am 2014-09-26 03:21, schrieb Shawn Guo: > On Thu, Sep 25, 2014 at 06:37:08PM +0200, Stefan Agner wrote: >> Use GPIO support by adding SD card detection configuration and >> GPIO pinmux for Colibri's standard GPIO pins. Attach the GPIO >> pins to the iomuxc node to get the GPIO pin settings applied. >> >> Signed-off-by: Stefan Agner <stefan@agner.ch> >> --- >> arch/arm/boot/dts/vf610-colibri.dtsi | 9 +++++++++ >> arch/arm/boot/dts/vf610-twr.dts | 1 + >> arch/arm/boot/dts/vf610.dtsi | 1 + >> 3 files changed, 11 insertions(+) >> >> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi >> index 0cd8343..efd4322 100644 >> --- a/arch/arm/boot/dts/vf610-colibri.dtsi >> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi >> @@ -31,6 +31,7 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_esdhc1>; >> bus-width = <4>; >> + cd-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>; >> }; >> >> &fec1 { >> @@ -71,6 +72,14 @@ >> >> &iomuxc { >> vf610-colibri { >> + pinctrl_gpio_ext: gpio_ext { >> + fsl,pins = < >> + VF610_PAD_PTD10__GPIO_89 0x22ed /* EXT_IO_0 */ >> + VF610_PAD_PTD9__GPIO_88 0x22ed /* EXT_IO_1 */ >> + VF610_PAD_PTD26__GPIO_68 0x22ed /* EXT_IO_2 */ >> + >; >> + }; >> + > > I'm not sure these GPIOs will be set up at anywhere. To set them up, > you need to either have pinctrl_gpio_ext referenced by some client > device in its pinctrl-* property or put these pins into hog group (see > example in arch/arm/boot/dts/vf610-twr.dts). > > Shawn > This GPIO's are meant to be used from user space by default. The latest implementation of imx_pmx_gpio_request_enable not only takes care of the muxing, but also applies the whole pad settings. Hence we do not need the pinctrl subsystem to apply it (through pinctrl-* dt properties). I changed this now in v3, in v2 I had still to use the pinctrl-* properties. I like that 3rd version much more, this way the pin only really gets muxed when the user uses it (e.g. we save power because the pad is disabled when the GPIO is not in use). If the pin needs to be in a defined state, then we would have to explicitly configure/enable it through a pinctrl-* properties, but this is not the case for these external GPIO's. -- Stefan >> pinctrl_esdhc1: esdhc1grp { >> fsl,pins = < >> VF610_PAD_PTA24__ESDHC1_CLK 0x31ef >> diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts >> index 189b697..3fe8a8f 100644 >> --- a/arch/arm/boot/dts/vf610-twr.dts >> +++ b/arch/arm/boot/dts/vf610-twr.dts >> @@ -116,6 +116,7 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_esdhc1>; >> bus-width = <4>; >> + cd-gpios = <&gpio5 6 GPIO_ACTIVE_LOW>; >> status = "okay"; >> }; >> >> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi >> index 4d2ec32..467c97e 100644 >> --- a/arch/arm/boot/dts/vf610.dtsi >> +++ b/arch/arm/boot/dts/vf610.dtsi >> @@ -11,6 +11,7 @@ >> #include "vf610-pinfunc.h" >> #include <dt-bindings/clock/vf610-clock.h> >> #include <dt-bindings/interrupt-controller/irq.h> >> +#include <dt-bindings/gpio/gpio.h> >> >> / { >> aliases { >> -- >> 2.1.0 >>
On Fri, Sep 26, 2014 at 09:40:34AM +0200, Stefan Agner wrote: > This GPIO's are meant to be used from user space by default. The latest > implementation of imx_pmx_gpio_request_enable not only takes care of the > muxing, but also applies the whole pad settings. Hence we do not need > the pinctrl subsystem to apply it (through pinctrl-* dt properties). > > I changed this now in v3, in v2 I had still to use the pinctrl-* > properties. I like that 3rd version much more, this way the pin only > really gets muxed when the user uses it (e.g. we save power because the > pad is disabled when the GPIO is not in use). If the pin needs to be in > a defined state, then we would have to explicitly configure/enable it > through a pinctrl-* properties, but this is not the case for these > external GPIO's. Ah, yes, you're right. I was still thinking about the way how it worked before your patch. Patch applied, thanks.
diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi index 0cd8343..efd4322 100644 --- a/arch/arm/boot/dts/vf610-colibri.dtsi +++ b/arch/arm/boot/dts/vf610-colibri.dtsi @@ -31,6 +31,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; bus-width = <4>; + cd-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>; }; &fec1 { @@ -71,6 +72,14 @@ &iomuxc { vf610-colibri { + pinctrl_gpio_ext: gpio_ext { + fsl,pins = < + VF610_PAD_PTD10__GPIO_89 0x22ed /* EXT_IO_0 */ + VF610_PAD_PTD9__GPIO_88 0x22ed /* EXT_IO_1 */ + VF610_PAD_PTD26__GPIO_68 0x22ed /* EXT_IO_2 */ + >; + }; + pinctrl_esdhc1: esdhc1grp { fsl,pins = < VF610_PAD_PTA24__ESDHC1_CLK 0x31ef diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts index 189b697..3fe8a8f 100644 --- a/arch/arm/boot/dts/vf610-twr.dts +++ b/arch/arm/boot/dts/vf610-twr.dts @@ -116,6 +116,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; bus-width = <4>; + cd-gpios = <&gpio5 6 GPIO_ACTIVE_LOW>; status = "okay"; }; diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi index 4d2ec32..467c97e 100644 --- a/arch/arm/boot/dts/vf610.dtsi +++ b/arch/arm/boot/dts/vf610.dtsi @@ -11,6 +11,7 @@ #include "vf610-pinfunc.h" #include <dt-bindings/clock/vf610-clock.h> #include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/gpio/gpio.h> / { aliases {
Use GPIO support by adding SD card detection configuration and GPIO pinmux for Colibri's standard GPIO pins. Attach the GPIO pins to the iomuxc node to get the GPIO pin settings applied. Signed-off-by: Stefan Agner <stefan@agner.ch> --- arch/arm/boot/dts/vf610-colibri.dtsi | 9 +++++++++ arch/arm/boot/dts/vf610-twr.dts | 1 + arch/arm/boot/dts/vf610.dtsi | 1 + 3 files changed, 11 insertions(+)