From patchwork Wed Jul 19 19:24:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grygorii Strashko X-Patchwork-Id: 9853137 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E0D6F602C8 for ; Wed, 19 Jul 2017 19:25:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA91D28438 for ; Wed, 19 Jul 2017 19:25:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CF5BF285F0; Wed, 19 Jul 2017 19:25:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2FA72285DD for ; Wed, 19 Jul 2017 19:25:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9jK7S+XXjjXMOt2hJEBfBTk/NR3zq/5zzSWmhf3ZAig=; b=u+4IXWUpybJ3hF 8YmXjfUIOQN6rYmBuvaTDF7IfzD/LZhxhwGd1ZmQWlmKklUuLekyMdkzigxVygkeDDFw/j2IGHFHP xBE+r9Cug3k/yRskjjR+BnDZJ91DUoJeo3Su+IiTN5Gz2NQeSYd1aH46B3dccnlY4yCsGskuPNbys WnQvkyOuT5Ld2nReqoooQByWbiopzs30cMlNTIEZKlBMG+0cCn00XnKJmYT68ml/SkV3yUas7XjuD n1m2Xr0RM4DaVCeOq5iZUGI0hLJIpyRrz+imAN7vM5qpWKz7GEuOlYsoJ9dutM6qJLfGk6bmcpHTX YrkMliwEDC7LT8VohCbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dXubS-0005cq-Ah; Wed, 19 Jul 2017 19:25:46 +0000 Received: from fllnx209.ext.ti.com ([198.47.19.16]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dXubO-0005bG-GZ for linux-arm-kernel@lists.infradead.org; Wed, 19 Jul 2017 19:25:44 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v6JJOGSg026803; Wed, 19 Jul 2017 14:24:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1500492256; bh=LyU0R5pA5aPbTx6MYHpfYnAKA+/U46iqbua91tAe3AQ=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=yzVGq+S/beXd1SCoD/UrwhoxE74gYTacl+POedXub8S6jQXtDEcNBRSb9+2UIfGap tcAprmIzK3L3gvlI1q6fDamxnFuX80pQWZDPEbNTNgvflgea99dwR+C8CjI9F6XxKU Xh69la1vi63T/N1QUHb0k1MV3DPPEd7VZ6yZFB+o= Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v6JJOAWt010055; Wed, 19 Jul 2017 14:24:11 -0500 Received: from [128.247.59.147] (128.247.59.147) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.294.0; Wed, 19 Jul 2017 14:24:10 -0500 Subject: Re: [PATCH 1/2] net: phy: at803x: Fix RGMII RX and TX clock delays setup To: Marc Gonzalez , Florian Fainelli , Andrew Lunn , Mans Rullgard , Martin Blumenstingl , Fabio Estevam , Zefir Kurtisi , Timur Tabi , Daniel Mack , Sekhar Nori References: <33ed5f4f-9939-dc00-b973-db39c16f2393@sigmadesigns.com> From: Grygorii Strashko Message-ID: <5ea9905f-e74a-4a43-dc5b-883ec9daf030@ti.com> Date: Wed, 19 Jul 2017 14:24:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <33ed5f4f-9939-dc00-b973-db39c16f2393@sigmadesigns.com> Content-Language: en-US X-Originating-IP: [128.247.59.147] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170719_122542_728505_09834A9A X-CRM114-Status: GOOD ( 12.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev , Thibaud Cornic , "David S. Miller" , Linux ARM , Mason Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi On 07/19/2017 10:31 AM, Marc Gonzalez wrote: > The current code supports enabling RGMII RX and TX clock delays. > The unstated assumption is that these settings are disabled by > default at reset, which is not the case. > > RX clock delay is enabled at reset. And TX clock delay "survives" > across SW resets. Thus, if the bootloader enables TX clock delay, > it will remain enabled at reset in Linux. > > Provide disable functions to configure the RGMII clock delays > exactly as specified in the fwspec. > > Signed-off-by: Marc Gonzalez > --- > drivers/net/phy/at803x.c | 32 ++++++++++++++++++++++++-------- > 1 file changed, 24 insertions(+), 8 deletions(-) This patch breaks am335x-evm networking. To restore it I've had to apply below diff: Sry, can't comment here to much - not E-PHY expert. diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts index 200d6ab..9578bdf 100644 --- a/arch/arm/boot/dts/am335x-evm.dts +++ b/arch/arm/boot/dts/am335x-evm.dts @@ -724,12 +724,12 @@ &cpsw_emac0 { phy_id = <&davinci_mdio>, <0>; - phy-mode = "rgmii-txid"; + phy-mode = "rgmii-id"; }; &cpsw_emac1 { phy_id = <&davinci_mdio>, <1>; - phy-mode = "rgmii-txid"; + phy-mode = "rgmii-id"; }; &tscadc {