From patchwork Tue Jun 23 14:23:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 11620779 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0364C60D for ; Tue, 23 Jun 2020 14:25:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D02AF2072E for ; Tue, 23 Jun 2020 14:25:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zXp55uuT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernelci-org.20150623.gappssmtp.com header.i=@kernelci-org.20150623.gappssmtp.com header.b="APdLuZED" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D02AF2072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernelci.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:From:To:Subject:MIME-Version:Date:Message-ID: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=vmUUNsC9JRIjKFNEJ7TrZaT3iYNOsYDx63C8Jk+rUcY=; b=zXp55uuTr1ye1uzmUGAStxq/vA auDw4mpxvNqmECnZlh3IfpCZdgLA6NIa/7dKNZUYYno4omorSXqyOz5AH1QlgwayCq7C7nZR1bTNk PLPWuAkOX856JGQyRmT85kYSS8K63Q6AXcpHkVJnuDJKSuQJF3YLwwZgZXYkCFd0LeLZhe2LjQNfI tm5h2Nkf6DmihL97I/N2xoPAllkqoh5YOQd4zYy86WY6mtG1oovjdfqZI8PiFLBxiAzXTP3G6L5Kx VHUVyOcU0aadRTqXcx4yW3N1R344aHLoOdR+8IUAp5bictlrp9MHs3i9z1ODH/oWfmGTaxx8mO6Nr yrD6SYMA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jnjpa-0002mk-Lm; Tue, 23 Jun 2020 14:23:22 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jnjpX-0002lK-OM for linux-arm-kernel@lists.infradead.org; Tue, 23 Jun 2020 14:23:20 +0000 Received: by mail-pl1-x641.google.com with SMTP id g17so2605plq.12 for ; Tue, 23 Jun 2020 07:23:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=qFlOj3wSSSINOzv90EaLpuVFFjebeMk4KVdQXi9/yNc=; b=APdLuZEDWd1OMGhDoMAaRMtSUxrpGGMQdnAaFCMsfp7ovPdt/FNXP3tG9r+eJj0kke CshHHxHrhRewRr0kn6wukWaOwPFKu1dh1mThMyIWPARfIf6kKEgseYCaOZpURqNL2VVh /j7L+IsrUaXRmIDOUrgJu+FLxfAyLxlXPmzGbN2t/zRFzanEpYP0ztX3sgM0yLaxK8qz KIwI2T01wURJcmv0UJFT8G4T/+PkYbHaOFTGNBXiS+9w4g6xEKwhgySmhuS1Lsi6YbHb ntNb/UrAQOTOhMpkEy6S6Q3I41963Ytvvp2DuTsi/4GHHl9quM6VGZAnoZX0tp4/+9kO vpqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=qFlOj3wSSSINOzv90EaLpuVFFjebeMk4KVdQXi9/yNc=; b=TE3YzNCEMd5DHhwYoJJ5JyxlglkZ1GYrAj8E5IxDYLm2eTlASzK2x8EPUH80VKOY9C I2BRFhre6k4xX/xyvsD33ysYQ/3ZEODAA6qv3E9jrAN0J7wJPHroTMm38iN1c3YYKDYt GwANoS5X3pgxkKCzVMbiXtIGJt0YbWev2j3amMRppG4Rlaeo42Yp3UVSHOLRKwSCSCcN LD7Vq7UOy8kZX9lT7rIj58QnHK6w5fjdNwsUW+wVBwSdZamrwUGv8kHp3Hy+T16AdxQC kEKvvRbTW0wSUn+9vepLS/aSMvtJKH3/Js41avjzYZ/RVY+VmUlgBYiK/BCSAUmESVcO JIUA== X-Gm-Message-State: AOAM533unEqCNBYIR6ZQpyPK3tkCwRnUXgMwX6OzUVCl1vk0vXP6MOD9 I++MhCNoxgSgUfiudQfCq9ITRg== X-Google-Smtp-Source: ABdhPJxrmexBOtjGKXRnBtb20pi39k+MESf7jEYVkXYd2xA5n2oHhcYZyMhHzfr8sMsSWcTkevcFOw== X-Received: by 2002:a17:90b:796:: with SMTP id l22mr21618759pjz.45.1592922196445; Tue, 23 Jun 2020 07:23:16 -0700 (PDT) Received: from kernelci-production.internal.cloudapp.net ([52.250.1.28]) by smtp.gmail.com with ESMTPSA id y7sm2814095pjm.54.2020.06.23.07.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 07:23:15 -0700 (PDT) Message-ID: <5ef21053.1c69fb81.b80ec.8649@mx.google.com> Date: Tue, 23 Jun 2020 07:23:15 -0700 (PDT) MIME-Version: 1.0 X-Kernelci-Report-Type: bisect X-Kernelci-Branch: for-next X-Kernelci-Lab-Name: lab-baylibre X-Kernelci-Tree: krzysztof X-Kernelci-Kernel: v5.8-rc1-14-gd6fe116541b7 Subject: krzysztof/for-next bisection: baseline.dmesg.crit on bcm2837-rpi-3-b To: "kernelci.org bot" , gtucker@collabora.com, Krzysztof Kozlowski , Guillaume Tucker From: "kernelci.org bot" X-Spam-Note: CRM114 invocation failed X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:641 listed in] [list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kukjin Kim , linux-samsung-soc@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * * * If you do send a fix, please include this trailer: * * Reported-by: "kernelci.org bot" * * * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * krzysztof/for-next bisection: baseline.dmesg.crit on bcm2837-rpi-3-b Summary: Start: d6fe116541b7 Merge branch 'next/soc' into for-next Plain log: https://storage.kernelci.org/krzysztof/for-next/v5.8-rc1-14-gd6fe116541b7/arm64/defconfig+CONFIG_RANDOMIZE_BASE=y/gcc-8/lab-baylibre/baseline-bcm2837-rpi-3-b.txt HTML log: https://storage.kernelci.org/krzysztof/for-next/v5.8-rc1-14-gd6fe116541b7/arm64/defconfig+CONFIG_RANDOMIZE_BASE=y/gcc-8/lab-baylibre/baseline-bcm2837-rpi-3-b.html Result: 5b17a04addc2 ARM: exynos: clear L310_AUX_CTRL_FULL_LINE_ZERO in default l2c_aux_val Checks: revert: PASS verify: PASS Parameters: Tree: krzysztof URL: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git Branch: for-next Target: bcm2837-rpi-3-b CPU arch: arm64 Lab: lab-baylibre Compiler: gcc-8 Config: defconfig+CONFIG_RANDOMIZE_BASE=y Test case: baseline.dmesg.crit Breaking commit found: ------------------------------------------------------------------------------- commit 5b17a04addc29201dc142c8d2c077eb7745d2e35 Author: Guillaume Tucker Date: Fri Jun 12 14:58:37 2020 +0100 ARM: exynos: clear L310_AUX_CTRL_FULL_LINE_ZERO in default l2c_aux_val This "alert" error message can be seen on exynos4412-odroidx2: L2C: platform modifies aux control register: 0x02070000 -> 0x3e470001 L2C: platform provided aux values permit register corruption. Followed by this plain error message: L2C-310: enabling full line of zeros but not enabled in Cortex-A9 To fix it, don't set the L310_AUX_CTRL_FULL_LINE_ZERO flag (bit 0) in the default value of l2c_aux_val. It may instead be enabled when applicable by the logic in l2c310_enable() if the attribute "arm,full-line-zero-disable" was set in the device tree. The initial commit that introduced this default value was in v2.6.38 commit 1cf0eb799759 ("ARM: S5PV310: Add L2 cache init function in cpu.c"). However, the code to set the L310_AUX_CTRL_FULL_LINE_ZERO flag and manage that feature was added much later and the default value was not updated then. So this seems to have been a subtle oversight especially since enabling it only in the cache and not in the A9 core doesn't actually prevent the platform from running. According to the TRM, the opposite would be a real issue, if the feature was enabled in the A9 core but not in the cache controller. Reported-by: "kernelci.org bot" Signed-off-by: Guillaume Tucker Signed-off-by: Krzysztof Kozlowski ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [b0953d8b7cdb39493e67cff4b20b0ebe3a2bba92] Merge branch 'next/drivers' into for-next git bisect good b0953d8b7cdb39493e67cff4b20b0ebe3a2bba92 # bad: [d6fe116541b73a56110310c39a270c99766cd909] Merge branch 'next/soc' into for-next git bisect bad d6fe116541b73a56110310c39a270c99766cd909 # bad: [5b17a04addc29201dc142c8d2c077eb7745d2e35] ARM: exynos: clear L310_AUX_CTRL_FULL_LINE_ZERO in default l2c_aux_val git bisect bad 5b17a04addc29201dc142c8d2c077eb7745d2e35 # first bad commit: [5b17a04addc29201dc142c8d2c077eb7745d2e35] ARM: exynos: clear L310_AUX_CTRL_FULL_LINE_ZERO in default l2c_aux_val ------------------------------------------------------------------------------- diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 7a8d1555db40..36c37444485a 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -193,7 +193,7 @@ static void __init exynos_dt_fixup(void) } DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)") - .l2c_aux_val = 0x3c400001, + .l2c_aux_val = 0x3c400000, .l2c_aux_mask = 0xc20fffff, .smp = smp_ops(exynos_smp_ops), .map_io = exynos_init_io,