From patchwork Wed Jul 13 14:13:00 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 972302 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6DEDLlC005137 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 13 Jul 2011 14:13:42 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Qh0Be-0006hV-Ae; Wed, 13 Jul 2011 14:13:14 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Qh0Bd-0003Zw-V7; Wed, 13 Jul 2011 14:13:13 +0000 Received: from ch1ehsobe004.messaging.microsoft.com ([216.32.181.184] helo=ch1outboundpool.messaging.microsoft.com) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Qh0BW-0003Zb-Qo for linux-arm-kernel@lists.infradead.org; Wed, 13 Jul 2011 14:13:11 +0000 Received: from mail52-ch1-R.bigfish.com (216.32.181.169) by CH1EHSOBE017.bigfish.com (10.43.70.67) with Microsoft SMTP Server id 14.1.225.22; Wed, 13 Jul 2011 14:13:03 +0000 Received: from mail52-ch1 (localhost.localdomain [127.0.0.1]) by mail52-ch1-R.bigfish.com (Postfix) with ESMTP id 2B44C14E029E; Wed, 13 Jul 2011 14:13:03 +0000 (UTC) X-SpamScore: -25 X-BigFish: VS-25(zz9371M146fK179dN542M1432Nzz1202hzz8275bh8275dhz2dh2a8h668h839h8e2h8e3h944h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPVD:NLI; H:mail.freescale.net; RD:none; EFVD:NLI Received: from mail52-ch1 (localhost.localdomain [127.0.0.1]) by mail52-ch1 (MessageSwitch) id 1310566382955599_29502; Wed, 13 Jul 2011 14:13:02 +0000 (UTC) Received: from CH1EHSMHS009.bigfish.com (snatpool1.int.messaging.microsoft.com [10.43.68.244]) by mail52-ch1.bigfish.com (Postfix) with ESMTP id E1F3410004B; Wed, 13 Jul 2011 14:13:02 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by CH1EHSMHS009.bigfish.com (10.43.70.9) with Microsoft SMTP Server (TLS) id 14.1.225.22; Wed, 13 Jul 2011 14:13:01 +0000 Received: from 039-SN1MPN1-002.039d.mgd.msft.net ([169.254.2.218]) by 039-SN1MMR1-002.039d.mgd.msft.net ([10.84.1.15]) with mapi id 14.01.0289.008; Wed, 13 Jul 2011 09:13:00 -0500 From: Dong Aisheng-B29396 To: Wolfram Sang Subject: RE: [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver Thread-Topic: [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver Thread-Index: AQHMQKIVyIyoy1nH/EKq+lsD4VTRwJTqeoyA//+vEgCAABaA4IAAXOwA//+tt3A= Date: Wed, 13 Jul 2011 14:13:00 +0000 Message-ID: <65EE16ACC360FA4D99C96DC085B3F7721CDD43@039-SN1MPN1-002.039d.mgd.msft.net> References: <1310483085-31442-1-git-send-email-b29396@freescale.com> <1310483085-31442-4-git-send-email-b29396@freescale.com> <20110713115711.GG1928@pengutronix.de> <65EE16ACC360FA4D99C96DC085B3F7721CDBAA@039-SN1MPN1-002.039d.mgd.msft.net> <65EE16ACC360FA4D99C96DC085B3F7721CDC7C@039-SN1MPN1-002.039d.mgd.msft.net> <20110713140038.GI1928@pengutronix.de> In-Reply-To: <20110713140038.GI1928@pengutronix.de> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.192.242.89] MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110713_101307_269354_B626070A X-CRM114-Status: GOOD ( 25.90 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [216.32.181.184 listed in list.dnswl.org] Cc: "alsa-devel@alsa-project.org" , "s.hauer@pengutronix.de" , "broonie@opensource.wolfsonmicro.com" , "u.kleine-koenig@pengutronix.de" , "lrg@ti.com" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 13 Jul 2011 14:13:42 +0000 (UTC) > -----Original Message----- > From: Wolfram Sang [mailto:w.sang@pengutronix.de] > Sent: Wednesday, July 13, 2011 10:01 PM > To: Dong Aisheng-B29396 > Cc: alsa-devel@alsa-project.org; s.hauer@pengutronix.de; > broonie@opensource.wolfsonmicro.com; u.kleine-koenig@pengutronix.de; > lrg@ti.com; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver > > > > For regulator issue, One method is that just add two regulator > > (VDDA&VDDIO) needed by sgtl5000 in platform code to make sgtl5000 work > first. > > If that I could add it in my the following patches. > > > > Or we do not add it (just leave sgtl5000 unwork), instead, we directly > > implement the full regulator support for MX28 power management? > > > > What's your suggestion? > > Hmmm, as we started now with the audio patches, I'd think we should > concentrate on getting them in shape first. So, my preference would be > adding just the two regulators. Whenever the power management gets > complete, they should be easy to include/adapt, if I didn't miss anything. OK, I will add it in my following patch. > With your sgtl-patch, I can set the alsa-controls like volume. Yet the > WAV played via simple aplay has a massive hall (like a concert at the > other end of the cathedral ;)). Interrupting aplay, and trying again > gives me sometimes: > > After that OOPS, playing works again (still with the hall). Didn't have > the time to look at these issues yet, but since I was writing to you > anyway, I thought I'd mention it... I did not meet it in the first time of playing. However, it can happen in the second play. The root cause is that we get an unexpected dma irq before iprtd is initialized when request dma channel(still not start channel). It seemed to be a DMA issue that the dma channel of saif was in an abnormal state after disable. A patch already prepared to fix this issue is as follows: I am going to send it out for review. Can you help try if it can fix your issue? commit d2e4437ddca8bf909ca6c53257e1de504274017e Author: Dong Aisheng Date: Tue Jul 12 21:52:55 2011 +0800 ARM: mxs-dma: reset after disable channel We met some channels in abnormal state after disable. Reset it to get a clean state. Signed-off-by: Dong Aisheng Regards Dong Aisheng diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c index 88aad4f..5a24010 100644 --- a/drivers/dma/mxs-dma.c +++ b/drivers/dma/mxs-dma.c @@ -535,6 +535,7 @@ static int mxs_dma_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd, switch (cmd) { case DMA_TERMINATE_ALL: mxs_dma_disable_chan(mxs_chan); + mxs_dma_reset_chan(mxs_chan); break; case DMA_PAUSE: mxs_dma_pause_chan(mxs_chan);