| Message ID | 6a66d2ac442925e066fe9b67ee2883de5894b0d3.1452168063.git.robin.murphy@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 07 January 2016 12:01:59 Robin Murphy wrote: > The DMA-330 has an "irq_abort" interrupt line on which it signals faults > separately from the "irq[n:0]" channel interrupts. On Juno, this is > wired up to SPI 92; add it to the DT so that DMAC faults are correctly > reported for the driver to reset the thing, rather than leaving it > locked up and waiting to time out. > > CC: Liviu Dudau <liviu.dudau@arm.com> > CC: Sudeep Holla <sudeep.holla@arm.com> > CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Signed-off-by: Robin Murphy <robin.murphy@arm.com> > Nothing wrong with the patch, but could you please come up with a more structured way to get patches for Juno into the kernel? You have addressed the patch "to:" the arm-soc maintainers, but you are not listed in the maintainers file for the directory, so it's not clear what you expect to happen here. Ideally, we'd get patches from just one of the people listed in the MAINTAINERS file normally, and let us know if the primary maintainer changes, or if one of the others sends a patch because that person is unavailable. Arnd
On 07/01/16 14:36, Arnd Bergmann wrote: > On Thursday 07 January 2016 12:01:59 Robin Murphy wrote: >> The DMA-330 has an "irq_abort" interrupt line on which it signals faults >> separately from the "irq[n:0]" channel interrupts. On Juno, this is >> wired up to SPI 92; add it to the DT so that DMAC faults are correctly >> reported for the driver to reset the thing, rather than leaving it >> locked up and waiting to time out. >> >> CC: Liviu Dudau <liviu.dudau@arm.com> >> CC: Sudeep Holla <sudeep.holla@arm.com> >> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >> Signed-off-by: Robin Murphy <robin.murphy@arm.com> >> > > Nothing wrong with the patch, but could you please come up with > a more structured way to get patches for Juno into the kernel? > Sorry for that. Liviu is on holidays, he usually reviews Juno DTS change and provides ack. But missed to check with him before he disappeared. > You have addressed the patch "to:" the arm-soc maintainers, but > you are not listed in the maintainers file for the directory, so > it's not clear what you expect to happen here. > > Ideally, we'd get patches from just one of the people listed > in the MAINTAINERS file normally, and let us know if the > primary maintainer changes, or if one of the others sends a > patch because that person is unavailable. > We(me along with Liviu and Lorenzo) will try to group them together and one of us can send you pull request. I don't think there's any other fixes on the list though there are few feature additions which I assume is too late for v4.5 now. But still I prefer to wait till next week so that I can check with Liviu to see if there are any other Juno fixes that can be grouped.
On 07/01/16 14:36, Arnd Bergmann wrote: > On Thursday 07 January 2016 12:01:59 Robin Murphy wrote: >> The DMA-330 has an "irq_abort" interrupt line on which it signals faults >> separately from the "irq[n:0]" channel interrupts. On Juno, this is >> wired up to SPI 92; add it to the DT so that DMAC faults are correctly >> reported for the driver to reset the thing, rather than leaving it >> locked up and waiting to time out. >> >> CC: Liviu Dudau <liviu.dudau@arm.com> >> CC: Sudeep Holla <sudeep.holla@arm.com> >> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >> Signed-off-by: Robin Murphy <robin.murphy@arm.com> >> > > Nothing wrong with the patch, but could you please come up with > a more structured way to get patches for Juno into the kernel? > > You have addressed the patch "to:" the arm-soc maintainers, but > you are not listed in the maintainers file for the directory, so > it's not clear what you expect to happen here. I'll admit I got to the addressing point and wasn't entirely sure either - there still seemed to be a precedent of patches going to arm-soc picking up acks along the way, rather than via a sub-maintainer pull, hence what I ended up with. > Ideally, we'd get patches from just one of the people listed > in the MAINTAINERS file normally, and let us know if the > primary maintainer changes, or if one of the others sends a > patch because that person is unavailable. Sure, I'll bear that in mind in future, especially when sending from an email domain which doesn't really make clear the context that I'm just another end-user posting a fix for something I found, rather than trying to assume any "official" capacity ;) As a side note, the Juno dts* files don't actually seem to be covered by MAINTAINERS at all, which can't help the situation. Sorry for the confusion, Robin.
On 07/01/16 15:45, Robin Murphy wrote: > > As a side note, the Juno dts* files don't actually seem to be covered by > MAINTAINERS at all, which can't help the situation. > True, should be resolved once [1] is merged.
On Thu, Jan 07, 2016 at 03:06:28PM +0000, Sudeep Holla wrote: > > > On 07/01/16 14:36, Arnd Bergmann wrote: > >On Thursday 07 January 2016 12:01:59 Robin Murphy wrote: > >>The DMA-330 has an "irq_abort" interrupt line on which it signals faults > >>separately from the "irq[n:0]" channel interrupts. On Juno, this is > >>wired up to SPI 92; add it to the DT so that DMAC faults are correctly > >>reported for the driver to reset the thing, rather than leaving it > >>locked up and waiting to time out. > >> > >>CC: Liviu Dudau <liviu.dudau@arm.com> > >>CC: Sudeep Holla <sudeep.holla@arm.com> > >>CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > >>Signed-off-by: Robin Murphy <robin.murphy@arm.com> > >> > > > >Nothing wrong with the patch, but could you please come up with > >a more structured way to get patches for Juno into the kernel? > > > > Sorry for that. Liviu is on holidays, he usually reviews Juno DTS change > and provides ack. But missed to check with him before he disappeared. > > >You have addressed the patch "to:" the arm-soc maintainers, but > >you are not listed in the maintainers file for the directory, so > >it's not clear what you expect to happen here. > > > >Ideally, we'd get patches from just one of the people listed > >in the MAINTAINERS file normally, and let us know if the > >primary maintainer changes, or if one of the others sends a > >patch because that person is unavailable. > > > > We(me along with Liviu and Lorenzo) will try to group them together and > one of us can send you pull request. > > I don't think there's any other fixes on the list though there are few > feature additions which I assume is too late for v4.5 now. But still I > prefer to wait till next week so that I can check with Liviu to see if > there are any other Juno fixes that can be grouped. Hi all, The only other changes queued for v4.5 are the HDLCD patches which touch on the .dts. Arnd, Olof: how do you prefer to handle this? Can you take Robin's patch in arm-soc and I'll queue the rest of the changes via David Airlie? Best regards, Liviu > > -- > Regards, > Sudeep >
diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi index dd5158e..e5b59ca 100644 --- a/arch/arm64/boot/dts/arm/juno-base.dtsi +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi @@ -115,6 +115,7 @@ <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
The DMA-330 has an "irq_abort" interrupt line on which it signals faults separately from the "irq[n:0]" channel interrupts. On Juno, this is wired up to SPI 92; add it to the DT so that DMAC faults are correctly reported for the driver to reset the thing, rather than leaving it locked up and waiting to time out. CC: Liviu Dudau <liviu.dudau@arm.com> CC: Sudeep Holla <sudeep.holla@arm.com> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Signed-off-by: Robin Murphy <robin.murphy@arm.com> --- arch/arm64/boot/dts/arm/juno-base.dtsi | 1 + 1 file changed, 1 insertion(+)