| Message ID | 6e397bf2-1d45-434f-8619-58a737a138e3@web.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] pmdomain: mediatek: Use devm_platform_ioremap_resource() in init_scp() | expand |
On Tue, Feb 6, 2024 at 10:21 AM Markus Elfring <Markus.Elfring@web.de> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 6 Feb 2024 10:05:34 +0100 > Subject: [PATCH v2] pmdomain: mediatek: Use devm_platform_ioremap_resource() in init_scp() > > A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 > ("drivers: provide devm_platform_ioremap_resource()"). > > * Thus reuse existing functionality instead of keeping duplicate source code. > > * Delete a local variable which became unnecessary with this refactoring. > > > This issue was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > > v2: > The transformation pattern was adjusted based on advices by known contributors. > > Examples: > * Doug Anderson > * Geert Uytterhoeven > * Robin Murphy Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Tue, 6 Feb 2024 at 10:21, Markus Elfring <Markus.Elfring@web.de> wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 6 Feb 2024 10:05:34 +0100 > Subject: [PATCH v2] pmdomain: mediatek: Use devm_platform_ioremap_resource() in init_scp() > > A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 > ("drivers: provide devm_platform_ioremap_resource()"). > > * Thus reuse existing functionality instead of keeping duplicate source code. > > * Delete a local variable which became unnecessary with this refactoring. > > > This issue was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Applied for next, thanks! Kind regards Uffe > --- > > v2: > The transformation pattern was adjusted based on advices by known contributors. > > Examples: > * Doug Anderson > * Geert Uytterhoeven > * Robin Murphy > > > drivers/pmdomain/mediatek/mtk-scpsys.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pmdomain/mediatek/mtk-scpsys.c b/drivers/pmdomain/mediatek/mtk-scpsys.c > index b374d01fdac7..59a7a8c261ed 100644 > --- a/drivers/pmdomain/mediatek/mtk-scpsys.c > +++ b/drivers/pmdomain/mediatek/mtk-scpsys.c > @@ -425,7 +425,6 @@ static struct scp *init_scp(struct platform_device *pdev, > bool bus_prot_reg_update) > { > struct genpd_onecell_data *pd_data; > - struct resource *res; > int i, j; > struct scp *scp; > struct clk *clk[CLK_MAX]; > @@ -441,8 +440,7 @@ static struct scp *init_scp(struct platform_device *pdev, > > scp->dev = &pdev->dev; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - scp->base = devm_ioremap_resource(&pdev->dev, res); > + scp->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(scp->base)) > return ERR_CAST(scp->base); > > -- > 2.43.0 >
diff --git a/drivers/pmdomain/mediatek/mtk-scpsys.c b/drivers/pmdomain/mediatek/mtk-scpsys.c index b374d01fdac7..59a7a8c261ed 100644 --- a/drivers/pmdomain/mediatek/mtk-scpsys.c +++ b/drivers/pmdomain/mediatek/mtk-scpsys.c @@ -425,7 +425,6 @@ static struct scp *init_scp(struct platform_device *pdev, bool bus_prot_reg_update) { struct genpd_onecell_data *pd_data; - struct resource *res; int i, j; struct scp *scp; struct clk *clk[CLK_MAX]; @@ -441,8 +440,7 @@ static struct scp *init_scp(struct platform_device *pdev, scp->dev = &pdev->dev; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - scp->base = devm_ioremap_resource(&pdev->dev, res); + scp->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(scp->base)) return ERR_CAST(scp->base);