| Message ID | 718c781b77081d6974fd91d5dff7b0f8737757b0.1564048197.git.leonard.crestez@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: imx8mm: Fix boot hang at clk init | expand |
On 19-07-25 12:50:53, Leonard Crestez wrote: > The assigned-clock-rates property is incorrect (4 elements while > assigned-clocks has length 5) and boot hangs while assigning some > unexpected rates. > > Fix by inserting another <400000000>, the intention is to assign both > IMX8MM_CLK_AUDIO_AHB and IMX8MM_CLK_IPG_AUDIO_ROOT 400mhz. > > Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks") > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > Reviewed-by: Abel Vesa <abel.vesa@nxp.com> > --- > Changes since v1: > * Insert and 400mhz instead of <0> > Link to v1: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fpatch%2F11057515%2F&data=02%7C01%7Cabel.vesa%40nxp.com%7C3ff24093579746ec316608d710e59733%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636996450584921930&sdata=qEBAnihmelL3S5OK%2BcrNDo5cvno5oIuDWFTlingXFco%3D&reserved=0 > > Should probably be squashed into df1703896a17 > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index c9a7c0054c5c..7bbdcebc6b57 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -461,10 +461,11 @@ > <&clk IMX8MM_SYS_PLL3>, > <&clk IMX8MM_VIDEO_PLL1>; > assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>, > <&clk IMX8MM_SYS_PLL1_800M>; > assigned-clock-rates = <0>, > + <400000000>, > <400000000>, > <750000000>, > <594000000>; > }; > > -- > 2.17.1 >
On Thu, Jul 25, 2019 at 12:50:53PM +0300, Leonard Crestez wrote: > The assigned-clock-rates property is incorrect (4 elements while > assigned-clocks has length 5) and boot hangs while assigning some > unexpected rates. > > Fix by inserting another <400000000>, the intention is to assign both > IMX8MM_CLK_AUDIO_AHB and IMX8MM_CLK_IPG_AUDIO_ROOT 400mhz. > > Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks") > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > > --- > Changes since v1: > * Insert and 400mhz instead of <0> > Link to v1: https://patchwork.kernel.org/patch/11057515/ > > Should probably be squashed into df1703896a17 Done, thanks.
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi index c9a7c0054c5c..7bbdcebc6b57 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi @@ -461,10 +461,11 @@ <&clk IMX8MM_SYS_PLL3>, <&clk IMX8MM_VIDEO_PLL1>; assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>, <&clk IMX8MM_SYS_PLL1_800M>; assigned-clock-rates = <0>, + <400000000>, <400000000>, <750000000>, <594000000>; };
The assigned-clock-rates property is incorrect (4 elements while assigned-clocks has length 5) and boot hangs while assigning some unexpected rates. Fix by inserting another <400000000>, the intention is to assign both IMX8MM_CLK_AUDIO_AHB and IMX8MM_CLK_IPG_AUDIO_ROOT 400mhz. Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks") Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> --- Changes since v1: * Insert and 400mhz instead of <0> Link to v1: https://patchwork.kernel.org/patch/11057515/ Should probably be squashed into df1703896a17 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 + 1 file changed, 1 insertion(+)