From patchwork Thu Jan 25 12:09:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13530891 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66243C48285 for ; Thu, 25 Jan 2024 14:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kaPb2gVTBZARMF0Pxt3k9ptZj+2Ghy99GB5Lb0eYIko=; b=dQj1VI66C8yKaO B5/EggJwdWEJW+sB6CtRjCwCOPRSviqp+lMzVB8E00ZRSgcznCfTaG6DTnFFsflaNVyqeGvMDQCLt sAENPvt5UAOLpg+RpyY8TjzClSNlwfF7qrSTEL2itIGzT7TCF5VM1fvNKrF/HUEiW9CnvHGjayAsq qX2H1XogMnAmp4bL5UAWU8f3rFiNtgj8zTgrrCBsMzhFwqA6K14cclZflJW8jtQxGT2lijj7vKoWQ OR226sbOv2duKYEJj0mKYgt9GGhkrhRoY06tG4nblXc97gulZlM18ldDgxrJz8xepHgAVS2wYjxJu zT+DKvHi9/egWYdHPtbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT0PW-00000000FRV-3y6g; Thu, 25 Jan 2024 14:08:54 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT0Ou-00000000F5v-3CFX for linux-arm-kernel@bombadil.infradead.org; Thu, 25 Jan 2024 14:08:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=8zhso+SNIeR6+iOZO3KeMbHpZe1lwFUA7b2eFCEH484=; b=OQcZrGaDXciULNHfOLUIOJNtMB WL0aqLPTJ8c46x/djDJ/eyXzb3fqvcYsaH5dFulqm+uZ7TgH3iAFD80TNyCHTtjXW+iZ1F2GPYb7T d/tmVM9t6+BLibHQxFajicIBlIJvM5HJuuIWKYhasG9yZMdwORNyeOdDnlgaNVZRu0CurWVpZ06Cz mfuTPHyLRM1iOq6MOE+guFqZy0VAHOu6uHd9EM0Ot72YeNZNO49hqn3rLfelE2YM1TiMz+sPeK83b vdtpwBHhE/HJvIyOvPYiPE7kVGyMlf0mvKNQuh8QNx86g0IZ7k/Nth8TBI6RIHRYdii+imz2ciMc9 I5IJjcbQ==; Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rSybi-00000009sDf-0LUf for linux-arm-kernel@lists.infradead.org; Thu, 25 Jan 2024 12:13:25 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSyZN-0004UE-0f; Thu, 25 Jan 2024 13:10:57 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSyZL-002HTr-QD; Thu, 25 Jan 2024 13:10:55 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rSyZL-007n3U-2M; Thu, 25 Jan 2024 13:10:55 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Florian Fainelli , linux-pwm@vger.kernel.org Cc: Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH v5 080/111] pwm: raspberrypi-poe: Make use of devm_pwmchip_alloc() function Date: Thu, 25 Jan 2024 13:09:42 +0100 Message-ID: <7240dd99d9ef8032b51995feb6d7e63b6c45558b.1706182805.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2408; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=hZ48ifFT5vmPHvpooGFp+QQXZ/HZi5ytMwRpLJdzaL4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlsk+Y57iPgeMAeGCjIL4Dzuip7IHsvGZge+Sza VKltxAix+uJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZbJPmAAKCRCPgPtYfRL+ Tp3UB/4n0S/zlLIBBC0jmzVZQXhOAT4zj+dOPbCv3R9U4BJWwZzKIw0JxfOYA6c7ecMOuZLsGGc DVlG8U1d5RZNmzxbGCPY0YvQug+qZApwKESMKM6/IchAt3jVGOj/bNf8npO6awSfAvbsen4kk/w oaAUtrK6CW+Tw+c8QckK5IQ1+lLOpOtpS9E11FY2OLCtXSiYV0070wE1itItoaFNnKlOFooNunF DYwYDRByI7FinEFT5F+PYeE+yflyRRAmytp9JjqV6P2UHpDyOLLgoLBDz6RT32v2mFL3xY71jGQ Osd4h5nNLqPQ8IH4IePCdKUdrgl3NPI8nr+P/7pMYTNFKdht X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_121323_603232_5701D7F4 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This prepares the pwm-raspberrypi-poe driver to further changes of the pwm core outlined in the commit introducing devm_pwmchip_alloc(). There is no intended semantical change and the driver should behave as before. Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-raspberrypi-poe.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pwm/pwm-raspberrypi-poe.c b/drivers/pwm/pwm-raspberrypi-poe.c index f10e8a624c51..8921e7ea2cea 100644 --- a/drivers/pwm/pwm-raspberrypi-poe.c +++ b/drivers/pwm/pwm-raspberrypi-poe.c @@ -27,7 +27,6 @@ struct raspberrypi_pwm { struct rpi_firmware *firmware; - struct pwm_chip chip; unsigned int duty_cycle; }; @@ -40,7 +39,7 @@ struct raspberrypi_pwm_prop { static inline struct raspberrypi_pwm *raspberrypi_pwm_from_chip(struct pwm_chip *chip) { - return container_of(chip, struct raspberrypi_pwm, chip); + return pwmchip_get_drvdata(chip); } static int raspberrypi_pwm_set_property(struct rpi_firmware *firmware, @@ -142,6 +141,7 @@ static int raspberrypi_pwm_probe(struct platform_device *pdev) struct device_node *firmware_node; struct device *dev = &pdev->dev; struct rpi_firmware *firmware; + struct pwm_chip *chip; struct raspberrypi_pwm *rpipwm; int ret; @@ -157,14 +157,14 @@ static int raspberrypi_pwm_probe(struct platform_device *pdev) return dev_err_probe(dev, -EPROBE_DEFER, "Failed to get firmware handle\n"); - rpipwm = devm_kzalloc(&pdev->dev, sizeof(*rpipwm), GFP_KERNEL); - if (!rpipwm) - return -ENOMEM; + chip = devm_pwmchip_alloc(&pdev->dev, RASPBERRYPI_FIRMWARE_PWM_NUM, + sizeof(*rpipwm)); + if (IS_ERR(chip)) + return PTR_ERR(chip); + rpipwm = raspberrypi_pwm_from_chip(chip); rpipwm->firmware = firmware; - rpipwm->chip.dev = dev; - rpipwm->chip.ops = &raspberrypi_pwm_ops; - rpipwm->chip.npwm = RASPBERRYPI_FIRMWARE_PWM_NUM; + chip->ops = &raspberrypi_pwm_ops; ret = raspberrypi_pwm_get_property(rpipwm->firmware, RPI_PWM_CUR_DUTY_REG, &rpipwm->duty_cycle); @@ -173,7 +173,7 @@ static int raspberrypi_pwm_probe(struct platform_device *pdev) return ret; } - return devm_pwmchip_add(dev, &rpipwm->chip); + return devm_pwmchip_add(dev, chip); } static const struct of_device_id raspberrypi_pwm_of_match[] = {