From patchwork Mon Jan 11 22:49:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 8012581 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D8FD7BEEE5 for ; Mon, 11 Jan 2016 22:51:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 19F1B20165 for ; Mon, 11 Jan 2016 22:51:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E97F20148 for ; Mon, 11 Jan 2016 22:51:30 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aIlHd-0003lN-Qq; Mon, 11 Jan 2016 22:49:53 +0000 Received: from v094114.home.net.pl ([79.96.170.134]) by bombadil.infradead.org with smtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aIlHa-0003js-DK for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2016 22:49:51 +0000 Received: from cmv19.neoplus.adsl.tpnet.pl (83.31.149.19) (HELO vostro.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer v0.80) id 60d0c468964516c7; Mon, 11 Jan 2016 23:49:27 +0100 From: "Rafael J. Wysocki" To: Guenter Roeck Subject: Re: arm qemu boot failures in -next due to 'PM / Domains: add setter for dev.pm_domain' Date: Mon, 11 Jan 2016 23:49:59 +0100 Message-ID: <7302125.veLBHLkdLG@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.4.0; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160111200450.GA16902@roeck-us.net> References: <5693EB8A.40802@roeck-us.net> <20160111185459.GZ12777@atomide.com> <20160111200450.GA16902@roeck-us.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160111_144950_650538_F33DD1EE X-CRM114-Status: GOOD ( 19.92 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Russell King , Tomeu Vizoso , Kevin Hilman , Tony Lindgren , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD,UNPARSEABLE_RELAY,WEIRD_PORT autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Monday, January 11, 2016 12:04:50 PM Guenter Roeck wrote: > On Mon, Jan 11, 2016 at 10:55:00AM -0800, Tony Lindgren wrote: > > * Guenter Roeck [160111 09:51]: > > > Hi, > > > > > > I see 6 out of 24 arm qemu tests failing in next-20160111. Bisect points > > > to commit 989561de9b51 ("PM / Domains: add setter for dev.pm_domain"). > > > Failures are silent - there is no output on the console. > > > Affected tests are > > > > > > arm:beagle:multi_v7_defconfig:omap3-beagle > > > arm:beaglexm:multi_v7_defconfig:omap3-beagle-xm > > > arm:overo:multi_v7_defconfig:omap3-overo-tobi > > > arm:beagle:omap2plus_defconfig:omap3-beagle > > > arm:beaglexm:omap2plus_defconfig:omap3-beagle-xm > > > arm:overo:omap2plus_defconfig:omap3-overo-tobi > > > > > > For details please see the 'next' column at http://server.roeck-us.net:8010/builders. > > > > > > Reverting the offending commit fixes the problems. > > > > > > Please let me know if there is anything I can do to help tracking down the problem. > > > > The following fixes the booting, but I wonder if it's a > > Yes, it does. > > Tested-by: Guenter Roeck > > > proper fix? > > > That I don't know. If I'm not mistaken, what happens is that device_is_bound() tries to dereference dev->p which is NULL. If that's the case, the appended one should help too. Can you please check? Tested-by: Tony Lindgren --- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-pm/drivers/base/dd.c =================================================================== --- linux-pm.orig/drivers/base/dd.c +++ linux-pm/drivers/base/dd.c @@ -234,7 +234,7 @@ late_initcall(deferred_probe_initcall); */ bool device_is_bound(struct device *dev) { - return klist_node_attached(&dev->p->knode_driver); + return dev->p && klist_node_attached(&dev->p->knode_driver); } static void driver_bound(struct device *dev)