From patchwork Fri Aug 31 16:47:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Hiremath X-Patchwork-Id: 1393991 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id DD8D13FDFB for ; Fri, 31 Aug 2012 16:52:19 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T7UNQ-0006OJ-L1; Fri, 31 Aug 2012 16:47:24 +0000 Received: from comal.ext.ti.com ([198.47.26.152]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T7UNN-0006O5-7m for linux-arm-kernel@lists.infradead.org; Fri, 31 Aug 2012 16:47:21 +0000 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id q7VGlFBp027111; Fri, 31 Aug 2012 11:47:16 -0500 Received: from DBDE71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q7VGlDW3013023; Fri, 31 Aug 2012 22:17:13 +0530 (IST) Received: from DBDE01.ent.ti.com ([fe80::d5df:c4b5:9919:4e10]) by DBDE71.ent.ti.com ([fe80::692c:15fd:9507:b54%21]) with mapi id 14.01.0323.003; Fri, 31 Aug 2012 22:17:13 +0530 From: "Hiremath, Vaibhav" To: "Hiremath, Vaibhav" , Tony Lindgren Subject: RE: Without MACH_ option Early printk (DEBUG_LL) Thread-Topic: Without MACH_ option Early printk (DEBUG_LL) Thread-Index: Ac2HiJVWVgGww90QTvCNDMQfv0yxcP//s90A//+gFLCAAGU3AP//oWFQ//87izA= Date: Fri, 31 Aug 2012 16:47:12 +0000 Message-ID: <79CD15C6BA57404B839C016229A409A83EA9EBD1@DBDE01.ent.ti.com> References: <5040D03B.2050304@ti.com> <20120831155226.GL1303@atomide.com> <79CD15C6BA57404B839C016229A409A83EA9EB0F@DBDE01.ent.ti.com> <20120831161122.GO1303@atomide.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.133.105] MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -7.1 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [198.47.26.152 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Paul Walmsley , "linux-omap@vger.kernel.org" , Russell King , "Cousson, Benoit" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Fri, Aug 31, 2012 at 22:07:37, Hiremath, Vaibhav wrote: > On Fri, Aug 31, 2012 at 21:41:22, Tony Lindgren wrote: > > * Hiremath, Vaibhav [120831 09:06]: > > > On Fri, Aug 31, 2012 at 21:22:26, Tony Lindgren wrote: > > > > * Vaibhav Hiremath [120831 07:55]: > > > > > Hi Russell & Tony, > > > > > > > > > > AM335X EVM (based on AM33XX device) only supports DT boot mode and > > > > > doesn't have CONFIG_MACH_AM335XEVM option defined. Some time back during > > > > > baseport submission we had aligned that, we won't create separate EVM > > > > > options, killing the board file all-together. > > > > > > > > > > Having said that, the early printk option (DEBUG_LL) is broken, the > > > > > auto-generated file "./include/generated/mach-types.h" still refers to > > > > > CONFIG_MACH_AM335XEVM option, > > > > > > > > The way we're heading is that the DEBUG_LL options will only work for > > > > one hardcoded machine where you need to select the uart type and address > > > > in Kconfig. Or just patch it in. > > > > > > > > > #ifdef CONFIG_MACH_AM335XEVM > > > > > # ifdef machine_arch_type > > > > > # undef machine_arch_type > > > > > # define machine_arch_type __machine_arch_type > > > > > # else > > > > > # define machine_arch_type MACH_TYPE_AM335XEVM > > > > > # endif > > > > > # define machine_is_am335xevm() (machine_arch_type == MACH_TYPE_AM335XEVM) > > > > > #else > > > > > # define machine_is_am335xevm() (0) > > > > > #endif > > > > > > > > > > > > > > > So I am thinking of changing the config_xxx option to SOC_AM33XX or > > > > > ARCH_OMAP2PLUS, something like below, > > > > > > > > > > am335xevm SOC_AM33XX AM335XEVM 3589 > > > > > > > > > > OR > > > > > > > > > > am335xevm ARCH_OMAP2PLUS AM335XEVM 3589 > > > > > > > > > > > > > > > Can you comment on this? Based on that I will submit the patch. > > > > > > > > I think that would at minimum break things for autogenerated > > > > mach-types.h where if only some other non-am335xevm machine is > > > > selected (like omap-generic) things don't get optimized out any > > > > longer as they currently do. > > > > > > > > > > Agreed. In that case the first option should work here, right? > > > > It gets messy if we start mixing mach and soc defines there.. > > > > How about just add a hidden Kconfig option to mach-omap2/Kconfig > > that always selects MACH_TYPE_AM335XEVM if SOC_AM33XX is set? > > Great, this is what I had in my mind but since it is hidden option I thought > may not be right thing to do. > I was just thinking in the direction that, it should be logical and fine if > SOC_AM33XX is used for all AM33xx based machines, isn't it? > > Anyway, I think we are on same page here, I will add it and submit the patch > ASAP. > > > Or does that require that MACHINE_START is there as well? > > > > I do not think so, they are not related to each other, this option is > required only during decompression. > I have tested it on BeagleBone and it is working. > Can you please review below patch? If you think its ok, I will send the patch - Thanks, Vaibhav diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index fccbdf0..eccafb4 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -104,6 +104,9 @@ config SOC_AM33XX select CPU_V7 select ARM_CPU_SUSPEND if PM select MULTI_IRQ_HANDLER + select MACH_AM335XEVM + select MACH_AM335XIAEVM + select MACH_TAM335X config OMAP_PACKAGE_ZAF bool @@ -140,6 +143,15 @@ config MACH_OMAP_GENERIC Support for generic TI OMAP2+ boards using Flattened Device Tree. More information at Documentation/devicetree +config MACH_AM335XEVM + bool + +config MACH_AM335XIAEVM + bool + +config MACH_TAM335X + bool + config MACH_OMAP2_TUSB6010 bool depends on ARCH_OMAP2 && SOC_OMAP2420