From patchwork Thu Mar 7 15:50:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Hiremath X-Patchwork-Id: 2232931 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id DB7773FC8F for ; Thu, 7 Mar 2013 15:54:25 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UDd5V-00039f-2W; Thu, 07 Mar 2013 15:50:34 +0000 Received: from bear.ext.ti.com ([192.94.94.41]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UDd5B-00032C-Ol for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2013 15:50:16 +0000 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id r27Fo6DX022592; Thu, 7 Mar 2013 09:50:07 -0600 Received: from DBDE71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id r27Fo2dt024694; Thu, 7 Mar 2013 21:20:03 +0530 (IST) Received: from DBDE01.ent.ti.com ([fe80::d5df:c4b5:9919:4e10]) by DBDE71.ent.ti.com ([fe80::692c:15fd:9507:b54%21]) with mapi id 14.01.0323.003; Thu, 7 Mar 2013 21:20:02 +0530 From: "Hiremath, Vaibhav" To: "Porter, Matt" Subject: RE: [PATCH 2/2] ARM: dts: add AM33XX MMC support Thread-Topic: [PATCH 2/2] ARM: dts: add AM33XX MMC support Thread-Index: AQHOGuqV346jkMSBUUmpAvXZrfaGX5iaRamDgAABDLD//6x8AIAAXPnAgAAB1xD//6X/AIAAaJAA Date: Thu, 7 Mar 2013 15:50:01 +0000 Message-ID: <79CD15C6BA57404B839C016229A409A83EC20D27@DBDE01.ent.ti.com> References: <1362629799-22485-1-git-send-email-mporter@ti.com> <1362629799-22485-3-git-send-email-mporter@ti.com> <41fde401c8e646689123d7c6d3a2dffc@DLEE71.ent.ti.com> <20130307141235.GQ6209@beef> <79CD15C6BA57404B839C016229A409A83EC20C57@DBDE01.ent.ti.com> <20130307144656.GR6209@beef> <79CD15C6BA57404B839C016229A409A83EC20CCA@DBDE01.ent.ti.com> <20130307150408.GU6209@beef> In-Reply-To: <20130307150408.GU6209@beef> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130307_105014_224291_32BDE376 X-CRM114-Status: GOOD ( 22.74 ) X-Spam-Score: -7.5 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.94.94.41 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Linux OMAP List , Russell King , "Krishnamoorthy, Balaji T" , Devicetree Discuss , Linux MMC List , Linux Kernel Mailing List , Chris Ball , Linux ARM Kernel List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org > -----Original Message----- > From: Matt Porter [mailto:ohiomdp@gmail.com] On Behalf Of Porter, Matt > Sent: Thursday, March 07, 2013 8:34 PM > To: Hiremath, Vaibhav > Cc: Chris Ball; Russell King; Krishnamoorthy, Balaji T; Devicetree > Discuss; Linux MMC List; Linux Kernel Mailing List; Linux OMAP List; > Linux ARM Kernel List > Subject: Re: [PATCH 2/2] ARM: dts: add AM33XX MMC support > > On Thu, Mar 07, 2013 at 02:59:42PM +0000, Vaibhav Hiremath wrote: > > > > > -----Original Message----- > > > From: Hiremath, Vaibhav > > > Sent: Thursday, March 07, 2013 8:24 PM > > > To: Porter, Matt > > > Cc: Linux OMAP List; Russell King; Krishnamoorthy, Balaji T; > Devicetree > > > Discuss; Linux MMC List; Linux Kernel Mailing List; Chris Ball; > Linux > > > ARM Kernel List > > > Subject: RE: [PATCH 2/2] ARM: dts: add AM33XX MMC support > > > > > > > -----Original Message----- > > > > From: Matt Porter [mailto:ohiomdp@gmail.com] On Behalf Of Porter, > > > Matt > > > > Sent: Thursday, March 07, 2013 8:17 PM > > > > To: Hiremath, Vaibhav > > > > Cc: Linux OMAP List; Russell King; Krishnamoorthy, Balaji T; > > > Devicetree > > > > Discuss; Linux MMC List; Linux Kernel Mailing List; Chris Ball; > Linux > > > > ARM Kernel List > > > > Subject: Re: [PATCH 2/2] ARM: dts: add AM33XX MMC support > > > > > > > > On Thu, Mar 07, 2013 at 02:39:55PM +0000, Vaibhav Hiremath wrote: > > > > > > > > > > > -----Original Message----- > > > > > > From: Matt Porter [mailto:ohiomdp@gmail.com] On Behalf Of > Porter, > > > > Matt > > > > > > Sent: Thursday, March 07, 2013 7:43 PM > > > > > > To: Hiremath, Vaibhav > > > > > > Cc: Krishnamoorthy, Balaji T; Chris Ball; Cousson, Benoit; > Tony > > > > > > Lindgren; Russell King; Devicetree Discuss; Linux ARM Kernel > > > List; > > > > > > Linux OMAP List; Linux Kernel Mailing List; Linux MMC List > > > > > > Subject: Re: [PATCH 2/2] ARM: dts: add AM33XX MMC support > > > > > > > > > > > > On Thu, Mar 07, 2013 at 05:29:24AM +0000, Vaibhav Hiremath > wrote: > > > > > > > > -----Original Message----- > > > > > > > > From: linux-omap-owner@vger.kernel.org [mailto:linux- > omap- > > > > > > > > owner@vger.kernel.org] On Behalf Of Porter, Matt > > > > > > > > Sent: Thursday, March 07, 2013 9:47 AM > > > > > > > > To: Krishnamoorthy, Balaji T; Chris Ball; Cousson, > Benoit; > > > Tony > > > > > > > > Lindgren; Russell King > > > > > > > > Cc: Devicetree Discuss; Linux ARM Kernel List; Linux OMAP > > > List; > > > > > > Linux > > > > > > > > Kernel Mailing List; Linux MMC List > > > > > > > > Subject: [PATCH 2/2] ARM: dts: add AM33XX MMC support > > > > > > > > > > > > > > > > I believe you meant "CONFIG_TI_EDMA" right? > > > > > > Yes, I just enabled it and the result is still same. > > > > > > > > > > > > [root@arago /]# dmesg | grep -ir mmc > > > [ 0.506844] vmmc: 1800 <--> 3300 mV at 3300 mV > > > [ 0.506970] vmmc: supplied by vbat > > > [root@arago /]# > > > [root@arago /]# > > > [root@arago /]# dmesg | grep -ir dma > > > [ 0.217063] DMA: preallocated 256 KiB pool for atomic coherent > > > allocations > > > [ 0.236321] platform 49000000.edma: alias fck already exists > > > [ 0.236360] platform 49000000.edma: alias fck already exists > > > [ 0.236381] platform 49000000.edma: alias fck already exists > > > [ 0.370705] edma-dma-engine edma-dma-engine.0: TI EDMA DMA > engine > > > driver > > > [ 0.445156] omap-dma-engine omap-dma-engine: OMAP DMA engine > driver > > > [root@arago /]# > > > [root@arago /]# > > > > > > > > I have applied below patches from your recent post > > > > > > [2/2] ARM: dts: add AM33XX MMC support > > [1/2] mmc: omap_hsmmc: set max_segs based on dma engine limits > > [v4,3/3] mmc: davinci: get SG segment limits with > dma_get_slave_sg_limits() > > [v4,2/3] dma: edma: add device_slave_sg_limits() support > > [v4,1/3] dmaengine: add dma_get_slave_sg_limits() > > [v9,9/9] ARM: dts: add AM33XX SPI DMA support > > [v9,8/9] spi: omap2-mcspi: add generic DMA request support to the DT > binding > > [v9,7/9] spi: omap2-mcspi: convert to > dma_request_slave_channel_compat() > > [v9,6/9] ARM: dts: add AM33XX EDMA support > > [v9,5/9] dmaengine: edma: Add TI EDMA device tree binding > > [v9,4/9] dmaengine: edma: enable build for AM33XX > > [v9,3/9] ARM: edma: add AM33XX support to the private EDMA API > > [v9,2/9] ARM: edma: remove unused transfer controller handlers > > [v9,1/9] ARM: davinci: move private EDMA API to arm/common > > [v3,2/2] mmc: omap_hsmmc: add generic DMA request support to the DT > binding > > [v3,1/2] mmc: omap_hsmmc: convert to > dma_request_slave_channel_compat() > > > > > > > > Am I missing anything here? > > Yes, you missed the > http://www.spinics.net/lists/arm-kernel/msg227886.html dependency > mentioned first in the cover letter. > Matt, I manually edited the file with above patch and result is still the same. Can you point me to branch where you have tested MMC code? Thanks, Vaibhav Tested-by: Joel A Fernandes diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index 8c3b1fa..e68ac38 100644 --- a/arch/arm/common/edma.c +++ b/arch/arm/common/edma.c @@ -730,6 +730,9 @@ EXPORT_SYMBOL(edma_free_channel); */ int edma_alloc_slot(unsigned ctlr, int slot) { + if (!edma_cc[ctlr]) + return -EINVAL; + if (slot >= 0) slot = EDMA_CHAN_SLOT(slot);