| Message ID | 7b70b64738db468ab3b830c503524058163b5c3f.1551824161.git.stefan@agner.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: drop unnecessary WASM | expand |
On Tue, Mar 5, 2019 at 2:17 PM Stefan Agner <stefan@agner.ch> wrote: > > The assembler option -mauto-it is no longer a valid option. It has > been removed from the documentation in July 2009, which is well > before the release date of the currently supported binutils version > 2.20. Do you by chance have a link to the relevant commit? > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > arch/arm/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index 9561325c5201..ebf67bebe73d 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -113,8 +113,7 @@ CFLAGS_ABI +=-funwind-tables > endif > > ifeq ($(CONFIG_THUMB2_KERNEL),y) > -AFLAGS_AUTOIT :=$(call as-option,-Wa$(comma)-mimplicit-it=always,-Wa$(comma)-mauto-it) > -CFLAGS_ISA :=-mthumb $(AFLAGS_AUTOIT) > +CFLAGS_ISA :=-mthumb -Wa$(comma)-mimplicit-it=always Is $(comma) still needed? I thought it was only needed when a flag that would contain commas would be in another set of parens (thus making an ambiguity), like cc-ldoption or such? Can you replace `$(comma)` here with `,`? I suspect it should work.
On 05.03.2019 23:21, Nick Desaulniers wrote: > On Tue, Mar 5, 2019 at 2:17 PM Stefan Agner <stefan@agner.ch> wrote: >> >> The assembler option -mauto-it is no longer a valid option. It has >> been removed from the documentation in July 2009, which is well >> before the release date of the currently supported binutils version >> 2.20. > > Do you by chance have a link to the relevant commit? > Documentation got removed in https://github.com/bminor/binutils-gdb/commit/529707530657a333a304c651c808ea630c955223 I think -mauto-it never really made it upstream. Documentation has been introduced here, but it seems that the option already has been renamed: https://github.com/bminor/binutils-gdb/commit/e07e6e58be1c5273ed79a25c80ba831e71ac86b1 >> >> Signed-off-by: Stefan Agner <stefan@agner.ch> >> --- >> arch/arm/Makefile | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/arm/Makefile b/arch/arm/Makefile >> index 9561325c5201..ebf67bebe73d 100644 >> --- a/arch/arm/Makefile >> +++ b/arch/arm/Makefile >> @@ -113,8 +113,7 @@ CFLAGS_ABI +=-funwind-tables >> endif >> >> ifeq ($(CONFIG_THUMB2_KERNEL),y) >> -AFLAGS_AUTOIT :=$(call as-option,-Wa$(comma)-mimplicit-it=always,-Wa$(comma)-mauto-it) >> -CFLAGS_ISA :=-mthumb $(AFLAGS_AUTOIT) >> +CFLAGS_ISA :=-mthumb -Wa$(comma)-mimplicit-it=always > > Is $(comma) still needed? I thought it was only needed when a flag > that would contain commas would be in another set of parens (thus > making an ambiguity), like cc-ldoption or such? Can you replace > `$(comma)` here with `,`? I suspect it should work. Could catch, yes comma should work here. -- Stefan
On Tue, Mar 5, 2019 at 2:40 PM Stefan Agner <stefan@agner.ch> wrote: > > On 05.03.2019 23:21, Nick Desaulniers wrote: > > On Tue, Mar 5, 2019 at 2:17 PM Stefan Agner <stefan@agner.ch> wrote: > >> > >> The assembler option -mauto-it is no longer a valid option. It has > >> been removed from the documentation in July 2009, which is well > >> before the release date of the currently supported binutils version > >> 2.20. > > > > Do you by chance have a link to the relevant commit? > > > > Documentation got removed in > https://github.com/bminor/binutils-gdb/commit/529707530657a333a304c651c808ea630c955223 The minimum version of binutils as per Documentation/process/changes.rst is 2.20. Looks like 2.20 was released around 2009-09-04: https://github.com/bminor/binutils-gdb/commit/81c23f829ee829524ac3bf0b9422f8950306d1d6#diff-2bb5799f8d22903a285e71e925800c08 > > I think -mauto-it never really made it upstream. Documentation has been > introduced here, but it seems that the option already has been renamed: > https://github.com/bminor/binutils-gdb/commit/e07e6e58be1c5273ed79a25c80ba831e71ac86b1 > > >> > >> Signed-off-by: Stefan Agner <stefan@agner.ch> > >> --- > >> arch/arm/Makefile | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> diff --git a/arch/arm/Makefile b/arch/arm/Makefile > >> index 9561325c5201..ebf67bebe73d 100644 > >> --- a/arch/arm/Makefile > >> +++ b/arch/arm/Makefile > >> @@ -113,8 +113,7 @@ CFLAGS_ABI +=-funwind-tables > >> endif > >> > >> ifeq ($(CONFIG_THUMB2_KERNEL),y) > >> -AFLAGS_AUTOIT :=$(call as-option,-Wa$(comma)-mimplicit-it=always,-Wa$(comma)-mauto-it) > >> -CFLAGS_ISA :=-mthumb $(AFLAGS_AUTOIT) > >> +CFLAGS_ISA :=-mthumb -Wa$(comma)-mimplicit-it=always > > > > Is $(comma) still needed? I thought it was only needed when a flag > > that would contain commas would be in another set of parens (thus > > making an ambiguity), like cc-ldoption or such? Can you replace > > `$(comma)` here with `,`? I suspect it should work. > > Could catch, yes comma should work here. Cool, if you wouldn't mind sending a v2 with that change, feel free to add my reviewed by tag.
diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 9561325c5201..ebf67bebe73d 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -113,8 +113,7 @@ CFLAGS_ABI +=-funwind-tables endif ifeq ($(CONFIG_THUMB2_KERNEL),y) -AFLAGS_AUTOIT :=$(call as-option,-Wa$(comma)-mimplicit-it=always,-Wa$(comma)-mauto-it) -CFLAGS_ISA :=-mthumb $(AFLAGS_AUTOIT) +CFLAGS_ISA :=-mthumb -Wa$(comma)-mimplicit-it=always AFLAGS_ISA :=$(CFLAGS_ISA) -Wa$(comma)-mthumb # Work around buggy relocation from gas if requested: ifeq ($(CONFIG_THUMB2_AVOID_R_ARM_THM_JUMP11),y)
The assembler option -mauto-it is no longer a valid option. It has been removed from the documentation in July 2009, which is well before the release date of the currently supported binutils version 2.20. Signed-off-by: Stefan Agner <stefan@agner.ch> --- arch/arm/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)