| Message ID | 7h8uojk61a.fsf@paris.lan (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/26/2014 09:38 PM, Kevin Hilman wrote: > Tushar Behera <trblinux@gmail.com> writes: > >> On Thu, Jun 26, 2014 at 4:51 AM, Kevin Hilman <khilman@linaro.org> wrote: >>> Doug Anderson <dianders@google.com> writes: >>> >>>> Tushar, >>>> >>>> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera <tushar.b@samsung.com> wrote: >>>>> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. >>>>> As per the user manual, it should be CLK_MAU_EPLL. >>>>> >>>>> The problem surfaced when the bootloader in Peach-pit board set >>>>> the EPLL clock as the parent of AUDSS mux. While booting the kernel, >>>>> we used to get a system hang during late boot if CLK_MAU_EPLL was >>>>> disabled. >>>>> >>>>> Signed-off-by: Tushar Behera <tushar.b@samsung.com> >>>>> Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com> >>>>> Reported-by: Kevin Hilman <khilman@linaro.org> >>>>> --- >>>>> arch/arm/boot/dts/exynos5420.dtsi | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> I've tested this myself now as well. >>>> >>>> Tested-by: Doug Anderson <dianders@chromium.org> >>> >>> For me, this patch alone (on top of -next) doesn't solve the boot hang. >>> I still need clk_ignore_unused for a successful boot. >>> >>> So, this patch might be correct, but it doesn't prevent a boot hang >>> using a chain-loaded nv_uboot on peach-pi. There's still another clock >>> being disabled that causes a hang. >>> >>> Kevin >> >> Kevin, >> >> Can you please check if adding patch 1/3 alongwith patch 2/3 fixes the >> issue for you? > > Yes, using patch 1/3 along with 2/3 fixes the issue. > Okay, that adds some more reason to re-investigate patch 1/3. Kevin, Would you please provide me the environment setting of your u-boot? U-boot environment on my board has been over-written, I would like to set it same as yours and try to reproduce the issue at my end. With only 'sound init', I don't seem to hit this issue anymore. >> Also can you please confirm that setting CLK_IGNORE_UNUSED flag >> CLK_MAU_EPLL alone fixes the issue, without any need for >> clk_ignore_unused in u-boot bootargs? > > Yes, I have this patch[1] in my local branch which fixes the issue > alone, without clk_ignore_unused on the command line. > > Kevin > > > [1] > From ab1627127730ef4507ce96cbf95047d626bbb53f Mon Sep 17 00:00:00 2001 > From: Kevin Hilman <khilman@linaro.org> > Date: Thu, 5 Jun 2014 17:12:28 -0700 > Subject: [PATCH] KJH: leave mau_epll enabled > > --- > drivers/clk/samsung/clk-exynos5420.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c > index 61eccf0dd72f..ed175088ee7e 100644 > --- a/drivers/clk/samsung/clk-exynos5420.c > +++ b/drivers/clk/samsung/clk-exynos5420.c > @@ -911,7 +911,7 @@ static struct samsung_gate_clock exynos5x_gate_clks[] __initdata = { > SRC_MASK_TOP2, 24, 0, 0), > > GATE(CLK_MAU_EPLL, "mau_epll", "mout_mau_epll_clk", > - SRC_MASK_TOP7, 20, 0, 0), > + SRC_MASK_TOP7, 20, CLK_IGNORE_UNUSED, 0), > > /* sclk */ > GATE(CLK_SCLK_UART0, "sclk_uart0", "dout_uart0", >
On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera <trblinux@gmail.com> wrote: > Would you please provide me the environment setting of your u-boot? > U-boot environment on my board has been over-written, I would like to > set it same as yours and try to reproduce the issue at my end. With only > 'sound init', I don't seem to hit this issue anymore. Attached is a full boot log using v3.16-rc2 with my patch adding CLK_IGNORE_UNUSED to mau_epll and Doug's aclk66_peric patch. In the boot log, you'll see the output of 'printenv' inside u-boot where the environment is dumped. Hope that helps, Kevin
On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman <khilman@linaro.org> wrote: > On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera <trblinux@gmail.com> wrote: > >> Would you please provide me the environment setting of your u-boot? >> U-boot environment on my board has been over-written, I would like to >> set it same as yours and try to reproduce the issue at my end. With only >> 'sound init', I don't seem to hit this issue anymore. > > Attached is a full boot log using v3.16-rc2 with my patch adding > CLK_IGNORE_UNUSED to mau_epll and Doug's aclk66_peric patch. In the > boot log, you'll see the output of 'printenv' inside u-boot where the > environment is dumped. Oops, I sent you a boot log for the octa board. Here's the one for peach-pi with the same kernel (built with upstream exynos_defconfig) Kevin
On 06/27/2014 08:18 PM, Kevin Hilman wrote: > On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman <khilman@linaro.org> wrote: >> On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera <trblinux@gmail.com> wrote: >> >>> Would you please provide me the environment setting of your u-boot? >>> U-boot environment on my board has been over-written, I would like to >>> set it same as yours and try to reproduce the issue at my end. With only >>> 'sound init', I don't seem to hit this issue anymore. >> >> Attached is a full boot log using v3.16-rc2 with my patch adding >> CLK_IGNORE_UNUSED to mau_epll and Doug's aclk66_peric patch. In the >> boot log, you'll see the output of 'printenv' inside u-boot where the >> environment is dumped. > > Oops, I sent you a boot log for the octa board. Here's the one for > peach-pi with the same kernel (built with upstream exynos_defconfig) > > Kevin > The u-boot version is a little different on my Peach-Pi as compared to the market release version. Not sure if that is making any difference. Peach # version U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) 4.8.x-google 20130905 (prerelease) GNU ld (binutils-2.22_cos_gg_2) 2.22
On 07/01/14 20:59, Tushar Behera wrote: > On 06/27/2014 08:18 PM, Kevin Hilman wrote: >> On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman<khilman@linaro.org> wrote: >>> On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera<trblinux@gmail.com> wrote: >>> >>>> Would you please provide me the environment setting of your u-boot? >>>> U-boot environment on my board has been over-written, I would like to >>>> set it same as yours and try to reproduce the issue at my end. With only >>>> 'sound init', I don't seem to hit this issue anymore. >>> >>> Attached is a full boot log using v3.16-rc2 with my patch adding >>> CLK_IGNORE_UNUSED to mau_epll and Doug's aclk66_peric patch. In the >>> boot log, you'll see the output of 'printenv' inside u-boot where the >>> environment is dumped. >> >> Oops, I sent you a boot log for the octa board. Here's the one for >> peach-pi with the same kernel (built with upstream exynos_defconfig) >> >> Kevin >> > > The u-boot version is a little different on my Peach-Pi as compared to > the market release version. Not sure if that is making any difference. > > Peach # version > > U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach > armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) > 4.8.x-google 20130905 (prerelease) > GNU ld (binutils-2.22_cos_gg_2) 2.22 > Note that I've applied this only from this series so I'm not sure how much the problem can be solved...any updates for 1/3 and 3/3? - Kukjin
On 07/08/2014 05:04 AM, Kukjin Kim wrote: > On 07/01/14 20:59, Tushar Behera wrote: >> On 06/27/2014 08:18 PM, Kevin Hilman wrote: >>> On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman<khilman@linaro.org> >>> wrote: >>>> On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera<trblinux@gmail.com> >>>> wrote: >>>> >>>>> Would you please provide me the environment setting of your u-boot? >>>>> U-boot environment on my board has been over-written, I would like to >>>>> set it same as yours and try to reproduce the issue at my end. With >>>>> only >>>>> 'sound init', I don't seem to hit this issue anymore. >>>> >>>> Attached is a full boot log using v3.16-rc2 with my patch adding >>>> CLK_IGNORE_UNUSED to mau_epll and Doug's aclk66_peric patch. In the >>>> boot log, you'll see the output of 'printenv' inside u-boot where the >>>> environment is dumped. >>> >>> Oops, I sent you a boot log for the octa board. Here's the one for >>> peach-pi with the same kernel (built with upstream exynos_defconfig) >>> >>> Kevin >>> >> >> The u-boot version is a little different on my Peach-Pi as compared to >> the market release version. Not sure if that is making any difference. >> >> Peach # version >> >> U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach >> armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) >> 4.8.x-google 20130905 (prerelease) >> GNU ld (binutils-2.22_cos_gg_2) 2.22 >> > > Note that I've applied this only from this series so I'm not sure how > much the problem can be solved...any updates for 1/3 and 3/3? > > - Kukjin Thanks for applying 2/3. I am working on 1/3 to see if we are following the right approach to fix Kevin's issue (unfortunately, I am not hitting the bug on my board ATM). 3/3 has already been merged through a different patchset.
Hello Tushar, On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera <trblinux@gmail.com> wrote: >>> >>> The u-boot version is a little different on my Peach-Pi as compared to >>> the market release version. Not sure if that is making any difference. >>> >>> Peach # version >>> >>> U-Boot 2013.04 (Feb 13 2014 - 16:35:03) for Peach >>> armv7a-cros-linux-gnueabi-gcc.real (4.8.1_cos_gg_feea904_4.8.1-r66) >>> 4.8.x-google 20130905 (prerelease) >>> GNU ld (binutils-2.22_cos_gg_2) 2.22 >>> >> I'm using the same U-Boot version than Kevin (U-Boot 2013.04-gb98ed09) and on my setup using chained nv-uboot I also need patch 1/3 along with 2/3 to fix the issue. >> Note that I've applied this only from this series so I'm not sure how >> much the problem can be solved...any updates for 1/3 and 3/3? >> >> - Kukjin > > Thanks for applying 2/3. I am working on 1/3 to see if we are following > the right approach to fix Kevin's issue (unfortunately, I am not hitting > the bug on my board ATM). 3/3 has already been merged through a > different patchset. > I'm sending as an attachment my complete boot log when booting today's next (20140709) until it hangs and my u-boot env vars. I hope that helps. > -- > Tushar Behera > -- Best regards, Javier
diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c index 61eccf0dd72f..ed175088ee7e 100644 --- a/drivers/clk/samsung/clk-exynos5420.c +++ b/drivers/clk/samsung/clk-exynos5420.c @@ -911,7 +911,7 @@ static struct samsung_gate_clock exynos5x_gate_clks[] __initdata = { SRC_MASK_TOP2, 24, 0, 0), GATE(CLK_MAU_EPLL, "mau_epll", "mout_mau_epll_clk", - SRC_MASK_TOP7, 20, 0, 0), + SRC_MASK_TOP7, 20, CLK_IGNORE_UNUSED, 0), /* sclk */ GATE(CLK_SCLK_UART0, "sclk_uart0", "dout_uart0",